Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway

2014-01-16 Thread Jeff Trawick
On Thu, Dec 5, 2013 at 9:13 AM, Bert Huijben b...@qqmail.nl wrote: Hi, On Windows apr_arch_misc.h checks for the ‘WINNT’ define, which was unconditionally defined on Windows before the CMake build. But now it is no longer defined. This enables some additional dynamic load

CMake build doesn't define 'WINNT', but apr headers check for it anyway

2013-12-05 Thread Bert Huijben
Hi, On Windows apr_arch_misc.h checks for the 'WINNT' define, which was unconditionally defined on Windows before the CMake build. But now it is no longer defined. This enables some additional dynamic load operations that could fail in some cases (See Race condition in

Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway

2013-12-05 Thread Jeff Trawick
On Thu, Dec 5, 2013 at 9:13 AM, Bert Huijben b...@qqmail.nl wrote: Hi, On Windows apr_arch_misc.h checks for the ‘WINNT’ define, which was unconditionally defined on Windows before the CMake build. But now it is no longer defined. This enables some additional dynamic load

Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway

2013-12-05 Thread Gregg Smith
G. On 12/5/2013 9:23 AM, Gregg Smith wrote: On 12/5/2013 6:48 AM, Jeff Trawick wrote: On Thu, Dec 5, 2013 at 9:13 AM, Bert Huijben b...@qqmail.nl mailto:b...@qqmail.nl wrote: Hi, On Windows apr_arch_misc.h checks for the ‘WINNT’ define, which was unconditionally defined on Windows before

Re: CMake build doesn't define 'WINNT', but apr headers check for it anyway

2013-12-05 Thread William A. Rowe Jr.
On Thu, 05 Dec 2013 09:24:24 -0800 Gregg Smith g...@gknw.net wrote: Once all the 9x stuff is gone, we can drop the define. Precisely. And that would be a version-major/minor change, imho. In the interim, simply -D (ugh... /D it) WINNT. Problem solved. Leave it there for someone to discover