Re: Renaming SideOutput

This question maybe obvious to others but why is there a distinction between main output and additional outputs? Why not just have a simple list of outputs where the first one is the Main one. -- AC Sent from my iPhone > On Apr 12, 2017, at 18:08, Melissa Pashniak

Re: Renaming SideOutput

I agree, I'll create a PR with the doc changes (the rename + text changes to make things more clear). I know of at least 2 places we refer to side outputs (programming guide and the "Design your pipeline" page). On Tue, Apr 11, 2017 at 5:34 PM, Thomas Groh wrote: > I

Re: Renaming SideOutput

Cool! I've filed https://issues.apache.org/jira/browse/BEAM-1949 and authored https://github.com/apache/beam/pull/2512 to make this change. On Tue, Apr 11, 2017 at 11:33 PM, Ted Yu wrote: > +1 > > > On Apr 11, 2017, at 5:34 PM, Thomas Groh >

Re: Renaming SideOutput

+1 > On Apr 11, 2017, at 5:34 PM, Thomas Groh wrote: > > I think that's a good idea. I would call the outputs of a ParDo the "Main > Output" and "Additional Outputs" - it seems like an easy way to make it > clear that there's one output that is always expected, and

RE: Renaming SideOutput

omas Groh [mailto:tg...@google.com.INVALID] Sent: Wednesday, April 12, 2017 4:56 AM To: dev@beam.apache.org Subject: Renaming SideOutput Hey everyone: I'd like to rename DoFn.Context#sideOutput to #output (in the Java SDK). Having two methods, both named output, one which takes the "main output

Re: Renaming SideOutput

To:dev@beam.apache.org <dev@beam.apache.org>Subject:答复: Renaming > SideOutput > +1 more clearer > > > -邮件原件- > 发件人: Ankur Chauhan [mailto:an...@malloc64.com] > 发送时间: 2017年4月12日 10:36 > 收件人: dev@beam.apache.org > 主题: Re: Renaming SideOutput > > > +1

Re: Renaming SideOutput

strong +1 best, JingsongLee--From:Tang Jijun(上海_技术部_数据平台_唐觊隽) <tangji...@yhd.com>Time:2017 Apr 12 (Wed) 10:39To:dev@beam.apache.org <dev@beam.apache.org>Subject:答复: Renaming SideOutput +1 more clearer -邮件原件

答复: Renaming SideOutput

+1 more clearer -邮件原件- 发件人: Ankur Chauhan [mailto:an...@malloc64.com] 发送时间: 2017年4月12日 10:36 收件人: dev@beam.apache.org 主题: Re: Renaming SideOutput +1 this is pretty much the topmost things that I found odd when starting with the beam model. It would definitely be more intuitive to have

Re: Renaming SideOutput

+1 this is pretty much the topmost things that I found odd when starting with the beam model. It would definitely be more intuitive to have a consistent name. Sent from my iPhone > On Apr 11, 2017, at 18:29, Aljoscha Krettek wrote: > > +1 > >> On Wed, Apr 12, 2017, at

Re: Renaming SideOutput

+1 On Wed, Apr 12, 2017, at 02:34, Thomas Groh wrote: > I think that's a good idea. I would call the outputs of a ParDo the "Main > Output" and "Additional Outputs" - it seems like an easy way to make it > clear that there's one output that is always expected, and there may be > more. > > On

Re: Renaming SideOutput

I think that's a good idea. I would call the outputs of a ParDo the "Main Output" and "Additional Outputs" - it seems like an easy way to make it clear that there's one output that is always expected, and there may be more. On Tue, Apr 11, 2017 at 5:29 PM, Robert Bradshaw <

Re: Renaming SideOutput

We should do some renaming in Python too. Right now we have SideOutputValue which I'd propose naming TaggedOutput or something like that. Should the docs change too? https://beam.apache.org/documentation/programming-guide/#transforms-sideio On Tue, Apr 11, 2017 at 5:25 PM, Kenneth Knowles

Re: Renaming SideOutput

+1 ditto about sideInput and sideOutput not actually being related On Tue, Apr 11, 2017 at 3:52 PM, Robert Bradshaw < rober...@google.com.invalid> wrote: > +1, I think this is a lot clearer. > > On Tue, Apr 11, 2017 at 2:24 PM, Stephen Sisk > wrote: > > strong +1 for

Re: Renaming SideOutput

+1, I think this is a lot clearer. On Tue, Apr 11, 2017 at 2:24 PM, Stephen Sisk wrote: > strong +1 for changing the name away from sideOutput - the fact that > sideInput and sideOutput are not really related was definitely a source of > confusion for me when learning

Re: Renaming SideOutput

strong +1 for changing the name away from sideOutput - the fact that sideInput and sideOutput are not really related was definitely a source of confusion for me when learning beam. S On Tue, Apr 11, 2017 at 1:56 PM Thomas Groh wrote: > Hey everyone: > > I'd like to

Renaming SideOutput

Hey everyone: I'd like to rename DoFn.Context#sideOutput to #output (in the Java SDK). Having two methods, both named output, one which takes the "main output type" and one that takes a tag to specify the type more clearly communicates the actual behavior - sideOutput isn't a "special" way to