+1(no-binding)
Thanks
ZhangJian He
thetumbled 于2024年4月30日 周二11:06写道：
> Hi, everyone.I would like to start voting thread for BP-66: support
> throttling for zookeeper read of rereplication.Proposal PR:
> https://github.com/apache/bookkeeper/pull/4258
> Implementation
Hi, ZhangJian He.
Thanks for your feedback.
> autorecovery on every bookie, and not run it as a part of a bookie process.
> I'd go as far as to call it the best practice. As Andrey said, I think that's
> the best practice to maintain big bookkeeper clusters.
It is the the best practice to
>> In such configuration (and in general) I'd recommend not to run
autorecovery on every bookie, and not run it as a part of a bookie process.
I'd go as far as to call it the best practice.
As Andrey said, I think that's the best practice to maintain big bookkeeper
clusters.
+0.5 for this change.
+1
I am ok with the change if we maintain default behavior the same as now (no
throttling).
I left comments on implementation PR.
On Mon, Apr 1, 2024 at 1:54 AM thetumbled wrote:
> Hi all,
> I create a new BP to relieve the pressure of Zookeeper caused by auto
> recovery, Looking forward to
Hi Lari, Thanks for your nice explanation and work in
https://github.com/apache/bookkeeper/pull/4197.
>> Summary: let's use Junit 5 & AssertJ for all new tests and migrate from
Junit 4 to Junit 5 when that provides some value (for example parameterized
tests).
I agree, and leverage annotation
Support for JUnit 5 tests was added in
https://github.com/apache/bookkeeper/pull/4197. Junit 4 and Junit 5 tests can
co-exist in the code base. Junit 5 (Jupiter) test runner is used for test
execution.
While switching to use Junit 5, it's worth considering primarily using AssertJ
for more
>> Please ensure that on CI we always both the 2 families of tests until we
completed the migration
It works well. Yes, Like in workflow
https://github.com/apache/bookkeeper/actions/runs/8873903044/job/24360578932.
TestDirectReader,TestDirectWriter runs normally, and they are already
junit5.
I
ZhangJian
Il giorno mer 24 apr 2024 alle ore 18:58 ZhangJian He
ha scritto:
> I am reaching out to propose a gradual migration of our testing framework
> from JUnit 4 to JUnit 5 across the BookKeeper. JUnit 5 offers significant
> improvements over JUnit 4, including more powerful and flexible
