Re: Filterable table

2019-08-11 Thread Danny Chan
Thanks, Albert ~ The ProjectableFilterableTable is indeed a little redundant, because we already have ProjectableTable and FilterableTable, I think we can do some refactoring to reduce such mixed in interfaces. BTW, what do you mean by aggregate push down ? I can not figure out in which case

Re: Filterable table

2019-08-11 Thread Albert
talking about this class reminds me of my own usage of ProjectableFilterable. it works. but this feels like a very bad design, what if I want to push down Aggregation ? AggregatableProjectableFilterable? I don't know the intention of the initial design, but this just doesn't feel right. On Mon,

[jira] [Created] (CALCITE-3241) Calcite this is a very strange mistake

2019-08-11 Thread ;ianghaibin (JIRA)
;ianghaibin created CALCITE-3241: Summary: Calcite this is a very strange mistake Key: CALCITE-3241 URL: https://issues.apache.org/jira/browse/CALCITE-3241 Project: Calcite Issue Type: Bug

Re: Contributor in JIRA

2019-08-11 Thread Danny Chan
Welcome, Uma ! Best, Danny Chan 在 2019年8月10日 +0800 AM1:17,Umesh S ,写道: > Hi, > > Please add me as contributor in JIRA. My username is uma.thakur > > - > Thanks > Uma

Re: Filterable table

2019-08-11 Thread Danny Chan
There is a ProjectableFilterableTable[1] that can be both used for filter and projects push down, have a try :) [1]  https://github.com/apache/calcite/blob/996cdd0249a4e5086fadc27a15ccc23eb9defd8e/core/src/main/java/org/apache/calcite/schema/ProjectableFilterableTable.java#L36 Best, Danny Chan

Re: Filterable table

2019-08-11 Thread Lekshmi
Hi Danny Chan, Thank you so much for responding to my email. Can we use, Translatable table instead of Filterable table? which is more efficient? Usecase that if need to write a Project push down (Push down Project fields into table scan then do Filtering) and Filter push down? Or Filterable

[jira] [Created] (CALCITE-3240) Javadoc gives internal error "com.sun.tools.javac.code.ClassFinder$BadClassFile: bad class file: linq4j/target/classes/org/apache/calcite/linq4j/Ord$2.class [ERROR] u

2019-08-11 Thread Julian Hyde (JIRA)
Julian Hyde created CALCITE-3240: Summary: Javadoc gives internal error "com.sun.tools.javac.code.ClassFinder$BadClassFile: bad class file: linq4j/target/classes/org/apache/calcite/linq4j/Ord$2.class [ERROR] undeclared type variable: E"

Re: Assigning jira issue

2019-08-11 Thread XING JIN
Thanks a lot ~ Francis Francis Chuang 于2019年8月9日周五 上午11:13写道: > Hi Xing Jin, > > I've added you to the contributor role. > > Francis > > On 9/08/2019 12:52 pm, XING JIN wrote: > > Hi Francis, > > I have the same request with Sahith. > > Could you please add me to the contributor list as well ?

[jira] [Created] (CALCITE-3239) Calc#accept(RexShuttle shuttle) does not update rowType

2019-08-11 Thread jin xing (JIRA)
jin xing created CALCITE-3239: - Summary: Calc#accept(RexShuttle shuttle) does not update rowType Key: CALCITE-3239 URL: https://issues.apache.org/jira/browse/CALCITE-3239 Project: Calcite Issue