Re: Re: [DISCUSS] Small contributions

Agree with Francis's point: people are likely to move on than accumulating enough to have a larger PR to merge, which does not help improve Calcite's codebase. I understand it would increase the workload on Calcite committers (more PRs to review), so at least code reviewers can always encourage

Re: How to modify data for custom tables through Calcite.

@Danny Chan Thanks Danny, is there any document or test for me to learn `specific convention` more? Regards, Trista Juan Pan panj...@apache.org Juan Pan(Trista), Apache ShardingSphere On 09/26/2019 12:02，Danny Chan wrote： @Rui Wang, Yes, I wrote the Flink-sql-parser module it did

Re: How to modify data for custom tables through Calcite.

@Rui Wang, Yes, I wrote the Flink-sql-parser module it did support insert grammar well. @Juan Pan you need the converter rules to convert all the nodes to specific convention you want, also specify the desired convention in the trait set of your planing program. Best, Danny Chan 在 2019年9月26日

[jira] [Created] (CALCITE-3373) Decorrelate boolean context IN or existential subquery directly into SEMI/ANTI join

jin xing created CALCITE-3373: - Summary: Decorrelate boolean context IN or existential subquery directly into SEMI/ANTI join Key: CALCITE-3373 URL: https://issues.apache.org/jira/browse/CALCITE-3373

Re: Re: [DISCUSS] Small contributions

> most of the time, the author of the fix would have moved on and have forgotten about it, resulting in the improvement falling through the cracks. ​Make sense. I think our current position worth reconsidering and I agree with Francis. - Haisheng

Re: [DISCUSS] Small contributions

From personal experience, I think we should accept these small changes. I have had lots of cases where I am reading code or documentation on Github and found small errors or typos that are easy to fix, so I'd edit directly in Github and open a PR. These changes do improve the codebase and fix

Re: [DISCUSS] Small contributions

I have mixed feelings about this, because on one hand, I'd like to have these things corrected but on the other hand, we're already bogged down with PRs. Perhaps a good compromise is to make it clear that a JIRA should not be created and have some type of tag indicated in the title of the PR. This

[DISCUSS] Small contributions

I noticed this exchange in https://github.com/apache/calcite/pull/1475: > Q. Just curious, does Calcite accept hotfix style PR that fixes typos, > comments, etc.? > A. As long as they are large enough. But for 1 line typo fix, it is not worth >

Re: How to modify data for custom tables through Calcite.

Another data point is both BeamSQL and FlinkSQL support DDL by an extensive way (and I believe it works through Avitica as well). BeamSQL: [1] FlinkSQL: [2] Calcite allows add customized DDL in parser and also in implementation schema is accessible. [1]:

Re: How to modify data for custom tables through Calcite.

Hi Trista, I think the server module is doing what you are asking for. Have a look in ServerTest [1]. As Gelbana mentioned the implementation is based on implementations of the ModifiableTable interface. Best, Stamatis [1]

Re: Trivial query simplification

Il mer 25 set 2019, 23:38 Stamatis Zampetakis ha scritto: > Hi Enrico, > > The ReduceExpressionsRule.FILTER_INSTANCE is using the simplifier so if it > works > correctly I don't think there is anything more to be done. > Fine. Cheers Enrico > > Best, > Stamatis > > On Wed, Sep 25, 2019 at

Re: Trivial query simplification

Hi Enrico, The ReduceExpressionsRule.FILTER_INSTANCE is using the simplifier so if it works correctly I don't think there is anything more to be done. Best, Stamatis On Wed, Sep 25, 2019 at 5:31 PM Enrico Olivelli wrote: > Thank you for your feedback. > > Actually

Calcite-Master - Build # 1355 - Still Failing

The Apache Jenkins build system has built Calcite-Master (build #1355) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/1355/ to view the results.

Re: How to modify data for custom tables through Calcite.

I haven't done that before but I would start investigating from this interface [1]. Please share your experience if you get this done. [1] org.apache.calcite.schema.ModifiableTable On Wed, Sep 25, 2019 at 2:00 PM Juan Pan wrote: > Hi everyone, > > > Thanks for your attention. I want to know

[DISCUSS] [CALCITE-3340] Table Function TUMBLE as an operator in SqlStdOperator

Hi community, In order to support TUMBLE as a TABLE function (see CALCITE-3272), the first step is to add a new operator in SqlStdOperatorTable(which is CALCITE-3340). Note that new operator will need a name, which is the syntax used in a query. For example, GROUP BY TUMBE(...) will lead to a

[jira] [Created] (CALCITE-3372) Add a rule to transform a semijoin into a join on top of aggregate

Haisheng Yuan created CALCITE-3372: -- Summary: Add a rule to transform a semijoin into a join on top of aggregate Key: CALCITE-3372 URL: https://issues.apache.org/jira/browse/CALCITE-3372 Project:

Re: Trivial query simplification

Thank you for your feedback. Actually ReduceExpressionsRule.FILTER_INSTANCE fixes the problem. RelOptPlanner optPlanner = cluster.getPlanner(); optPlanner.addRule(ReduceExpressionsRule.FILTER_INSTANCE); This code I had was wrong: final FrameworkConfig config = Frameworks.newConfigBuilder()

How to modify data for custom tables through Calcite.

Hi everyone, Thanks for your attention. I want to know the following description is right or not? "Modification has only been worked on for JDBC tables, not for any custom tables currently.” Query SQL on custom table is ok, so i am wondering whether i can execute `update/insert/delete`

[jira] [Created] (CALCITE-3371) revise doc

xzh_dz created CALCITE-3371: --- Summary: revise doc Key: CALCITE-3371 URL: https://issues.apache.org/jira/browse/CALCITE-3371 Project: Calcite Issue Type: Wish Reporter: xzh_dz h1.