Re: [DISCUSS] Automated security fixes via dependabot

2019-10-12 Thread Julian Hyde
I’ve not looked at the PRs but they sound useful. Keeping software secure these days is a moving target; we have to do work just to keep up. All of our dependencies are doing that work too, and so we need to keep up to date with them. I think it would be useful to have a task before each

Re: Re: Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread Stamatis Zampetakis
I was thinking that RelFieldTrimmer can be used to transform the plan P1 to plan P2 and then ProjectTableScanRule can be used to introduce the BindableTableScan. The consumer in the case of P1 is the project which only needs $0, $2, $5, $6 so the trimmer could slim down the scan by projecting

Re: Apache Calcite Geode

2019-10-12 Thread Andrei Sereda
Hi Viquar Khan, Currently write operations (UPDATE / DELETE / INSERT) are not supported by geode-calcite adapter. You need to load data using native API then query it using Calcite. There is some documentation on our website: https://calcite.apache.org/docs/geode_adapter.html but it is by no

Re: [DISCUSS] Automated security fixes via dependabot

2019-10-12 Thread Muhammad Gelbana
Why would we not merge those PRs or even disable the whole thing ? On Fri, Oct 11, 2019 at 12:09 AM Francis Chuang wrote: > Dependabot is a bot on Github that opens PRs to automatically upgrade > out of date dependencies to fix security issues. Recently, Github > acquired dependabot and is

Re:Re: Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread Wang Yanlin
Just a little curious, RelFieldTrimmer is used to 'slimmed down' relational expression that projects only the columns required by its consumer. How can it used to do this thing? -- Best, Wang Yanlin 在 2019-10-12 18:03:33,"XING JIN" 写道: >Sure we can ~ >If we use BindableTableScanRule to

Re: Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread XING JIN
Sure we can ~ If we use BindableTableScanRule to derive a BindableTableScan from ProjectableFilterableTable, that would happen during a stage of optimization run by RelOptPlanner. But RelFieldTrimmer works right during conversion of Sql to Rel. Wang Yanlin <1989yanlinw...@163.com> 于2019年10月12日周六

Re:Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread Wang Yanlin
Can we just use Bindables.BINDABLE_TABLE_SCAN_RULE to translate the table scan to BindableTableScan ? -- Best, Wang Yanlin At 2019-10-12 17:12:20, "XING JIN" wrote: >Hi Stamatis, >In current code, BindableTableScan is only created by rules of >ProjectTableScanRule and

Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread XING JIN
Hi Stamatis, In current code, BindableTableScan is only created by rules of ProjectTableScanRule and FilterTableScanRule. I think it's better to keep as it is? I made a PR for CALCITE-3405 -- https://github.com/apache/calcite/pull/1500 The idea of the PR is quite straightforward: 1. Analyze the

Re: [QUESTION] Pushing up evaluations from LogicalProjects

2019-10-12 Thread Stamatis Zampetakis
Hi Rommel, I was hoping that this could be done at least by RelFieldTrimmer [1]. Are you using it already? Best, Stamatis [1] https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java On Sat, Oct 12, 2019 at 6:06 AM XING JIN wrote: >