[jira] [Created] (CALCITE-6231) ORDINALITY is omitted during the RelToSql stage

2024-01-26 Thread EveyWu (Jira)
EveyWu created CALCITE-6231: Summary: ORDINALITY is omitted during the RelToSql stage Key: CALCITE-6231 URL: https://issues.apache.org/jira/browse/CALCITE-6231 Project: Calcite Issue Type: Bug

continuous-integration/jenkins always failed

2024-01-26 Thread Ran Tao
Recently calcite's ci has a total of 25 tasks, but the last one continuous-integration/jenkins/branch seems to keep failing [1], and the error is often heap space exhausted. Although it does not affect the merging of PRs, looking at the commit list, a series of red x's is always a bit strange

Re: calcite 1.36.0 release procedures

2024-01-26 Thread Guillaume Masse
Hi Julian, I don't think it's necessary to require JDK > 8. Here is what I propose: 1) I can add a gradle task to make sure each classfile from the release jars are valid bytecode. 2) I think we need to make sure we compile with the latest build available. Per

Re: Index Based QueryableTable Implementation

2024-01-26 Thread Julian Hyde
There is class AbstractQueryable so you shouldn’t need to implement the whole interface by hand. However, a better next step after FilterableTable is not QueryableTable, but Table with a few planner rules to push down filters, projects, etc. Calcite gets its intelligence from how rules compose

Re: Question on `Expressions#constant` accepting only public field models

2024-01-26 Thread Julian Hyde
It’s reasonable to extend the kind of fields that we allow. You should log a jira case and submit a PR with appropriate tests. It might be tricky to test Java records given that the test suite needs to compile and pass on JDK 8, but maybe you can do something using reflection. Julian > On

Re: calcite 1.36.0 release procedures

2024-01-26 Thread Julian Hyde
These JDK bugs seem to be fixed in more recent java versions. Should we mandate that releases are built on a recent JDK (say 17 or 21)? Currently we mandate JDK 8. > On Jan 26, 2024, at 9:03 AM, Ruben Q L wrote: > > I have the impression that this might be caused by a bug in the JDK, see >

Re: [Question] Query Introspection on SqlNode, RexNode, and RelNode

2024-01-26 Thread Julian Hyde
Matthew, For the kinds of tasks that you mention, I tend to use the visitors. For example, to find whether can expression contains an IS NULL operator: public static boolean containsIsNull(RexNode e) { try { e.accept(new RexVisitorImpl(true) { @Override public Void

Jenkins build is back to normal : Calcite » Calcite-snapshots #789

2024-01-26 Thread Apache Jenkins Server
See

Re: [Question] Query Introspection on SqlNode, RexNode, and RelNode

2024-01-26 Thread Mihai Budiu
Hello. I am not sure what you mean by "introspection". I assume you have seen this blog post about the 3 calcite IRs that you mention: https://www.feldera.com/blog/calcite-irs/ Visitors are the way to go for traversing these data structures. Mihai From: Matthew

Re: calcite 1.36.0 release procedures

2024-01-26 Thread Ruben Q L
I have the impression that this might be caused by a bug in the JDK, see similar issues: https://gitlab.ow2.org/asm/asm/-/issues/317789 https://bugs.openjdk.org/browse/JDK-8144185 https://bugs.openjdk.org/browse/JDK-8187805 On Thu, Dec 21, 2023 at 8:58 PM Julian Hyde wrote: > I think I was

Re: Collection of some jira cases

2024-01-26 Thread Alessandro Solimando
Thank Ran Tao, my point exactly, Jira tickets are not meant to be used in this way in the scope of our project, although I get the motivation and I agree with it. For the beginners contributions, there is consensus on using the "newbie" label (as per the discussion I linked above), since you went

Re: Collection of some jira cases

2024-01-26 Thread Ran Tao
The starting point is good, but it seems a bit strange to collect some unrelated issues and put them under one ticket (a jira case collection). If it’s a personal blog, it’s okay to collect some interesting issues that followers can check out. I guess Hongyu just wants to find a page to maintain

Re: Collection of some jira cases

2024-01-26 Thread Hongyu Guo
Some active communities use the tags "good first issues" or "newbie" to help new members quickly integrate into the community. Additionally, these communities often create a "roadmap" to outline the future development plans. In the case of Calcite, there are not many Jira cases labeled as

Re: Collection of some jira cases

2024-01-26 Thread Alessandro Solimando
Hi Hongyu, I replied to the ticket before seeing your email. For tickets for new contributors there has been a discussion in the ML, with agreement on using a label (see https://lists.apache.org/thread/jwc5g5msznlwcq73gh1vqg82dlmn1g1r). For interesting tickets that should be worked on, people

Collection of some jira cases

2024-01-26 Thread Hongyu Guo
Hi devs, Calcite currently has over 1000 unresolved issues[1], and I have gathered a few Jira cases that I find interesting[2]. These cases are helpful for newcomers who want to contribute their first line of code to the Calcite community but are unsure where to begin. If you believe there are

[jira] [Created] (CALCITE-6230) Jira case collections

2024-01-26 Thread hongyu guo (Jira)
hongyu guo created CALCITE-6230: --- Summary: Jira case collections Key: CALCITE-6230 URL: https://issues.apache.org/jira/browse/CALCITE-6230 Project: Calcite Issue Type: Task

Question on `Expressions#constant` accepting only public field models

2024-01-26 Thread Wegdan Ghazi
Hello devs! I'm currently working on a `TranslatableTable` implementation, in which I also use a custom implementation of `TableScan` that implements `EnumerableRel#implement`. For this logic, I need to pass Model Objects through generated code for processing using `Expressions#constant`,

Re: [Question] Query Introspection on SqlNode, RexNode, and RelNode

2024-01-26 Thread LakeShen
Hi Matthew McMillian, Could you give some sql examples to explain your question? I still don't quite understand your question. Best, LakeShen Matthew McMillian 于2024年1月26日周五 11:30写道: > Hi Calcite Devs, > > Before I start, I just wanted to say that Calcite is a really awesome > framework!