Re: [ANNOUNCE] New committer: Zhaohui Xu

2021-10-12 Thread Feng Zhu
Congratulations! Best, Feng Stamatis Zampetakis 于2021年10月7日周四 上午4:48写道: > Apache Calcite's Project Management Committee (PMC) has invited Zhaohui Xu > to > become a committer, and we are pleased to announce that they have accepted. > > Numbers speak for themselves and Zhaohui has over 30

Re: [ANNOUNCE] New Calcite PMC chair: Haisheng Yuan

2020-12-17 Thread Feng Zhu
Thanks for your work and effort, Stamatis! Congratulations, Haisheng! Stamatis Zampetakis 于2020年12月17日周四 下午9:49写道: > Calcite community members, > > I am pleased to announce that we have a new PMC chair and VP as per our > tradition of rotating the chair once a year. I have resigned, and >

Re: [ANNOUNCE] New committer: Rui Wang

2020-09-09 Thread Feng Zhu
Congrats Rui! Good Job in Streams, well deserved! Best, Feng Stamatis Zampetakis 于2020年9月10日周四 上午5:51写道: > Apache Calcite's Project Management Committee (PMC) has invited Rui Wang to > become a committer, and we are pleased to announce that he has accepted. > > Rui has checked in a lot of

Re: [ANNOUNCE] Ruben Quesada Lopez joins Calcite PMC

2020-08-11 Thread Feng Zhu
Congratulations, Ruben! chunwei 于2020年8月12日周三 上午9:57写道: > Congrats, Ruben! > > On Wed, Aug 12, 2020 at 8:58 AM XING JIN wrote: > > > Congrats, Ruben! > > > > 953396112 <953396...@qq.com> 于2020年8月12日周三 上午7:47写道: > > > > > Congratulations,Ruben! > > > > > > > > > xzh > > >

Re: Re: Exception:Catch clause is unreachable

2020-07-23 Thread Feng Zhu
Hi tony: I guess there is no column in you table *test.t*. This piece of code is generated by *JdbcToEnumerableConverter*. In general, the logic extracts fields from *ResultSet*, and the catch clause is necessary. When the field count is 0, we can shot the issue. try { >

[jira] [Created] (CALCITE-4116) Remove unused code for tracking RexNode's nullable state in codegen

2020-07-09 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-4116: - Summary: Remove unused code for tracking RexNode's nullable state in codegen Key: CALCITE-4116 URL: https://issues.apache.org/jira/browse/CALCITE-4116 Project: Calcite

Re: [VOTE] Release apache-calcite-1.23.0 (release candidate 1)

2020-05-18 Thread Feng Zhu
Thanks for work, Haisheng! Environment: Windows-10/Mac-OS JDK version: 1.8.0_241 Release notes: OK Build with tests: OK Checksums and signatures: OK Vote: +1 (non-binding) Haisheng Yuan 于2020年5月16日周六 下午12:02写道: > Hi all, > > I have created a build for Apache Calcite 1.23.0, release >

Re: Question of Calcite Dynamic Code Generation Feature

2020-05-13 Thread Feng Zhu
Codegen is a common technique for performance. You can find its history from some research work (e.g. [1]). [1] “Efficiently Compiling Efficient Query Plans for Modern Hardware,” PVLDB, vol. 4, no. 9, pp. 539–550, 2011 https://www.vldb.org/pvldb/vol4/p539-neumann.pdf 徐泷泽 <15258826...@qq.com>

Re: [ANNOUNCE] New committer: Forward Xu

2020-04-28 Thread Feng Zhu
Congrations! Forward! best, Feng Chunwei Lei 于2020年4月29日周三 上午10:17写道: > Congrats, Forward! > > > > Best, > Chunwei > > > On Wed, Apr 29, 2020 at 6:46 AM Rui Wang wrote: > > > Congrats! > > > > > > -Rui > > > > On Tue, Apr 28, 2020 at 3:04 PM Francis Chuang > > > wrote: > > > > > Congrats,

Re: [ANNOUNCE] New committer: Jin Xing

2020-04-28 Thread Feng Zhu
Congrations! best, Feng Chunwei Lei 于2020年4月29日周三 上午10:16写道: > Congrats, Jin! > > > Best, > Chunwei > > > On Wed, Apr 29, 2020 at 10:07 AM Forward Xu > wrote: > > > Congrats > > > > > > best, > > > > Forward > > > > 953396112 <953396...@qq.com> 于2020年4月29日周三 上午8:21写道: > > > > > Congrats, Jin

Re: [ANNOUNCE] New committer: Wang Yanlin

2020-04-28 Thread Feng Zhu
Congrations! Yanlin! best, Feng Chunwei Lei 于2020年4月29日周三 上午10:16写道: > Congrats, Yanlin! > > > Best, > Chunwei > > > On Wed, Apr 29, 2020 at 10:07 AM Forward Xu > wrote: > > > Congrats > > > > > > Best, > > > > Forward > > > > 953396112 <953396...@qq.com> 于2020年4月29日周三 上午8:26写道: > > > > >

Re: [ANNOUNCE] New committer: Vineet Garg

2020-04-25 Thread Feng Zhu
Congratulations, well deserved! best, Feng Chunwei Lei 于2020年4月26日周日 上午10:12写道: > Congrats, Vineet! > > > Best, > Chunwei > > > On Sun, Apr 26, 2020 at 8:24 AM Haisheng Yuan wrote: > > > Congrats, Vineet! > > > > On 2020/04/25 22:18:35, Forward Xu wrote: > > > Congratulations > > > > > >

Re: How to get the used columns (categorized by tables) from a SQL

2020-04-16 Thread Feng Zhu
You can customize a RelVisitor to visit the RelNode, and collect the columns from TableScan's rowtype. 王驰 于2020年4月16日周四 下午11:23写道: > Hi folks, > > > We're using CalCite in our project for SQL parsing and validating. We have > a question: is there any way to get all used columns from a SQL? > >

[jira] [Created] (CALCITE-3930) When converting Aggregate to SQL, add Having clause if a group key is not in group sets

2020-04-15 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3930: - Summary: When converting Aggregate to SQL, add Having clause if a group key is not in group sets Key: CALCITE-3930 URL: https://issues.apache.org/jira/browse/CALCITE-3930

[jira] [Created] (CALCITE-3895) When the group sets of Aggregate is not null, union of its members should contain group key

2020-04-03 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3895: - Summary: When the group sets of Aggregate is not null, union of its members should contain group key Key: CALCITE-3895 URL: https://issues.apache.org/jira/browse/CALCITE-3895

Re: [VOTE] Release apache-calcite-1.22.0 (release candidate 3)

2020-03-03 Thread Feng Zhu
Hi Danny, thanks for your continuous effort! +1 (non-binding) - Build and Test (./gradlew build) - OK - Checked Release Notes - OK - Checked README - OK - Validate gpg signature - OK Environment 1: Windows 7, JDK 1.8.0_121 Environment 2: Mac OS X 10.15.1, JDK 1.8.0_231_b11 Bests, Feng Danny

Re: [ANNOUNCE] New committer: Feng Zhu

2020-03-01 Thread Feng Zhu
> > > > > > > > -Rui > > > > On Sat, Feb 29, 2020 at 2:10 AM Feng Zhu wrote: > > > >> Thank you everyone for your warm welcome! > >> Currently I am working at SuperSQL team of Tencent in Shenzhen, > Guangdong, > >> China. >

Re: [ANNOUNCE] New committer: Feng Zhu

2020-02-29 Thread Feng Zhu
t; > > Francis Chuang 于2020年2月29日 周六下午4:35写道: > > > > > Congrats, well-deserved! > > > > > > On 29/02/2020 6:26 pm, Stamatis Zampetakis wrote: > > > > Apache Calcite's Project Management Committee (PMC) has invited Feng > > > > Zhu to

Re: How to add a UDF with variable number parameter in calcite?

2020-02-10 Thread Feng Zhu
Vargs UDF is not supported in Calcite now. There are some discussions[1] and on-going work[2] for it. [1] https://issues.apache.org/jira/browse/CALCITE-2772 [2] https://github.com/apache/calcite/pull/1405] 月宫的木马兔 于2020年2月11日周二 上午10:20写道: > hi experts, > I'm using Apache Calcite to validate

Re: Query related to calcite custom function support

2020-01-15 Thread Feng Zhu
Hi Ashutosh, We have ever encountered a similar problem when we need to support 'fake' Hive functions in Calcite and push it down. Our approach is to use Object.class to define functions. e.g. public static class Dummy { public String trim(Object arg) { .. } } Best, Feng

[jira] [Created] (CALCITE-3739) Remove failed snapshot track file in Windows OS for Cassandra adapter

2020-01-14 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3739: - Summary: Remove failed snapshot track file in Windows OS for Cassandra adapter Key: CALCITE-3739 URL: https://issues.apache.org/jira/browse/CALCITE-3739 Project: Calcite

Re: Gradle documentation update

2020-01-07 Thread Feng Zhu
I also noticed the same problem several days ago when a colleague complained he failed to build Calcite according to the documents on website. E.g., https://calcite.apache.org/docs/howto.html#building-from-a-source-distribution *$ git clone git://github.com/apache/calcite.git

Re: Understanding the Window Enumerable Process

2020-01-02 Thread Feng Zhu
te doesn't have a simple counter function > like Oracles rownum function does it? > > Thanks > Shawn > > On 1/1/20, 9:55 PM, "Feng Zhu" wrote: > > Hi, Shawn > > I was hoping someone could give me a high level overview of how > Calcite

Re: Understanding the Window Enumerable Process

2020-01-01 Thread Feng Zhu
Hi, Shawn I was hoping someone could give me a high level overview of how Calcite is > executing the window function. > Calcite runtime generates Java code and complies the code with Janino. For Window Enumerable Process, there is a sample piece of code in

[DISCUSSION] Wrong GROUP_ID function

2019-12-31 Thread Feng Zhu
Recently, we encounter a problem caused by some inconsistency query results. After some investigations, I find the GROUP_ID()'s implementation in Calcite is wrong [1]. However, if we want to fix it, another field is required to be added into *Aggregate*, bringing huge impacts on almost every

Re: A linq4j question

2019-12-30 Thread Feng Zhu
unctions.class, "myFunc2", expr)); > } > > return ret; > > > > As you can see, I know "myFunc" returns a list, so I want to make each > element of that list an expression so I can continue manipulating them. > Eventually they will be used to generat

Re: A linq4j question

2019-12-30 Thread Feng Zhu
> > Basically I know the function return a list so I want to access each > element of it. Ideally I can get a List ret = > Expressions.call(FindMethod("myFunc")) > Can you elaborate on what do you want? i.e., *List ret* If you want to get the element of a method call result, you can evaluate the

Re: Re: [DISCUSS] CALCITE-2450 reorder predicates to a canonical form

2019-12-30 Thread Feng Zhu
I personally agree with Haisheng Yuan and Rui Wang. Expression normalization is a common technique in many database products and benefits to query optimizer. We should not stop the efforts in this direction. But in current calcite code base, even mininal changes in plan may bring great impacts,

[jira] [Created] (CALCITE-3627) Incorrect null semantic for ROW function

2019-12-24 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3627: - Summary: Incorrect null semantic for ROW function Key: CALCITE-3627 URL: https://issues.apache.org/jira/browse/CALCITE-3627 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3604) Test failed caused by localized exception message

2019-12-16 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3604: - Summary: Test failed caused by localized exception message Key: CALCITE-3604 URL: https://issues.apache.org/jira/browse/CALCITE-3604 Project: Calcite Issue Type

Re: [DISCUSS] Tests vs multiline strings

2019-12-15 Thread Feng Zhu
" It is pretty good as a pure Java project" +1 for Danny's comment. Introducing another language (without strong demands) brings burden for project maintenance and evolution. Best, Feng Danny Chan 于2019年12月16日周一 上午11:34写道: > I also have the same concern with Julian, in Apache Flink SQL, we did

[jira] [Created] (CALCITE-3565) Explicitly cast assignable operand types to decimal for udf

2019-12-04 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3565: - Summary: Explicitly cast assignable operand types to decimal for udf Key: CALCITE-3565 URL: https://issues.apache.org/jira/browse/CALCITE-3565 Project: Calcite

[jira] [Created] (CALCITE-3564) Make operand type check accurate for some functions in validation phase

2019-12-04 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3564: - Summary: Make operand type check accurate for some functions in validation phase Key: CALCITE-3564 URL: https://issues.apache.org/jira/browse/CALCITE-3564 Project: Calcite

[jira] [Created] (CALCITE-3563) Convert function operand type to match implementation if necessary in runtime

2019-12-04 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3563: - Summary: Convert function operand type to match implementation if necessary in runtime Key: CALCITE-3563 URL: https://issues.apache.org/jira/browse/CALCITE-3563 Project

[jira] [Created] (CALCITE-3562) Unify function's operands type check logic in validation and behavior in runtime

2019-12-03 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3562: - Summary: Unify function's operands type check logic in validation and behavior in runtime Key: CALCITE-3562 URL: https://issues.apache.org/jira/browse/CALCITE-3562 Project

[jira] [Created] (CALCITE-3520) Type cast from primitive to box is not correct

2019-11-18 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3520: - Summary: Type cast from primitive to box is not correct Key: CALCITE-3520 URL: https://issues.apache.org/jira/browse/CALCITE-3520 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3515) Extra files and directory generated

2019-11-18 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3515: - Summary: Extra files and directory generated Key: CALCITE-3515 URL: https://issues.apache.org/jira/browse/CALCITE-3515 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3514) LatticeTest fails when JdbcSchema re-computes JdbcTables

2019-11-18 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3514: - Summary: LatticeTest fails when JdbcSchema re-computes JdbcTables Key: CALCITE-3514 URL: https://issues.apache.org/jira/browse/CALCITE-3514 Project: Calcite Issue

[jira] [Created] (CALCITE-3513) Unify TableFunction implementor's NullPolicy and its beheavior

2019-11-18 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3513: - Summary: Unify TableFunction implementor's NullPolicy and its beheavior Key: CALCITE-3513 URL: https://issues.apache.org/jira/browse/CALCITE-3513 Project: Calcite

[jira] [Created] (CALCITE-3512) Support type cast from Time/TimeStamp to Integer/Long

2019-11-18 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3512: - Summary: Support type cast from Time/TimeStamp to Integer/Long Key: CALCITE-3512 URL: https://issues.apache.org/jira/browse/CALCITE-3512 Project: Calcite Issue

[jira] [Created] (CALCITE-3498) Unnest operation's ordinality should be deterministic

2019-11-13 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3498: - Summary: Unnest operation's ordinality should be deterministic Key: CALCITE-3498 URL: https://issues.apache.org/jira/browse/CALCITE-3498 Project: Calcite Issue

Re: [ANNOUNCE] Haisheng Yuan joins Calcite PMC

2019-11-10 Thread Feng Zhu
Congratulation! Leonard Xu 于2019年11月11日周一 下午2:10写道: > Congratulations! HaiSheng > > Best, > Leonard Xu > > On 2019年11月11日, at 下午1:22, Danny Chan wrote: > > > > Congratulations HaiSheng! > >

Re: [ANNOUNCE] Danny Chan joins Calcite PMC

2019-10-30 Thread Feng Zhu
Congratulations ! Danny, thanks for your work! XING JIN 于2019年10月31日周四 上午10:03写道: > Congratulations ! Danny ~ > > OpenInx 于2019年10月31日周四 上午9:33写道: > > > Congrats, Danny! Well deserve. > > > > On Thu, Oct 31, 2019 at 9:22 AM Leonard Xu wrote: > > > > > Congratulation! Danny > > > > > > > > >

Re: [DISCUSSION] Cache Optimization in JdbcSchema

2019-10-29 Thread Feng Zhu
2019年10月29日 +0800 AM10:36,Feng Zhu ,写道: > > Hi all, > > We made some optimizations in practice. But I'm not sure whether this > kind > > of change is necessary to the community, because it will make the code > > complex. > > > > Current now, JdbcSchema c

[DISCUSSION] Cache Optimization in JdbcSchema

2019-10-28 Thread Feng Zhu
Hi all, We made some optimizations in practice. But I'm not sure whether this kind of change is necessary to the community, because it will make the code complex. Current now, JdbcSchema caches all JdbcTables in tableMap (i.e.,* ImmutableMap tableMap*) In our production environment, there are

[jira] [Created] (CALCITE-3414) Unify Expression'type cast and conversion as a robust one

2019-10-15 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3414: - Summary: Unify Expression'type cast and conversion as a robust one Key: CALCITE-3414 URL: https://issues.apache.org/jira/browse/CALCITE-3414 Project: Calcite

[jira] [Created] (CALCITE-3411) Incorrect code generated for BigDecimal ConstantExpression

2019-10-14 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3411: - Summary: Incorrect code generated for BigDecimal ConstantExpression Key: CALCITE-3411 URL: https://issues.apache.org/jira/browse/CALCITE-3411 Project: Calcite

Re: Trivial query simplification

2019-09-24 Thread Feng Zhu
Hi, Enrico, I'm a little confused about your expectations. Could you clarify it? Moreover, is it right for the below simplification (do you mean v is not null)? (v=1 and v is null) -> v=1 (do you mean v is not null?) Best regards Enrico Olivelli 于2019年9月24日周二 下午5:41写道: > Hi, > I have a query

Re: Is it possible that unquoted identifiers are not implicitly converted to upper case

2019-09-12 Thread Feng Zhu
ection(CONNECTION_URL, > properties); > > Statement statement = connection.createStatement()) { > > // do some things > > } > > > > > Thanks again for your kindness, and waiting for u. :) > > > > > Regards, > > Trista > > > > > &g

Re: Is it possible that unquoted identifiers are not implicitly converted to upper case

2019-09-11 Thread Feng Zhu
Hi, JuanPan, You can refer to Lex, which decides how identifiers are quoted, whether they are converted to upper-case org.apache.calcite.config.Lex Regards Juan Pan 于2019年9月11日周三 下午8:05写道: > > > Hi, all the committers and contributors, > > > This email is for your help. > > > I am now deep in

[jira] [Created] (CALCITE-3332) Query failed with AssertionError: cannot cast null as class java.math.BigDecimal

2019-09-09 Thread Feng Zhu (Jira)
Feng Zhu created CALCITE-3332: - Summary: Query failed with AssertionError: cannot cast null as class java.math.BigDecimal Key: CALCITE-3332 URL: https://issues.apache.org/jira/browse/CALCITE-3332 Project

Re: Using Spark 2.4.0 as Execution Engine with Apache Calcite

2019-08-28 Thread Feng Zhu
Hi,Sgybham, According to our study, it is developed for Spark 1.x and not powerful in production. Rather than relying on Spark adapter, I suggest you convert RelNode back to SQL based on SparkSqlDialect, and then execute them by Spark SQL. Shubham Kumar 于2019年8月29日周四 上午1:26写道: > Hey, > > Does

[jira] [Created] (CALCITE-3236) Handle issues found in static code analysis

2019-08-07 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3236: - Summary: Handle issues found in static code analysis Key: CALCITE-3236 URL: https://issues.apache.org/jira/browse/CALCITE-3236 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3224) New RexNode-to-Expression CodeGen Implementation

2019-08-01 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3224: - Summary: New RexNode-to-Expression CodeGen Implementation Key: CALCITE-3224 URL: https://issues.apache.org/jira/browse/CALCITE-3224 Project: Calcite Issue Type

[jira] [Created] (CALCITE-3173) RexNode Code Generation Problem

2019-07-05 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3173: - Summary: RexNode Code Generation Problem Key: CALCITE-3173 URL: https://issues.apache.org/jira/browse/CALCITE-3173 Project: Calcite Issue Type: Improvement

[jira] [Created] (CALCITE-3113) Equivalent MutableAggregates with different row types fail with AssertionError

2019-06-06 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3113: - Summary: Equivalent MutableAggregates with different row types fail with AssertionError Key: CALCITE-3113 URL: https://issues.apache.org/jira/browse/CALCITE-3113 Project

[jira] [Created] (CALCITE-3112) Support Window in RelToSqlConverter

2019-06-05 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3112: - Summary: Support Window in RelToSqlConverter Key: CALCITE-3112 URL: https://issues.apache.org/jira/browse/CALCITE-3112 Project: Calcite Issue Type: Improvement

[jira] [Created] (CALCITE-3088) Multi-groupsets query failed due to datype preservation check

2019-05-23 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3088: - Summary: Multi-groupsets query failed due to datype preservation check Key: CALCITE-3088 URL: https://issues.apache.org/jira/browse/CALCITE-3088 Project: Calcite

[jira] [Created] (CALCITE-3081) Literal NULL should be generated in SqlDialect

2019-05-21 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3081: - Summary: Literal NULL should be generated in SqlDialect Key: CALCITE-3081 URL: https://issues.apache.org/jira/browse/CALCITE-3081 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3079) Successive dependent windows cannot be implemented in same expression level

2019-05-20 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3079: - Summary: Successive dependent windows cannot be implemented in same expression level Key: CALCITE-3079 URL: https://issues.apache.org/jira/browse/CALCITE-3079 Project

[jira] [Created] (CALCITE-3077) Rewrite CUBE queries in SparkSqlDialect

2019-05-17 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3077: - Summary: Rewrite CUBE queries in SparkSqlDialect Key: CALCITE-3077 URL: https://issues.apache.org/jira/browse/CALCITE-3077 Project: Calcite Issue Type: Bug

[jira] [Created] (CALCITE-3072) Generate right SQL for FLOOR functions in SparkSqlDialect

2019-05-15 Thread Feng Zhu (JIRA)
Feng Zhu created CALCITE-3072: - Summary: Generate right SQL for FLOOR functions in SparkSqlDialect Key: CALCITE-3072 URL: https://issues.apache.org/jira/browse/CALCITE-3072 Project: Calcite