Re: Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

Hi Calcite team, Gently reminder about review / merge the patch for  CALCITE-4818 [1] [1]. https://issues.apache.org/jira/browse/CALCITE-4818 On 15.10.2021 15:16, Taras Ledkov wrote: Hi, Gently reminder about review. On 04.10.2021 20:30, Taras Ledkov wrote: Hi, Please review the patch

Re: Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

Hi, Gently reminder about review. On 04.10.2021 20:30, Taras Ledkov wrote: Hi, Please review the patch for the issue CALCITE-4818 [1], see PR#2560 [2]. Looks like the rule 'AggregateExpandDistinctAggregatesRule' contains another bug with inferring result type of the top aggregate calls

Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

le fix: pass 'null' type to the 'AggregateCall.create' call to infer aggregate type from the input. [1]. https://issues.apache.org/jira/browse/CALCITE-4818 [2]. https://github.com/apache/calcite/pull/2560 -- Taras Ledkov Mail-To: tled...@gridgain.com

[jira] [Created] (CALCITE-4818) AggregateExpandDistinctAggregatesRule

Taras Ledkov created CALCITE-4818: - Summary: AggregateExpandDistinctAggregatesRule Key: CALCITE-4818 URL: https://issues.apache.org/jira/browse/CALCITE-4818 Project: Calcite Issue Type: Bug

Looking for a committer to merge: CALCITE-4652 (fix AggregateExpandDistinctAggregatesRule when SUM type is expanded)

Hi Calcite Devs. The patch for CALCITE-4652 [1] (see PR#2439 [2]) is reviewed and ready for merge. I'm looking for a committer to merge the patch. [1]. https://issues.apache.org/jira/browse/CALCITE-4652 [2]. https://github.com/apache/calcite/pull/2439 On 10.08.2021 15:10, Taras Ledkov wrote

Re: Review request: CALCITE-4652 (fix AggregateExpandDistinctAggregatesRule when SUM type is expanded)

]. https://github.com/apache/calcite/pull/2439 On 12.07.2021 15:05, xiong duan wrote: Hi. Ledkov. I'll do some code reviews in the next two days. Taras Ledkov 于2021年7月12日周一 下午7:58写道： Hi, Please review the patch for the issue CALCITE-4652 [1], see PR#2439 [2]. I tried to draw attention

Review request: CALCITE-4652 (fix AggregateExpandDistinctAggregatesRule when SUM type is expanded)

ive a link to the discussion. Stamatis advised me to send a reminder to the devlist. [1]. https://issues.apache.org/jira/browse/CALCITE-4652 [2]. https://github.com/apache/calcite/pull/2439 -- Taras Ledkov Mail-To: tled...@gridgain.com

Joining JIRA as a contributor

Hi, I'd like to join the JIRA contributor list. My Jira username is tledkov-gridgain I would work on the issue CALCITE-4652 (see [1]). [1]. https://issues.apache.org/jira/browse/CALCITE-4652 -- Taras Ledkov Mail-To: tled...@gridgain.com

Re: [HELP] Return type of the SUM aggregate function and AggregateExpandDistinctAggregatesRule

Hi, I've filed the issue CALCITE-4652 (see [1]). Please take a look at the suggested fix [2]. [1]. https://issues.apache.org/jira/browse/CALCITE-4652 [2]. https://github.com/apache/calcite/pull/2439 On 04.06.2021 18:46, Taras Ledkov wrote: Hi, I try to expand return type of the SUM aggregate

[jira] [Created] (CALCITE-4652) AggregateExpandDistinctAggregatesRule must cast top aggregates to original type

Taras Ledkov created CALCITE-4652: - Summary: AggregateExpandDistinctAggregatesRule must cast top aggregates to original type Key: CALCITE-4652 URL: https://issues.apache.org/jira/browse/CALCITE-4652

[HELP] Return type of the SUM aggregate function and AggregateExpandDistinctAggregatesRule

is the best way to fix: add projection with cast results of the `$SUM0` to BIGINT or something else? 3. If 1 - NO, then what is the best way  to expand SUM return type? [1]. https://github.com/apache/calcite/pull/2427/files -- Taras Ledkov Mail-To: tled...@gridgain.com

Question: Hints & Rules

.: - AggregateExpandDistinctAggregatesRule - copy hints of the source node for new aggregate nodes. - AggregateReduceFunctionsRule - create new node and looses the original hints. Is is correct behavior and am I missing something at the hints/planner logic? -- Taras Ledkov Mail-To: tled

Re: How to extend SQL type system?

r 27, 2021, at 7:04 AM, JiaTao Tao wrote: I think the only way is to add your type to SqlTypeName and override RelDataTypeSystem/RelDataTypeFactory if needed Regards! Aron Tao Taras Ledkov 于2021年4月27日周二 下午5:42写道： Hi all, I'm looking for the way to extend SQL types for my engine based on Ca

How to extend SQL type system?

, it is not structured types that are defined by SQL user, but engine-specific types: e.g.: blob, image, text, my_blob, my_uuid, json etc... -- Taras Ledkov Mail-To: tled...@gridgain.com