Re: [DISCUSS] Deprecate grouped window functions

2020-04-30 Thread Rui Wang
Polymorphic table function is logged at [1]. I assigned that to myself because I started to implement DESCRIPTOR (a part of PTF in SQL standard). It's very welcomed if anyone wants to help to accelerate the implementation. (But please use another thread to discuss it). Back to this thread's

Re: [DISCUSS] Deprecate grouped window functions

2020-04-30 Thread Julian Hyde
I understand that you need to continue to support the SQL syntax while your users still want it. I suggest that Calcite continues to support the SQL syntax in the parser (and the SqlNode AST) but deprecates and removes the support in the algebra (RelNode) within one or two releases (3 - 6

Re: [DISCUSS] Deprecate grouped window functions

2020-04-30 Thread Julian Hyde
> On Apr 30, 2020, at 8:16 AM, Viliam Durina wrote: > > What is the status of polymorphic table functions? We'd like to use them. Off topic. Can you start this discussion in a new thread? Julian

Re: [DISCUSS] Deprecate grouped window functions

2020-04-30 Thread Viliam Durina
What is the status of polymorphic table functions? We'd like to use them. Viliam On Thu, 30 Apr 2020 at 16:16, Timo Walther wrote: > Thanks for considering our needs. > > I'm pretty sure that windows are in almost every streaming pipeline with > aggregations. Unlike regular Java API, SQL

Re: [DISCUSS] Deprecate grouped window functions

2020-04-30 Thread Timo Walther
Thanks for considering our needs. I'm pretty sure that windows are in almost every streaming pipeline with aggregations. Unlike regular Java API, SQL syntax is very difficult to deprecate. We usually give Flink user 1-2 releases time to update their code. Once Calcite supports polymorphic

Re: [DISCUSS] Deprecate grouped window functions

2020-04-28 Thread Rui Wang
Agreed. I would like to get more feedback to have a reasonable accommodation for users. -Rui On Mon, Apr 27, 2020 at 11:50 AM Julian Hyde wrote: > Changing my +1 to +0. We have to make reasonable accommodations for our > users. Glad we had this discussion. > > > On Apr 24, 2020, at 11:10 AM,

Re: [DISCUSS] Deprecate grouped window functions

2020-04-27 Thread Julian Hyde
Changing my +1 to +0. We have to make reasonable accommodations for our users. Glad we had this discussion. > On Apr 24, 2020, at 11:10 AM, Rui Wang wrote: > > Hi Timo, > > My intention is to fully drop concepts such as SqlGroupedWindowFunction and > auxiliary group functions, which include

Re: [DISCUSS] Deprecate grouped window functions

2020-04-24 Thread Rui Wang
Hi Timo, My intention is to fully drop concepts such as SqlGroupedWindowFunction and auxiliary group functions, which include relevant code in parser/syntax, operator, planner, etc. Since you mentioned the need for more time to migrate. How many Calcite releases that you think can probably leave

Re: [DISCUSS] Deprecate grouped window functions

2020-04-24 Thread Timo Walther
Hi everyone, so far Apache Flink depends on this feature. We are fine with improving the SQL compliance and eventually dropping GROUP BY TUMBLE/HOP/SESSION in the future. However, we would like to give our users some time to migrate their existing pipelines. What does dropping mean for

Re: [DISCUSS] Deprecate grouped window functions

2020-04-24 Thread Julian Hyde
+1 Let’s remove TUMBLE etc from the GROUP BY clause. Since this is a SQL change, not an API change, I don’t we need to give notice. Let’s just do it. Julian > On Apr 22, 2020, at 4:05 PM, Rui Wang wrote: > > Made a mistake on the example above, and update it as follows: > > // Table

Re: [DISCUSS] Deprecate grouped window functions

2020-04-22 Thread Rui Wang
Made a mistake on the example above, and update it as follows: // Table function windowing syntax. SELECT product_id, count(*), window_start FROM TABLE(TUMBLE(order, DESCRIPTOR(rowtime), INTERVAL '1' hour)) GROUP BY product_id, window_start On Wed, Apr 22, 2020 at 2:31 PM Rui Wang

[DISCUSS] Deprecate grouped window functions

2020-04-22 Thread Rui Wang
Hi community, I want to kick off a discussion about deprecating grouped window functions (GROUP BY TUMBLE/HOP/SESSION) as the table function windowing support becomes a thing [1] (FROM TABLE(TUMBLE/HOP/SESSION)). The current stage of table function windowing is TUMBLE support is checked in. HOP