Re: [DISCUSS] Publish test JARS

2020-08-11 Thread Michael Mior
It will have to wait until the release is complete, but yes, I’d like to get this in. Thanks for the patch Vladimir! On Tue, Aug 11, 2020 at 04:38 Danny Chan wrote: > Michael, do you plan to push this function/patch ? We actually need this > too ~ > > Best, > Danny Chan > 在 2020年8月11日 +0800

Re: [DISCUSS] Publish test JARS

2020-08-11 Thread Danny Chan
Michael, do you plan to push this function/patch ? We actually need this too ~ Best, Danny Chan 在 2020年8月11日 +0800 AM3:06,Michael Mior ,写道: > Thanks for pointing back to the previous discussion. I'm fine with > publishing separate modules. No real preference on my end since I > haven't found

Re: [DISCUSS] Publish test JARS

2020-08-10 Thread Vladimir Sitnikov
Michael>I'm not sure what the changes to the Gradle config would look like to support this. Here you go: https://github.com/apache/calcite/pull/2104/files Then core/src/test should be able to see testkit classes, and testkit should see core classes. Vladimir

Re: [DISCUSS] Publish test JARS

2020-08-10 Thread Michael Mior
Thanks for pointing back to the previous discussion. I'm fine with publishing separate modules. No real preference on my end since I haven't found consuming test artifacts to cause any problems. Although I'm not sure what the changes to the Gradle config would look like to support this. --

Re: [DISCUSS] Publish test JARS

2020-08-10 Thread Vladimir Sitnikov
Hi Michael, I suggest we go with adding explicitly published modules rather than publishing tests. Test artifacts do not have their own pom.xml, so they are not really convenient for consumers. Here's the relevant thread:

[DISCUSS] Publish test JARS

2020-08-10 Thread Michael Mior
I know this discussion had come up before, but it seems on the release of 1.22.0 we decided to stop publishing test JARs. While these shouldn't be needed for normal operation, my project linked below happens to use several of them for demonstration purposes so currently I'm stuck on Calcite