Re: Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

2021-10-27 Thread Taras Ledkov
Hi Calcite team, Gently reminder about review / merge the patch for  CALCITE-4818 [1] [1]. https://issues.apache.org/jira/browse/CALCITE-4818 On 15.10.2021 15:16, Taras Ledkov wrote: Hi, Gently reminder about review. On 04.10.2021 20:30, Taras Ledkov wrote: Hi, Please review the patch for

Re: Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

2021-10-15 Thread Taras Ledkov
Hi, Gently reminder about review. On 04.10.2021 20:30, Taras Ledkov wrote: Hi, Please review the patch for the issue CALCITE-4818 [1], see PR#2560 [2]. Looks like the rule 'AggregateExpandDistinctAggregatesRule' contains another bug with inferring result type of the top aggregate calls.

Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

2021-10-04 Thread Taras Ledkov
Hi, Please review the patch for the issue CALCITE-4818 [1], see PR#2560 [2]. Looks like the rule 'AggregateExpandDistinctAggregatesRule' contains another bug with inferring result type of the top aggregate calls. e.g. If the type system expand sum type like postgress: SUM(TINYINT | SMALLINT