Bad array check in _users/_design/_auth

2010-11-06 Thread Gabriel Farrell
In trying to figure out how to test for an array value in validate_doc_update I ran across the following in _users/_design/_auth:    if (!(newDoc.roles (typeof newDoc.roles.length !== 'undefined'))) {      throw({forbidden: 'doc.roles must be an array'});    } Strings also have a length method,

Bad array check in _users/_design/_auth

2010-11-06 Thread Gabriel Farrell
In trying to figure out how to test for an array value in validate_doc_update I ran across the following in _users/_design/_auth: if (!(newDoc.roles (typeof newDoc.roles.length !== 'undefined'))) { throw({forbidden: 'doc.roles must be an array'}); } Strings also have a length

Re: Error when compiling on Debian testing

2010-11-08 Thread Gabriel Farrell
On Mon, Nov 8, 2010 at 11:24 AM, Jan Lehnardt j...@apache.org wrote: On 8 Nov 2010, at 17:13, Gabriel Farrell wrote: Attempts to compile from HEAD on Github (at commit e9bf7b33c7), following the DEVELOPERS doc, on my 64-bit Debian testing machine resulted in the following error

Re: use view functions to emit changes

2010-12-06 Thread Gabriel Farrell
On Tue, Nov 30, 2010 at 8:32 AM, Benoit Chesneau bchesn...@gmail.com wrote: On Tue, Nov 30, 2010 at 1:50 PM, Jan Lehnardt j...@apache.org wrote: On 30 Nov 2010, at 13:05, Benoit Chesneau wrote: About the 2 spaces in js, imo we should go to a 4 spaces indentations, which is a way more readable

Re: Source tree refactoring - TESTERS NEEDED

2010-12-08 Thread Gabriel Farrell
Tested on Maverick on a netbook (sorry, Ubuntu is all I got). JSpec tests wouldn't run (Chromium 8.0.552.215). When I go to http://127.0.0.1:5984/_utils/spec/run.html I get a blank screen that displays only JSpec 3.3.2. Futon test report at

Re: Source tree refactoring - TESTERS NEEDED

2010-12-09 Thread Gabriel Farrell
, Paul Davis paul.joseph.da...@gmail.com wrote: Gabriel, Thanks for the report. Does that attachments test fail on trunk or with FF? On Wed, Dec 8, 2010 at 5:28 PM, Gabriel Farrell gsf...@gmail.com wrote: Tested on Maverick on a netbook (sorry, Ubuntu is all I got). JSpec tests wouldn't run

Re: [VOTE] Apache CouchDB 1.0.2 Release, Round 2

2011-01-10 Thread Gabriel Farrell
For goodness' sake, release it already! ;) +1 On Mon, Jan 10, 2011 at 9:01 PM, Paul Davis paul.joseph.da...@gmail.com wrote: This is the second release vote for Apache CouchDB 1.0.2 Changes since the last round:  * Fix share/www/image/spinner.gif  * Fix OOM error when compacting documents

Re: Apache CouchDB 1.0.2 Release, Round 2

2011-01-12 Thread Gabriel Farrell
On Wed, Jan 12, 2011 at 9:40 AM, Filipe David Manana fdman...@apache.org wrote: On Wed, Jan 12, 2011 at 2:06 PM, Benoit Chesneau bchesn...@gmail.com wrote: Vote was stopped yesterday, in any serious businness, we would wait a little. Apache CouchDB is not a business, it's an open source and

Re: roadmap

2011-02-10 Thread Gabriel Farrell
On Tue, Feb 8, 2011 at 11:37 AM, Robert Newson robert.new...@gmail.com wrote: You're absolutely right. 1.0.2 was ready to go quite some time ago but several bugs were found as we were releasing. We decided, as a team, that we couldn't ship with the bugs that were found, so we elected to fix

Re: roadmap

2011-02-11 Thread Gabriel Farrell
On Thu, Feb 10, 2011 at 11:44 AM, Jan Lehnardt j...@apache.org wrote: On 10 Feb 2011, at 17:29, Gabriel Farrell wrote: On Tue, Feb 8, 2011 at 11:37 AM, Robert Newson robert.new...@gmail.com wrote: You're absolutely right. 1.0.2 was ready to go quite some time ago but several bugs were

Re: Spaces in View Names

2011-02-14 Thread Gabriel Farrell
If there's a use case for including spaces in view names (I haven't thought of one yet) we could meet that while avoiding whitespace-only names and other tricky issues by trimming leading and trailing spaces before creation. On Mon, Feb 14, 2011 at 11:10 AM, Jan Lehnardt j...@apache.org wrote:

Re: Spaces in View Names

2011-02-17 Thread Gabriel Farrell
On Tue, Feb 15, 2011 at 4:22 PM, Benjamin Young benja...@couchone.com wrote: On 2/14/11 11:50 AM, Gabriel Farrell wrote: If there's a use case for including spaces in view names (I haven't thought of one yet) we could meet that while avoiding whitespace-only names and other tricky issues

[jira] [Commented] (COUCHDB-1017) HTTP Rewrite Handler: Rewriting strings in queries

2011-06-21 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13052560#comment-13052560 ] Gabriel Farrell commented on COUCHDB-1017: -- Benoit, works for me. Which commit

[jira] Created: (COUCHDB-944) validate_doc_update ignored after compact

2010-11-10 Thread Gabriel Farrell (JIRA)
Environment: Debian testing 64-bit, Ubuntu 10.10 32-bit Reporter: Gabriel Farrell After compacting a db its validate_doc_update is ignored until the next couch restart. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.

[jira] Created: (COUCHDB-948) Breadcrumb doesn't need to be URI encoded

2010-11-14 Thread Gabriel Farrell (JIRA)
: 1.1 Reporter: Gabriel Farrell Priority: Trivial Introduced by github commit 871e2617 on 2010-11-02. When I go to the design doc foo for db bob, breadcrumbs/nav shows Overview bob _design%2Ffoo when it should be Overview bob _design/foo. -- This message

[jira] Updated: (COUCHDB-948) Breadcrumb doesn't need to be URI encoded

2010-11-14 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Farrell updated COUCHDB-948: Attachment: noEncode.diff Patch as git diff output. Breadcrumb doesn't need to be URI

[jira] Reopened: (COUCHDB-948) Breadcrumb doesn't need to be URI encoded

2010-11-15 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Farrell reopened COUCHDB-948: - The change committed addresses the particular case of forward slashes in doc IDs

[jira] Updated: (COUCHDB-948) Breadcrumb doesn't need to be URI encoded

2010-11-17 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Farrell updated COUCHDB-948: Attachment: noUriEncode.diff Okay, I won't open this issue again, but I really disagree

[jira] Commented: (COUCHDB-955) Slightly more verbose bootstrap

2010-11-18 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12933613#action_12933613 ] Gabriel Farrell commented on COUCHDB-955: - Makes sense. No need for messages

[jira] Updated: (COUCHDB-790) validate_doc_update on the _users database fails

2010-11-19 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Farrell updated COUCHDB-790: Attachment: usersTest.diff Attached patch adds tests for user type an roles array

[jira] Updated: (COUCHDB-790) validate_doc_update on the _users database fails

2010-11-20 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabriel Farrell updated COUCHDB-790: Attachment: users-test2.diff Attached users-test2.diff patch uses isArray function

[jira] Commented: (COUCHDB-790) validate_doc_update on the _users database fails

2010-11-22 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12934601#action_12934601 ] Gabriel Farrell commented on COUCHDB-790: - All looks great. I hadn't seen

[jira] Commented: (COUCHDB-972) Unauthorized requests with(out) Accept: */* get different status codes

2010-12-01 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12965769#action_12965769 ] Gabriel Farrell commented on COUCHDB-972: - I vote for the third option. A straight

[jira] Commented: (COUCHDB-972) Unauthorized requests with(out) Accept: */* get different status codes

2010-12-08 Thread Gabriel Farrell (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12969489#action_12969489 ] Gabriel Farrell commented on COUCHDB-972: - As for linking to the thread, I prefer