Re: Proposal -- Apache Dubbo GSoC2022 Proxyless Mesh support

2022-05-10 Thread Justin Mclean
Hi, The mailing list most likely dropped the attachment. Kind Regards, Justin

Re: [VOTE] Release Apache dubbo-go-pixiu v0.4.0-rc1

2021-10-24 Thread Justin Mclean
Hi, -1 from me as source releases cannot contain compiled code like jar files [1] Kind Regards, Justin 1. ./pkg/adapter/dubboregistry/remoting/zookeeper/zookeeper-4unittest/contrib/fatjar/zookeeper-3.4.9-fatjar.jar

Re: [VOTE]: Release Apache dubbo-js v4.0.1

2021-08-10 Thread Justin Mclean
Hi, Sorry it’s -1 (binding) from me. I think you might want to repackage the release as it unpacks to "Users/hufeng/Desktop/“ I checked: - signature and hashes are fine - LICENSE is missing some information or some files have the wrong headers - NOTICE is a little ahead of itself (2022!) - A

Re: [VOTE]: Release Apache dubbo-js v4.0.0

2021-07-06 Thread Justin Mclean
Hi, > There’s no signature file under this directory. But that curl be easily fixed and the voting continue. Kind Regards, Justin

Re: [VOTE] Release Apache Dubbo 2.7.11 RC1

2021-05-10 Thread Justin Mclean
Hi, > I added the protobuf info in the NOTICE file several versions ago when adding > gRPC support. I remember it clearly says in some place that a declaration > must be included in a project's NOTICE file if there’s abt reference of the > source code. I will check the protobuf codes later for

Re: [VOTE] Release Apache Dubbo 2.7.11 RC1

2021-05-09 Thread Justin Mclean
Hi, +1 binding but there a couple of minor license and notice issues that need to be corrected. I checked: - signatures and hashes are fine - LICENSE should also list InternalThreadLocal.java - NOTICE doesn’t need to list information about protobuf as the project doesn’t have a NOTICE file - A

Re: [VOTE] Release Apache Dubbo API Docs 2.7.8.3 RC2

2021-05-05 Thread Justin Mclean
HI, > I'm very sorry, "Hash for the release tag" is wrong. I announce to withdraw > this vote. Later, I will amend the "release tag" and launch RC3 vote For a minor issue like that I would just correct it and continue voting as it has no impact on the release artefact. Kind Regards, Justin

Re: [VOTE] Release Apache Dubbo API Docs 2.7.8.3 RC1

2021-04-28 Thread Justin Mclean
Hi, The release to be voted on needs to be put here [1] along with teh KEYS file and signature files. Justin 1. https://dist.apache.org/repos/dist/dev/dubbo/

Re: [Suggest] Dubbo issues problem

2021-01-29 Thread Justin Mclean
HI, > - We can introduce a bot to automatically close these issues and pull > requests if the original author does not reply for a long time. I suggest you don’t this this as it discourages people from contributing and you more more committers and grow the community so you have more people who

Re: [Brand issue] microservices summit link in website

2020-08-26 Thread Justin Mclean
Hi, > I read this page before, still, I don’t see why this volatiles the Apache > rule. I think Apache Dubbo can attend this conference and is free to put it > in the homepage or in a blog hosted by the website. It’s an open summit with > some open topics. This has been discussed a few times

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.9 RC1

2020-07-24 Thread Justin Mclean
Hi, The vote has been miscounted here. Justin

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-22 Thread Justin Mclean
Hi, That all look fine but don’t forget about the IP clearance form .http://incubator.apache.org/ip-clearance/ip-clearance-template.html This need to be completed before any code from this SGA is released. This may also

Re: [VOTE] Release Apache Dubbo 2.7.8 RC1

2020-07-22 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are good - LICENSE and NOTICE correct - No unexpected binary files in release - All ASF files have correct headers - Can compile from source Thanks, Justin

Re: [VOTE]: Release Apache dubbo-go v1.5.0 RC1

2020-07-22 Thread Justin Mclean
Hi, +1 (binding) I checked: - signature and hashes are fine - LICENSE and NOTIE are good - All ASF file have corrected headers - No unexpected binaries - can compute from source I did have some test time out but that be my setup/config. Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.9 RC1

2020-07-22 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are fine - LICENSE and NOTICE good - ASF files have correct headers - No unexpected binary files - Can compile from source Thanks, Justin

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-21 Thread Justin Mclean
Hi, > all contributors as follows except [JerryZhou343]( > https://github.com/JerryZhou343) has signed the ICLA. That seems fine. It would be best to list their names as the ICLA don’t list GitHub accounts. > I can not contact with JerryZhou343 who just has one commit >

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-21 Thread Justin Mclean
Hi, Before it can be accepted it needs to pass IP clearance as described here [1] Thanks, Justin 1.http://incubator.apache.org/ip-clearance/ip-clearance-template.html

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-21 Thread Justin Mclean
Hi, Has twas the grant handled? I don’t see it listed here. [1] Do we have signed ICLA’s for all contribitors? Thanks, Justin 1. https://incubator.apache.org/ip-clearance/

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-13 Thread Justin Mclean
Hi, A software grant is required in this case please see [1]. Thanks, Justin 1. https://www.apache.org/licenses/contributor-agreements.html#grants

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-12 Thread Justin Mclean
HI, For any contribution of significant size a SGA is required and IP clearance undertaken. If it this repo [1] then an individual does not own copyright of all of the code. Each contributor or their employer owns copyright in their own contributions unless they have stated otherwise. If their

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-12 Thread Justin Mclean
Hi, And I see a few other contributors [1] How has the IP of their contribution been handled? Thanks, Justin 1. https://github.com/dubbogo/getty/graphs/contributors

Re: [VOTE]: Accept dubbogo/getty donation

2020-07-12 Thread Justin Mclean
HI, I assume this will be donated as a software grant? Thanks, Justin

Re: 4.26会议纪要

2020-04-26 Thread Justin Mclean
Hi, I would also suggest bring back a summary of what was discussed to this list. Thanks, justin

Re: [VOTE] Release Apache dubbo-go v1.4.0 RC2

2020-04-17 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes correct - LICENSE and NOTICE good - No unexpected binary files - All source file have ASF headers - Couldn’t compile from source but probably my setup Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC3

2020-03-30 Thread Justin Mclean
Hi, > However I think think this is a blocking issue for this release, just that it > should be fixed for future releases. Sorry to be clear I meant to say “this is NOT a blocking issue”. Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC3

2020-03-30 Thread Justin Mclean
Hi, Thanks for the history. > Or it should be (this is it’s first release after donated to Apache as a > separate artifact): >> Copyright 2020-2020 The Apache Software Foundation Copyright is based on publication dates so I would just go with: Copyright 2020 The Apache Software Foundation

Re: [VOTE] Release Apache dubbo-go-hessian2 v1.5.0 RC1

2020-03-29 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are fine - LICENSE is missing the appendix. Please fix this. - NOTICE is fine - No unexpected binary files - All source file have ASF headers - can compile from source Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC3

2020-03-29 Thread Justin Mclean
Hi, > Copyright 2018-2020 The Apache Software Foundation Why 2018? When was the first release of Apache Dubbo-Hessian-Lite? Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC2

2020-03-28 Thread Justin Mclean
HI, > I know that the NOTICE file is still missing. Actually, I added NOTICE file > to the project before packaging, The NOTICE file is required for all ASF releases. [1] > but after I did that I found that the > NOTICE file doesn't have anything to mention but the following lines: > > Apache

Re: [VOTE] Release Apache Dubbo 2.7.6 RC3

2020-03-27 Thread Justin Mclean
Hi, +1 (binding) I checked: - Signatures and hashes are fine - LICENSE and NOTICE correct - No unexpected binary files - All ASF file have correct headers - Can compile from source Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC2

2020-03-27 Thread Justin Mclean
Hi, -1 (binding) The NOTICE file is still missing, everything else looks good. Thanks, Justin

Re: [VOTE] Release Apache Dubbo 2.7.6 RC2

2020-03-23 Thread Justin Mclean
Hi, > Very good question, we are trying to contact the original author for the > same question. It may be they come some other company repo going by headers here [1] but I cannot find the exact file, perhaps it’s an internal repo? It odd these files have that header. Thanks, Justin 1.

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-23 Thread Justin Mclean
Hi, > If it is legally fine (I think it is perfectly allowed) That is not the case at the ASF, we also have ASF policy and the Apache Way which override and go beyond what is just legal. This situation in unfortunate but continue the best you can. > What we could change in the future is > we

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-23 Thread Justin Mclean
Hi, > Unless we know where that other file come from [1] I would still be -1. Looks fine for that file. What about the other 3rd party files/files without headers?I think someone needs to go through the files and check that all files have the correct headers. Thanks, Justin

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-22 Thread Justin Mclean
Hi, > From what I can see now, we need an NOTICE file, inside which we should > mention the codes copy of of the Caucho Hessian Project. The NOTICE file doesn’t need to mention that unless headers have been removed from any files that come from Caucho Hessian, for that to happen we would need

Re: [RESULT] [VOTE]: Release Apache dubbo-go v1.4.0 RC1

2020-03-22 Thread Justin Mclean
Hi, > We’ve received one -1 binding vote from Justin Mclean for there's some > license issue. To be clear a -1 is not a veto, for releases you need 3 +1s and more +1s than -1s. The release manages however can cancel the vote if they think a -1 has merit and a new release needed.

Re: [VOTE] Release Apache dubbo-go v1.4.0 RC1

2020-03-20 Thread Justin Mclean
Hi, Having a release checklist usually helps [1] and does running Apache Rat [2] on the release artefact. Thanks, Justin 1. https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist 2. https://creadur.apache.org/rat/

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-20 Thread Justin Mclean
Hi, > hessian-lite is an tailored copy from Caucho's Hessian library. I don't > believe a software grant is necessary since it is licensed under ASF 1.1. I > believe we have the right to modify and contribute freely as long as we > mention it in the LICENSE file Legally that fine yes no issues

Re: [VOTE] Release Apache Dubbo 2.7.6 RC2

2020-03-20 Thread Justin Mclean
Hi, > It does have the different license header than others, but I think it is > fine. Pls. let me know if it is a show stopper for the current release. See ASF header policy [1] ("note that there should be no copyright notice in the header") and policy on 3rd party files [2]. > These files

Re: [VOTE] Release Apache Dubbo 2.7.6 RC2

2020-03-19 Thread Justin Mclean
Hi, -1 (binding) as code has incorrect headers I checked: - signatures and hashes fine - LICENSE and NOTICE are file - No unexpected binary files - Looks like these files [1][2][3] have incorrect header or may not be ASF files, and may need to be mentioned in LICENSE. Where did they come from?

Re: [VOTE] Release Apache Dubbo-Hessian-Lite 3.2.7 RC1

2020-03-19 Thread Justin Mclean
Hi, -1 (binding) as the release is missing a NOTICE file and files missing ASF headers I checked: - signature and hashes are fine - LICENSE exists - NOTICE is missing - no unexpected binary files - some files are ASF headers or unknown licensed 3rd party code e.g. [1] (I just check a couple of

Re: [VOTE] Release Apache dubbo-go v1.4.0 RC1

2020-03-19 Thread Justin Mclean
Hi, Sorry but it’s -1 binding form me as there are files missing ASF headers or 3rd party code of unknown licensing in the release I checked: - signatures and hashes are fine - LICENSE and NOTICE are fine - no unexpected bins art files - source files are missing ASF headers [1][2][3][4] - can

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC2

2020-02-11 Thread Justin Mclean
Hi, +1 binding but there a minor issue mentioned before that was not fixed. I checked: - signatures and hashes are OK - The LICENSE imisisng mention of [1] - NOTICE is correct - all source files have ASF headers (except [1]) - no unexpected binary files - Again didn’t compile from source. The

Re: [VOTE]: Release Apache dubbo-go v1.3.0 RC1

2020-01-21 Thread Justin Mclean
Hi, +1 binding but there a couple of minor issue that need to be fixed before next release I checked: - signatures and hashes are OK - The LICENSE is missing the appendix and one copyright owner - the year in NOTICE is incorrect - all source files have ASF headers - no unexpected binary files -

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc6

2020-01-14 Thread Justin Mclean
Hi, > We need an npm account, Does Apache have an official npm account? I’m not actually sure, something was being worked on bu I don’t think it’s official yet. If you don’t find anything I’d follow the advice here [1] Thanks, Justin 1.

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc6

2020-01-14 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are fine - LICENSE is fine - NOTICE all good - No unexpected binary files - All files have ASF headers - Can compile from source There is however another possible more serious issue in that this package may have A GPL dependancy, after

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc5

2020-01-10 Thread Justin Mclean
Hi, The NOTICE is still incorrect as it contains the text: "Apache Dubbo Js Submodules: Apache Dubbo Js includes a number of submodules with separate copyright notices and license terms. Your use of these submodules is subject to the terms and conditions of the following licenses.” Is

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc4

2020-01-07 Thread Justin Mclean
Hi, > what is apache wide code_of_conduct? Where can i find?please help me It can be found here [1] Thanks, Justin 1. https://www.apache.org/foundation/policies/conduct

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc4

2020-01-07 Thread Justin Mclean
Hi, -1 (binding) Why was the license and notice changed from the last RC? I checked: - LICENSE include dependancies rather than bundled software. Only things included in the release need to be mentioned in LICENSE. - If those MIT likened bit of code were included then you would need to include

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.5 [RC1]

2020-01-02 Thread Justin Mclean
Hi, +1 but there’s an issue need to be fixed in the next release. All files are apache licensed so there no license issue per say. I checked: - signatures and hashes fine - LICENSE is missing one file [1] - NOTICE year need updating - This file seems to incorrectly have an ASF header [1] when

Re: [VOTE] Release Apache Dubbo 2.7.5 RC2

2019-12-23 Thread Justin Mclean
Hi, > The issues pointed by Justin and Yunkun during RC1 vote are not included. Why is that? Issues once know should be fixed in the next RC. Issues once know and not corrected warrant a -1 vote IMO. Your not an incubating project anymore but a top level one and need to follow ASF p[policy.

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-22 Thread Justin Mclean
Hi, Again I would strongly recommend that you not release this because of the 30MB of git internal files contained in the release. Thanks, Justin On Mon, 23 Dec 2019, 14:07 胡锋, wrote: > I took a moment to write a script to detect a license file for a nodejs > project > > Jun Liu

Re: [VOTE] Release Apache Dubbo 2.7.5 RC1

2019-12-19 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes fine - LICENSE and NOICE file - Files have ASF headers except a couple like [1] - No unexpected binary files - Can compile from source Thanks, Justin [1] ./compiler/src/main/resources/DubboGrpcStub.mustache

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-19 Thread Justin Mclean
Hi, This should probably be called rc3 and the previous release was rc2. Everything is OK ASF wise, but I I think you may wan to make this release again as the release incorrectly contains a “.git” folder including this 30MB file [3] I checked: - signature and hashed good - LICENSE and NOTICE

Re: [VOTE]: Release Apache dubbo-js v3.0.0-rc2

2019-12-07 Thread Justin Mclean
HI, Sorry but it’s -1 (binding) due to compile code in release [1][2] and file not have correct asf headers I checked: - Signatures and hashes fine - LICENSE and NOTICE are fine - Compiled code exist in the release [1][2] - Some java files are missing ASF headers e.g [3] (there about a dozen

Removal of old incubator releases

2019-11-16 Thread Justin Mclean
Hi, It looks like you have some old incubator releases here: https://dist.apache.org/repos/dist/release/incubator/ We’re cleaning up the release area and it would be great if you can remove these old releases. If for some reason you need to link to an old release you can do so with a link to

Re: [VOTE]: Release Apache dubbo-js v3.0.0

2019-11-16 Thread Justin Mclean
Hi, -1 (binding) as the release need to be cryptographically signed, it's missing LICENSE and NOTICE files and missing some ASF headers. I checked: - hash is fine - missing signature - missing LICENSE and NOTICE files - files are missing ASF headers e.g. [1][2][3][4] and others - no unexpected

Re: [VOTE]: Release Apache dubbo-go v1.2.0 RC1

2019-11-04 Thread Justin Mclean
Hi, I noticed that before_ut.sh is missing an execute bit. I also noticed that the install script grabs a jar from here [1]. How is that jar produced? Thanks, Justin 1. https://github.com/dubbogo/resources/tree/master/zookeeper-4unitest/contrib/fatjar

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.4.1 [RC1]

2019-10-30 Thread Justin Mclean
Hi, I notice the documentation refers to external non-Apache websites is there a reason for this? 5. [Dubbo Annotation-Driven (Chinese)](https://github.com/mercyblitz/blogs/blob/master/java/dubbo/Dubbo-Annotation-Driven.md) 6. [Dubbo Externalized Configuration

Re: [VOTE] Accept RitterHou/python-dubbo donation

2019-10-17 Thread Justin Mclean
Hi, Who owns the copyright on this code? I assume it is Qianmi? If so we would need a SGA from them. Thanks, Justin

Re: network transmission extension of xScoket

2019-10-15 Thread Justin Mclean
Hi, I noticed it’d under a GPL license, so some care will need to be taken if it is merged. i.e. no GPL code in a release, and it needs to be an optional dependancy. Thanks, Justin

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC2]

2019-10-15 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes fine - LICENSE and NOTICE OK - no unexpected binary files - source files have ASF headers - can compile from source RE the software grant normally when a copyright is removed and the headers replaced you need to put something in NOTICE saying

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-12 Thread Justin Mclean
Hi, > Since we have submitted the SGA, could you please help to start a new vote? I‘m not sure the SGA has been accepted / acknowledged yet, it would be too early to make another RC until it has been done so. Thanks, Justin

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-09 Thread Justin Mclean
Hi, > If the owner agree to sign SGA, do we have to transfer that project to > apache, I mean, move the project from 'alibaba/spring-context-support’ to > 'apache/spring-context-support’? I don’t think there's a hard requirment to transfer it. The SGA just grants permission to use what’s in

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-09 Thread Justin Mclean
Hi, > The new PRs were committed and merged, and the correlative code also was > re-implemented including If you do a diff or manual comparison on the files you’ll see that there are still some lines that are the same, yes they have been modified but that doesn’t mean you own the IP on the

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-08 Thread Justin Mclean
Hi, Doing a comparison between those two directory I see 6 files that have code in common. Not it’s not only code in common but comments as well, trivial small amount of code may not be covered by copyright, but the comments will be. > Assume the owner is Alibaba, then what we should ask them

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-08 Thread Justin Mclean
Hi, >> 1. Rewrite the code completely. > > The code has been rewritten I can see one file has been rewritten but not all of the files. Am I correct in that assessment? Thanks, Justin

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-08 Thread Justin Mclean
Hi, > 1. Rewrite the code completely. > 2. Ask the owner for a software grant What’s easier to do? I assume 2 would be easier than 1 given they have donated code before? Thanks,. Justin

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-10-08 Thread Justin Mclean
Hi, > How about we add some declaration about this util java files in *LICENSE* > file. While the code is now under an Apache license, IMO it's still unknown who the IP owner is and if they agreed to that license change. So I think we would need to do more than just add something to the

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-30 Thread Justin Mclean
HI, > I checked the commit[1], several methods were removed from the file. I think > it’s ok to proceed now if the other codes were originally written by > yourself. I can help to cancel this vote and start a new one with the latest > codes. > > Before we doing that, let’s see what other

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-28 Thread Justin Mclean
Hi, > All code and files of https://github.com/alibaba/spring-context-support are > writen by me, they are not originally from other projects, but > are come from My private repo. You may of written the code but who owns the IP? I would guess, but may be wrong, that Alibaba does not you. Most

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Justin Mclean
Hi, > > It’s strange these files have an ASF header when they are in a non ASF repo > > which is licensed under a non ASF license. What the story behind these > > files? > > The license of https://github.com/alibaba/spring-context-support >

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Justin Mclean
HI, To repeat my questions: It’s strange these files have an ASF header when they are in a non ASF repo which is licensed under a non ASF license. What the story behind these files? PR#3 says "Add some code from other places”, what other places did this code come from? If this is the case,

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-27 Thread Justin Mclean
HI, > I believe there's no show stopper. Let's continue to vote the release. They are not but I’m still waiting an answer to my other questions, which may be? Anyone? Thanks, Justin

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-25 Thread Justin Mclean
Hi, > I'm the author of https://github.com/alibaba/spring-context-support, could > I change the LICENSE of this project to be "Apache License 2.0" to resolve > this issue? If you are the only contributor (which seems to be the case) that would be one way of dealing with it. The Dubbo LICENSE

Re: [VOTE]: Release Apache Dubbo 2.7.4 [RC1]

2019-09-25 Thread Justin Mclean
Hi, -1 binding (due to Category X software being included). I checked: - signatures and hashes fine - LICENSE is OK (see below) - NOTICE is fine - There are a couple of files that are missing ASF headers e.g. [1] - There are no unexpected binary files - can compile from source This file [4]

Re: [apache/dubbo] Release dubbo-2.7.4 - apache-dubbo-2.7.4

2019-09-25 Thread Justin Mclean
Hi, > I got this email. I see 2.7.4 is still under the release vote process. > The release note should be in draft state until it is approved by the > community vote. I’ve marked it as “pre-release”. Under no circumstances should software be provided to the general public that have not gone

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-09 Thread Justin Mclean
Hi, > Since Justin suggests you to put all artifacts in RC2 directory, you may > not consider this email as an official vote, but I did spend a little time > on sanity check against your second release. While potentially confusing, I would leave this vote open and treat it as “official”. Take

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-07 Thread Justin Mclean
HI, > I really do not have so much experience how to release an apache package. > It just is my fault. May I suggest that let we close this vote this time? Votes should stay open for a minimum of 72 hours, votes pass when you get 3 +1 votes from PMC members (and there’s more +1 votes than -1

Re: [VOTE]: Release Apache dubbo-go v1.1.0 RC2

2019-09-07 Thread Justin Mclean
Hi, > This is a call for vote to release Apache Dubbo-go version v1.1.0 RC2. > The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ Please don’t overwrite the exacting artefact being voted on as we then have no way of knowing which they voted on. They could

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-07 Thread Justin Mclean
Hi, > Alex, you need to initial the release vote again, see: dubbo-go 1.1.0 RC2 Why is that? This vote hasn’t finished yet and so far only have +1 votes. I’ve not checked how many are from the PMC but it may be that this votes has passed. Thanks, Justin

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, > You need to fix the license header issue Justin points out. Well my question also needs to be answered is it just a missing header (a minor issues) or is it 3rd party software (a more serious issue). Thanks, Justin

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, I’m still seeing a lot of +1’s without saying what was checked, if you vote please list what you checked as it helps other people know where to look. If also expected that people will compile and test it and report back if there are any issues outside of what’s the ASF requires for a

Re: [VOTE]: Release Apache Dubbo-go v1.1.0

2019-09-05 Thread Justin Mclean
Hi, Great improvement over the previous release but there are still issues from the last vote that have not been resolved. e.g. [6][7][8] Can someone tell me if these files [1][2][3][4][5] are just missing ASF headers or have a different license? If they are just missing headers and [6][7][8]

Re: dubbogo v1.1.0

2019-08-22 Thread Justin Mclean
Hi, What's going on here? I don’t see any more votes or the vote being cancelled. If there is conversation happening about this elsewhere please bring it back to the list. Thanks, Justin

Re: [DISCUSS] Integrated ICE

2019-08-15 Thread Justin Mclean
Hi, Who is the IP owner of the code? We would need a signed ICLA (if one hasn’t been signed already) and most likely a software grant [1] for this to be donated. Thanks, Justin 1. https://www.apache.org/licenses/contributor-agreements.html

Re: dubbogo v1.1.0

2019-08-13 Thread Justin Mclean
Hi, -1 (binding) due to binaries in source release and unknown license issues It’s a good idea to put [VOTE]” is the subject title so people know it’s a vote and to give the artifacts a release candidate name. e.g. RC1, RC2 etc so it doesn’t become confusing release candidate which you are

Re: dubbogo v1.1.0

2019-08-13 Thread Justin Mclean
Hi, Sorry, the email was oddly formatted and the GitHub link more prominent. Sorry for the noise. Thanks, Justin

Re: dubbogo v1.1.0

2019-08-13 Thread Justin Mclean
Hi, > Hello Dubbo/Dubbogo Community, This is a call for vote to release Apache > Dubbo-go version 1.1.0. The release candidates: > https://dist.apache.org/repos/dist/dev/dubbo/dubbo-go/1.1.0/ > Git tag for > the release: > >

Release locations

2019-08-09 Thread Justin Mclean
HI, I was creating the incubator report and noticed this check in: r34927 | mercyblitz | 2019-07-19 13:04:04 +1000 (Fri, 19 Jul 2019) | 1 line Changed paths: A /release/incubator/dubbo/2.6.7 A /release/incubator/dubbo/2.6.7/apache-dubbo-2.6.7-bin-release.zip A

Re: [VOTE]: Release Apache Dubbo Spring Boot 2.7.3 [RC1]

2019-08-03 Thread Justin Mclean
Hi, +1 (binding) I checked: - signatures and hashes are good - LICENSE is fine - NOTICE still mentions incubating there no need to do that - All source files have ASF headers - No unexpected binary files -Can compile from source The DISCLAIMER is no longer required as this is not an incubating

Re: dubbogo v1.1.0

2019-08-01 Thread Justin Mclean
Hi, You actually need a release artefact to vote one, we cannot not vote a git tag. The releases need to placed in the offical release area and be signed and have hashes. People who been involved in previous Dubbo releases can help you here, ask them for advice. Thanks, Justin

Re: Binary distribution files for 2.6.7 release

2019-07-23 Thread Justin Mclean
Hi, Ad that way is can be easily confirmed that they were build from the source code. Thanks, Justin

Re: Binary distribution files for 2.6.7 release

2019-07-23 Thread Justin Mclean
HI, > The binary files were added to the release branch of svn after the voting > stage. While ASF projects only release source, in future it’s probably best to vote on them at the same time. The LICENSE and NOTICE files for instance may need be different. Thanks, Justin

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
HI, > All authors agree to change the headers, could I change it now? As I said IMO it's better done after the donation that way the original copyright is recorded in an ASF repo. Currently there is no NOTICE file in which the move that information to (which is an ASF requirement). Thanks,

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
Hi, > Is it better to change the header to standard Apache license header > before donation? Headers should never be changed without the express permission of the author. I would change them (and relocate the copyrights to NOTICE) after the donation has happened. Thanks, Justin

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
Hi, Which leaves these unaccounted for: // Copyright 2016-2019 ckex...@vip.qq.com // Copyright 2016-2019 rzy1...@163.com // Copyright 2016-2019 summerbu...@gmail.com Well they might match but it’s hard to tell, for instance Liam Chen might be summerbu...@gmail.com or that could be someone

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
Hi, I also note it hard to match the copyright names to contributors on the project: https://github.com/dubbogo/hessian2/graphs/contributors Is this documented somewhere? Thanks, Justin

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
Hi, > * Check and make sure that for all items included with the > distribution that is not under the Apache license, we have the right > to combine with Apache-licensed code and redistribute. > * Check and make sure that all items depended upon by the project is > covered by one or more of the

Re: dubbogo/hessian2 is ready for transfering now

2019-07-16 Thread Justin Mclean
Hi, > With ICLA signed and SGA not necessary to sign Why do you think a SGA is not needed? Thanks, Justin

  1   2   3   >