Re: [DISCUSS] [Contributing] (3) - Review Tooling

2018-09-21 Thread vino yang
Hi Jin Sun, Earlier this year, I also had these questions when I started contributing code to Flink. In fact, the timing of a PR being reviewed will be related to the priority of the problem solved by the PR. And when you indicate the module to which it belongs in the title of the PR, like

Re: Codespeed deployment for Flink

2018-09-21 Thread vino yang
Hi Piotr and Nico, Thank you for your hard work, it looks great. With it, there will be quantifiable indicators of the impact of changes and improvements in Flink source code. Thanks, vino. Kostas Kloudas 于2018年9月22日周六 上午12:01写道: > Thanks for this contribution Piotr and Nico. > > Tools like

Re: [DISCUSS] [Contributing] (3) - Review Tooling

2018-09-21 Thread Jin Sun
As a new contributor I cared about how to make my contribution accepted by the community, some questions: 1) When will it get reviewed? Is there a rule about review timeline? 2) There are long backlog of pull requests, What happened if a pull request not get noticed, do we have some mechanism

[jira] [Created] (FLINK-10390) DataDog metric reporter leak warning

2018-09-21 Thread Elias Levy (JIRA)
Elias Levy created FLINK-10390: -- Summary: DataDog metric reporter leak warning Key: FLINK-10390 URL: https://issues.apache.org/jira/browse/FLINK-10390 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-10389) TaskManagerServicesConfiguration ctor contains self assignment

2018-09-21 Thread Ted Yu (JIRA)
Ted Yu created FLINK-10389: -- Summary: TaskManagerServicesConfiguration ctor contains self assignment Key: FLINK-10389 URL: https://issues.apache.org/jira/browse/FLINK-10389 Project: Flink Issue

[jira] [Created] (FLINK-10388) RestClientTest sometimes fails with AssertionError

2018-09-21 Thread Ted Yu (JIRA)
Ted Yu created FLINK-10388: -- Summary: RestClientTest sometimes fails with AssertionError Key: FLINK-10388 URL: https://issues.apache.org/jira/browse/FLINK-10388 Project: Flink Issue Type: Test

Re: Codespeed deployment for Flink

2018-09-21 Thread Kostas Kloudas
Thanks for this contribution Piotr and Nico. Tools like this are really useful for Flink’s success. Cheers, Kostas > On Sep 21, 2018, at 4:59 PM, Piotr Nowojski wrote: > > Hello community, > > For almost a year in data Artisans Nico and I were maintaining a setup > that continuously

Codespeed deployment for Flink

2018-09-21 Thread Piotr Nowojski
Hello community, For almost a year in data Artisans Nico and I were maintaining a setup that continuously evaluates Flink with benchmarks defined at https://github.com/dataArtisans/flink-benchmarks . With growing interest and after proving useful

[jira] [Created] (FLINK-10387) StateBackend create methods should return interface not abstract KeyedStateBackend classes

2018-09-21 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-10387: -- Summary: StateBackend create methods should return interface not abstract KeyedStateBackend classes Key: FLINK-10387 URL: https://issues.apache.org/jira/browse/FLINK-10387