Re: [Discuss] FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

2024-04-30 Thread Alan Sheinberg
Thanks for the comment Timo! Since FunctionDefinition is kind of a declaration, it should rather read > declarative as well. I suggest to call this method > `supportsConstantFolding`. `allow` sounds like one could influence the > state of the function from the outside. > That makes sense.

[jira] [Created] (FLINK-35279) Support "last-state" upgrade mode for FlinkSessionJob

2024-04-30 Thread Alan Zhang (Jira)
Alan Zhang created FLINK-35279: -- Summary: Support "last-state" upgrade mode for FlinkSessionJob Key: FLINK-35279 URL: https://issues.apache.org/jira/browse/FLINK-35279 Project: Flink Issue

[RESULT][VOTE] FLIP-446: Kubernetes Operator State Snapshot CRD

2024-04-30 Thread Mate Czagany
Hi all, I'm happy to announce that FLIP-446: Kubernetes Operator State Snapshot CRD [1] has been accepted with 9 approving votes (4 binding) [2]. I would like to thank everyone who took part in the discussion and/or voted. - Rui Fan (binding) - Ferenc Csaky (non-binding) - Gyula Fora (binding)

[jira] [Created] (FLINK-35278) Occasional NPE on k8s operator status replacement

2024-04-30 Thread Jira
Márton Balassi created FLINK-35278: -- Summary: Occasional NPE on k8s operator status replacement Key: FLINK-35278 URL: https://issues.apache.org/jira/browse/FLINK-35278 Project: Flink Issue

[jira] [Created] (FLINK-35277) Fix the error in the `asncdcaddremove.sql` script for the DB2 test container.

2024-04-30 Thread wenli xiao (Jira)
wenli xiao created FLINK-35277: -- Summary: Fix the error in the `asncdcaddremove.sql` script for the DB2 test container. Key: FLINK-35277 URL: https://issues.apache.org/jira/browse/FLINK-35277 Project:

[jira] [Created] (FLINK-35276) SortCodeGeneratorTest.testMultiKeys fails on negative zero

2024-04-30 Thread Ryan Skraba (Jira)
Ryan Skraba created FLINK-35276: --- Summary: SortCodeGeneratorTest.testMultiKeys fails on negative zero Key: FLINK-35276 URL: https://issues.apache.org/jira/browse/FLINK-35276 Project: Flink

[jira] [Created] (FLINK-35275) ArrayContainsFunction uses wrong DataType to create element getter

2024-04-30 Thread PengFei Li (Jira)
PengFei Li created FLINK-35275: -- Summary: ArrayContainsFunction uses wrong DataType to create element getter Key: FLINK-35275 URL: https://issues.apache.org/jira/browse/FLINK-35275 Project: Flink

Re: [DISCUSS] FLIP-444: Native file copy support

2024-04-30 Thread Stefan Richter
Hi, Thanks for the proposal, I think improving download speed in this way is a great idea. Hope we can have similar improvements for other clouds as well. Best, Stefan > On 30. Apr 2024, at 15:15, Piotr Nowojski wrote: > > Hi all! > > I would like to put under discussion: > > FLIP-444:

Re: [DISCUSS] FLIP-444: Native file copy support

2024-04-30 Thread Roman Khachatryan
Hi Piotr, +1 for the proposal, the recovery time improvements are significant IMO Thanks for pushing this Regards, Roman On Tue, Apr 30, 2024 at 3:15 PM Piotr Nowojski wrote: > Hi all! > > I would like to put under discussion: > > FLIP-444: Native file copy support >

Re: [DISCUSS] FLIP-443: Interruptible watermark processing

2024-04-30 Thread Stefan Richter
Thanks for the improvement proposal, I’m +1 for the change! Best, Stefan > On 30. Apr 2024, at 15:23, Roman Khachatryan wrote: > > Thanks for the proposal, I definitely see the need for this improvement, +1. > > Regards, > Roman > > > On Tue, Apr 30, 2024 at 3:11 PM Piotr Nowojski

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-04-30 Thread Lincoln Lee
Thanks Ron for starting this flip! It will complete the user story for flip-435[1]. Regarding the WorkflowOperation, I have a question about whether we should add Delete/DropWorkflowOperation as well for when the Materialized Table is dropped or refresh mode changed from full to continuous? [1]

Re: [DISCUSS] FLIP-443: Interruptible watermark processing

2024-04-30 Thread Roman Khachatryan
Thanks for the proposal, I definitely see the need for this improvement, +1. Regards, Roman On Tue, Apr 30, 2024 at 3:11 PM Piotr Nowojski wrote: > Hi Yanfei, > > Thanks for the feedback! > > > 1. Currently when AbstractStreamOperator or AbstractStreamOperatorV2 > > processes a watermark, the

[DISCUSS] FLIP-444: Native file copy support

2024-04-30 Thread Piotr Nowojski
Hi all! I would like to put under discussion: FLIP-444: Native file copy support https://cwiki.apache.org/confluence/x/rAn9EQ This proposal aims to speed up Flink recovery times, by speeding up state download times. However in the future, the same mechanism could be also used to speed up state

Re: [DISCUSS] FLIP-443: Interruptible watermark processing

2024-04-30 Thread Piotr Nowojski
Hi Yanfei, Thanks for the feedback! > 1. Currently when AbstractStreamOperator or AbstractStreamOperatorV2 > processes a watermark, the watermark will be sent to downstream, if > the `InternalTimerServiceImpl#advanceWatermark` is interrupted, when > is the watermark sent downstream? The

Re: [Discuss] FLIP-452: Allow Skipping Invocation of Function Calls While Constant-folding

2024-04-30 Thread Timo Walther
Hi Alan, thanks for starting this small FLIP. A new method in FunctionDefinition makes a lot of sense and the lack of it was an issue in past already. We should clearly separate determinism and constant folding behavior. Since FunctionDefinition is kind of a declaration, it should rather

[jira] [Created] (FLINK-35274) Occasional failure issue with Flink CDC Db2 UT

2024-04-30 Thread Xin Gong (Jira)
Xin Gong created FLINK-35274: Summary: Occasional failure issue with Flink CDC Db2 UT Key: FLINK-35274 URL: https://issues.apache.org/jira/browse/FLINK-35274 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-35273) PyFlink's LocalZonedTimestampType should respect timezone set by set_local_timezone

2024-04-30 Thread Biao Geng (Jira)
Biao Geng created FLINK-35273: - Summary: PyFlink's LocalZonedTimestampType should respect timezone set by set_local_timezone Key: FLINK-35273 URL: https://issues.apache.org/jira/browse/FLINK-35273

Re: [DISCUSS] FLIP-XXX Support currentFetchEventTimeLag and processingLag metrics

2024-04-30 Thread lorenzo . affetti
Thank you for your efforts! I think that Qingsheng reported my concerns about discrepancies between event time from the external system and current system time in the Flink cluster in a more concrete fashion. Thank you for the catch! The FLIP definitely makes sense and would love to see your

Re: [DISCUSS] FLIP-448: Introduce Pluggable Workflow Scheduler Interface for Materialized Table

2024-04-30 Thread lorenzo . affetti
Hello Ron, thank you for your detailed answers! For the Visitor pattern, I thought about it the other way around, so that operations visit the scheduler, and not vice-versa :) In this way operations can get the required information in order to be executed in a tailored way. Thank you for your