Re: Re: [ANNOUNCE] Apache Flink CDC 3.1.0 released

2024-05-19 Thread Jingsong Li
CC to the Paimon community. Best, Jingsong On Mon, May 20, 2024 at 9:55 AM Jingsong Li wrote: > > Amazing, congrats! > > Best, > Jingsong > > On Sat, May 18, 2024 at 3:10 PM 大卫415 <2446566...@qq.com.invalid> wrote: > > > > 退订 > > > > > >

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #3

2024-05-16 Thread Jingsong Li
+1 (binding) - Verified signature and checksum hash - Verified that no binaries exist in the source archive - Build source code successful - Reviewed the release web PR - Check tag and branch exist Best, Jingsong On Thu, May 16, 2024 at 4:25 PM Jark Wu wrote: > > +1 (binding) > > - checked

Re: [VOTE] Apache Flink CDC Release 3.1.0, release candidate #1

2024-05-08 Thread Jingsong Li
-1 Thanks Qingsheng for preparing this RC. If you bundle third-party dependencies (non Flink dependencies) in your published jar, you need to write them in the NOTICE file. I recommend adding a test using flink-ci-tools to verify if the NOTICE file is correct. Of course, you cannot rely too

Re: [VOTE] FLIP-435: Introduce a New Materialized Table for Simplifying Data Pipelines

2024-04-18 Thread Jingsong Li
+1 On Thu, Apr 18, 2024 at 11:09 AM Yun Tang wrote: > > +1 (binding) > > Best, > Yun Tang > > From: Jark Wu > Sent: Thursday, April 18, 2024 9:54 > To: dev@flink.apache.org > Subject: Re: [VOTE] FLIP-435: Introduce a New Materialized Table for > Simplifying

Re: Re: [ANNOUNCE] New Apache Flink PMC Member - Lincoln Lee

2024-04-14 Thread Jingsong Li
Congratulations On Mon, Apr 15, 2024 at 9:32 AM Xuyang wrote: > > Congratulations, Lincoln. > > > -- > > Best! > Xuyang > > > > > > 在 2024-04-14 21:49:53,"Benchao Li" 写道: > >Congratulations, Lincoln. Well deserved! > > > >Leonard Xu 于2024年4月14日周日 21:19写道: > >> > >> Congratulations,

Re: [ANNOUNCE] New Apache Flink PMC Member - Jing Ge

2024-04-14 Thread Jingsong Li
Congratulations On Mon, Apr 15, 2024 at 9:32 AM Yanquan Lv wrote: > > Congratulations, Jing! > > Jark Wu 于2024年4月12日周五 16:03写道: > > > Hi everyone, > > > > On behalf of the PMC, I'm very happy to announce that Jing Ge has > > joined the Flink PMC! > > > > Jing has been contributing to Apache

Re: [DISCUSS] Flink Website Menu Adjustment

2024-03-25 Thread Jingsong Li
+1 for the proposal On Mon, Mar 25, 2024 at 10:01 PM Ferenc Csaky wrote: > > Suggested changes makes sense, +1 for the proposed menus and order. > > Best, > Ferenc > > > > > On Monday, March 25th, 2024 at 14:50, Gyula Fóra wrote: > > > > > > > +1 for the proposal > > > > Gyula > > > > On Mon,

Re: [ANNOUNCE] Apache Flink 1.19.0 released

2024-03-18 Thread Jingsong Li
Congratulations! On Mon, Mar 18, 2024 at 4:30 PM Rui Fan <1996fan...@gmail.com> wrote: > > Congratulations, thanks for the great work! > > Best, > Rui > > On Mon, Mar 18, 2024 at 4:26 PM Lincoln Lee wrote: >> >> The Apache Flink community is very happy to announce the release of Apache >> Flink

Re: [DISCUSS] FLIP-436: Introduce "SHOW CREATE CATALOG" Syntax

2024-03-13 Thread Jingsong Li
+1 for this. We are missing a series of catalog related syntaxes. Especially after the introduction of catalog store. [1] [1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-295%3A+Support+lazy+initialization+of+catalogs+and+persistence+of+catalog+configurations Best, Jingsong On Wed,

Re: [DISCUSS] Add "Special Thanks" Page on the Flink Website

2024-03-05 Thread Jingsong Li
+1 for setting up On Tue, Mar 5, 2024 at 5:39 PM Jing Ge wrote: > > +1 and thanks for the proposal! > > Best regards, > Jing > > On Tue, Mar 5, 2024 at 10:26 AM tison wrote: > > > I like this idea, so +1 for setting up. > > > > For anyone who have the access, this is a related thread about > >

Re: [ANNOUNCE] Flink 1.19 Cross-team testing completed & sync summary on 02/27/2024

2024-02-27 Thread Jingsong Li
Thanks Lincoln and all contributors! Best, Jingsong On Wed, Feb 28, 2024 at 12:15 PM Xintong Song wrote: > > Matthias has already said it on the release sync, but I still want to say > it again. It's amazing how smooth the release testing goes for this > release. Great thanks to the release

Re: [ANNOUNCE] New Apache Flink Committer - Jiabao Sun

2024-02-21 Thread Jingsong Li
Congratulations! Well deserved! On Wed, Feb 21, 2024 at 4:36 PM Yuepeng Pan wrote: > > Congratulations~ :) > > Best, > Yuepeng Pan > > > > > > > > > > > 在 2024-02-21 09:52:17,"Hongshun Wang" 写道: > >Congratulations, Jiabao :) > >Congratulations Jiabao! > > > >Best, > >Hongshun > >Best regards, >

Re: [DISCUSS] FLIP-415: Introduce a new join operator to support minibatch

2024-01-11 Thread Jingsong Li
Hi all, This is a relatively large optimization that may pose a significant risk of bugs, so I like to keep it from being enabled by default for now. Best, Jingsong On Fri, Jan 12, 2024 at 3:01 PM shuai xu wrote: > > Suppose we currently have a job that joins two CDC sources after >

Re: Re: [VOTE] FLIP-387: Support named parameters for functions and call procedures

2024-01-09 Thread Jingsong Li
+1 On Wed, Jan 10, 2024 at 11:24 AM Xuyang wrote: > > +1(non-binding)-- > > Best! > Xuyang > > > > > > 在 2024-01-08 00:34:55,"Feng Jin" 写道: > >Hi Alexey > > > >Thank you for the reminder, the link has been updated. > > > >Best, > >Feng Jin > > > >On Sat, Jan 6, 2024 at 12:55 AM Alexey

Re: [VOTE] Accept Flink CDC into Apache Flink

2024-01-08 Thread Jingsong Li
+1 On Tue, Jan 9, 2024 at 3:23 PM Yuan Mei wrote: > > +1 binding > > > > On Tue, Jan 9, 2024 at 3:21 PM Yuan Mei wrote: > > > +1 > > > > Best, > > Yuan > > > > On Tue, Jan 9, 2024 at 3:06 PM tison wrote: > > > >> +1 non-binding > >> > >> Best, > >> tison. > >> > >> Leonard Xu 于2024年1月9日周二

Re: [ANNOUNCE] New Apache Flink Committer - Alexander Fedulov

2024-01-02 Thread Jingsong Li
Congratulations! Best, Jingsong On Wed, Jan 3, 2024 at 10:28 AM Benchao Li wrote: > > Congratulations, Alex! > > Yuepeng Pan 于2024年1月3日周三 10:10写道: > > > > Congrats, Alex! > > > > Best, > > Yuepeng Pan > > At 2024-01-02 20:15:08, "Maximilian Michels" wrote: > > >Happy New Year everyone, > > >

Re: [PROPOSAL] Contribute Flink CDC Connectors project to Apache Flink

2023-12-06 Thread Jingsong Li
Wow, Cool, Nice CDC is playing an increasingly important role. +1 Best, Jingsong On Thu, Dec 7, 2023 at 11:25 AM Leonard Xu wrote: > > Dear Flink devs, > > As you may have heard, we at Alibaba (Ververica) are planning to donate CDC > Connectors for the Apache Flink project[1] to the Apache

Re: [VOTE] FLIP-379: Dynamic source parallelism inference for batch jobs

2023-12-04 Thread Jingsong Li
+1 binding On Mon, Dec 4, 2023 at 10:33 PM Etienne Chauchot wrote: > > Correct, > > I forgot that in the bylaws, committer vote is binding for FLIPs thanks > for the reminder. > > Best > > Etienne > > Le 30/11/2023 à 10:43, Leonard Xu a écrit : > > +1(binding) > > > > Btw, @Etienne, IIRC, your

Re: [DISCUSS] Contribute Flink Doris Connector to the Flink community

2023-11-26 Thread Jingsong Li
+1 for this On Mon, Nov 27, 2023 at 10:26 AM Yun Tang wrote: > > Hi, Di.Wu > > Thanks for creating this discussion. The Apache Doris community might have > the most active contributors in ASF this year, and since I also contributed > to doris-flink-connector before, I'm very glad to see this

Re: Re:Re: [DISCUSS] Release 1.17.2

2023-11-07 Thread Jingsong Li
+1 thanks Yun 1.17.2 is really important. Best, Jingsong On Tue, Nov 7, 2023 at 9:32 AM Danny Cranmer wrote: > > +1, thanks for picking this up. > > I am happy to help out with the bits you need PMC support for. > > Thanks, > Danny > > On Tue, Nov 7, 2023 at 4:03 AM Yun Tang wrote: > > > Hi

Re: [VOTE] FLIP-376: Add DISTRIBUTED BY clause

2023-11-07 Thread Jingsong Li
+1 On Tue, Nov 7, 2023 at 5:56 AM Jim Hughes wrote: > > Hi all, > > +1 (non-binding) > > Cheers, > > Jim > > On Mon, Nov 6, 2023 at 6:39 AM Timo Walther wrote: > > > Hi everyone, > > > > I'd like to start a vote on FLIP-376: Add DISTRIBUTED BY clause[1] which > > has been discussed in this

Re: [ANNOUNCE] Apache Flink 1.18.0 released

2023-10-26 Thread Jingsong Li
Congratulations! Thanks Jing and other release managers and all contributors. Best, Jingsong On Fri, Oct 27, 2023 at 1:52 PM Zakelly Lan wrote: > > Congratulations and thank you all! > > > Best, > Zakelly > > On Fri, Oct 27, 2023 at 12:39 PM Jark Wu wrote: > > > > Congratulations and thanks

Re: flink-sql-connector-jdbc new release

2023-10-26 Thread Jingsong Li
Hi David, Thanks for driving this. I think https://issues.apache.org/jira/browse/FLINK-33365 should be a blocker. Best, Jingsong On Thu, Oct 26, 2023 at 11:43 PM David Radley wrote: > > Hi, > I propose that we do a 3.2 release of flink-sql-connector-jdbc so that there > is a version matching

Re: [DISCUSS] FLIP-376: Add DISTRIBUTED BY clause

2023-10-26 Thread Jingsong Li
Very thanks Timo for starting this discussion. Big +1 for this. The design looks good to me! We can add some documentation for connector developers. For example: for sink, If there needs some keyby, please finish the keyby by the connector itself. SupportsBucketing is just a marker interface.

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-10-24 Thread Jingsong Li
+1 for this FLIP. BTW, I think we can add an option for projection push down too. Yes, we can do all things in the connector, but a common implementation helps a lot! And can introduce an unify option! Best, Jingsong On Wed, Oct 25, 2023 at 10:07 AM Jark Wu wrote: > > Thank you for updating

Re: [VOTE] Release 1.18.0, release candidate #3

2023-10-23 Thread Jingsong Li
+1 (binding) - verified signatures & hash - built from source code succeeded - started SQL Client, used Paimon connector to write and read, the result is expected Best, Jingsong On Tue, Oct 24, 2023 at 12:15 PM Yuxin Tan wrote: > > +1(non-binding) > > - Verified checksum > - Build from source

Re: [DISCUSS] Remove legacy Paimon (TableStore) doc link from Flink web navigation

2023-10-17 Thread Jingsong Li
Hi marton, Thanks for driving. +1 There is a PR to remove legacy Paimon https://github.com/apache/flink-web/pull/665 , but it hasn't been updated for a long time. Best, Jingsong On Tue, Oct 17, 2023 at 4:28 PM Márton Balassi wrote: > > Hi Flink & Paimon devs, > > The Flink webpage

Re: [VOTE] FLIP-356: Support Nested Fields Filter Pushdown

2023-09-05 Thread Jingsong Li
+1 On Wed, Sep 6, 2023 at 1:18 PM Becket Qin wrote: > > Thanks for pushing the FLIP through. > > +1 on the updated FLIP wiki. > > Cheers, > > Jiangjie (Becket) Qin > > On Wed, Sep 6, 2023 at 1:12 PM Venkatakrishnan Sowrirajan > wrote: > > > Based on the recent discussions in the thread

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-28 Thread Jingsong Li
So if NestedFieldReferenceExpression doesn't need inputIndex, is there a need to introduce a base class `ReferenceExpression`? Best, Jingsong On Mon, Aug 28, 2023 at 2:09 PM Jingsong Li wrote: > > Hi thanks all for your discussion. > > What is inputIndex in NestedFieldReferenceExpre

Re: [DISCUSS] FLIP-356: Support Nested Fields Filter Pushdown

2023-08-28 Thread Jingsong Li
Hi thanks all for your discussion. What is inputIndex in NestedFieldReferenceExpression? I know inputIndex has special usage in FieldReferenceExpression, but it is only for Join operators, and it is only for SQL optimization. It looks like there is no requirement for Nested. Best, Jingsong On

Re: [VOTE] Release 2.0 must-have work items - Round 2

2023-07-26 Thread Jingsong Li
+1 binding Thanks all for your work! Best, Jingsong On Thu, Jul 27, 2023 at 10:52 AM Jark Wu wrote: > > +1 (binding) > > Thanks Xintong for driving this. Thanks all for finalizing the > SourceFunction conclusion. > > Best, > Jark > > On Wed, 26 Jul 2023 at 22:28, Alexander Fedulov > wrote: >

[ANNOUNCE] New Apache Flink Committer - Yong Fang

2023-07-23 Thread Jingsong Li
Hi, everyone On behalf of the PMC, I'm very happy to announce Yong Fang (Shammon) (zjur...@gmail.com) as a new Flink Committer. Yong is an old flinker, he has been contributing to Flink since 2017. He actively participated in dev discussions and answered many questions on the user mailing list.

Re: [DISCUSS] FLIP-346: Deprecate ManagedTable related APIs

2023-07-19 Thread Jingsong Li
+1 On Thu, Jul 20, 2023 at 12:31 PM Jane Chan wrote: > > Hi, devs, > > I would like to start a discussion on FLIP-346: Deprecate ManagedTable > related APIs[1]. > > These APIs were initially designed for Flink Table Store, which has > joined the Apache Incubator as a separate project called

Re: [VOTE] FLIP-309: Support using larger checkpointing interval when source is processing backlog

2023-07-18 Thread Jingsong Li
+1 binding Thanks Dong for continuous driving. Best, Jingsong On Tue, Jul 18, 2023 at 10:04 PM Jark Wu wrote: > > +1 (binding) > > Best, > Jark > > On Tue, 18 Jul 2023 at 20:30, Piotr Nowojski wrote: > > > +1 (binding) > > > > Piotrek > > > > wt., 18 lip 2023 o 08:51 Jing Ge napisał(a): > >

Re: [VOTE] Release 2.0 must-have work items

2023-07-11 Thread Jingsong Li
+1 to Leonard and Galen and Jing. About Source and Sink. We're still missing quite a bit of work, including functionality, including ease of use, including bug fixes, and I'm not sure we'll be completely done by 2.0. Until that's done, we won't be in a position to clean up the old APIs. Best,

Re: [DISCUSS] FLIP 333 - Redesign Apache Flink website

2023-07-11 Thread Jingsong Li
It's exciting to finally have someone to refactor the Flink website. Thanks Deepthi. To Xintong, > maintain two sets of website designs at the same time If our website is not so complex, and new webui can be full feature coverage, there would be no need to maintain two sets of web. To Jing

Re: [VOTE] Release 2.0 must-have work items

2023-07-09 Thread Jingsong Li
+1 On Mon, Jul 10, 2023 at 10:46 AM Yuan Mei wrote: > > +1 (binding) > > Thanks for driving this! > > Best > Yuan > > On Mon, Jul 10, 2023 at 10:26 AM Jark Wu wrote: > > > +1 (binding) > > > > Thanks for driving this. Looking forward to starting the 2.0 works. > > > > Best, > > Jark > > > > On

Re: Re: [ANNOUNCE] Apache Flink has won the 2023 SIGMOD Systems Award

2023-07-03 Thread Jingsong Li
Congratulations! Thank you! All of the Flink community! Best, Jingsong On Tue, Jul 4, 2023 at 1:24 PM tison wrote: > > Congrats and with honor :D > > Best, > tison. > > > Mang Zhang 于2023年7月4日周二 11:08写道: > > > Congratulations!-- > > > > Best regards, > > Mang Zhang > > > > > > > > > > > > 在

Re: [VOTE] FLIP-321: introduce an API deprecation process

2023-07-03 Thread Jingsong Li
+1 binding On Tue, Jul 4, 2023 at 10:40 AM Zhu Zhu wrote: > > +1 (binding) > > Thanks, > Zhu > > ConradJam 于2023年7月3日周一 22:39写道: > > > > +1 (no-binding) > > > > Matthias Pohl 于2023年7月3日周一 22:33写道: > > > > > Thanks, Becket > > > > > > +1 (binding) > > > > > > On Mon, Jul 3, 2023 at 10:44 AM

Re: [DISCUSS] Deprecate SourceFunction APIs

2023-07-03 Thread Jingsong Li
> do we have any plan to offer a lighter Source API to decrease the connector > development cost? I remember mentioning it many times, but no contributor did it. ToT Best, Jingsong On Tue, Jul 4, 2023 at 11:01 AM Leonard Xu wrote: > > +1 to deprecate. > +1 for David’s points. > > I’ve one

Re: [VOTE] FLIP-309: Support using larger checkpointing interval when source is processing backlog

2023-06-28 Thread Jingsong Li
+1 binding On Thu, Jun 29, 2023 at 11:03 AM Dong Lin wrote: > > Hi all, > > We would like to start the vote for FLIP-309: Support using larger > checkpointing interval when source is processing backlog [1]. This FLIP was > discussed in this thread [2]. > > Flink 1.18 release will feature freeze

Re: [DISCUSS] FLIP-309: Enable operators to trigger checkpoints dynamically

2023-06-27 Thread Jingsong Li
Looks good to me! Thanks Dong, Yunfeng and all for your discussion and design. Best, Jingsong On Tue, Jun 27, 2023 at 3:35 PM Jark Wu wrote: > > Thank you Dong for driving this FLIP. > > The new design looks good to me! > > Best, > Jark > > > 2023年6月27日 14:38,Dong Lin 写道: > > > > Thank you

Re: [DISCUSS] FLIP-321: Introduce an API deprecation process

2023-06-24 Thread Jingsong Li
Thanks Becket and all for your discussion. > 1. We say this FLIP is enforced starting release 2.0. For current 1.x APIs, we provide a migration period with best effort, while allowing exceptions for immediate removal in 2.0. That means we will still try with best effort to get the ProcessFuncion

Re: Async I/O: preserve stream order for requests on key level

2023-06-20 Thread Jingsong Li
+1 for this. Actually, this is a headache for Flink SQL too. There is certainly a lot of updated data (CDC changelog) in real stream processing, The semantics here is the need to ensure the order between keys, and different keys can be handled in disorder. I'm very happy that the community has

Re: [VOTE] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-12 Thread Jingsong Li
+1 On Mon, Jun 12, 2023 at 10:25 PM Rui Fan <1996fan...@gmail.com> wrote: > > +1 (binding) > > Best, > Rui Fan > > On Mon, Jun 12, 2023 at 19:58 liu ron wrote: > > > +1 (no-binding) > > > > Best, > > Ron > > > > Jing Ge 于2023年6月12日周一 19:33写道: > > > > > +1(binding) Thanks! > > > > > > Best

Re: [VOTE] FLIP-311: Support Call Stored Procedure

2023-06-12 Thread Jingsong Li
+1 On Mon, Jun 12, 2023 at 10:32 PM Rui Fan <1996fan...@gmail.com> wrote: > > +1 (binding) > > Best, > Rui Fan > > On Mon, Jun 12, 2023 at 22:20 Benchao Li wrote: > > > +1 (binding) > > > > yuxia 于2023年6月12日周一 17:58写道: > > > > > Hi everyone, > > > Thanks for all the feedback about FLIP-311:

Re: Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-06-07 Thread Jingsong Li
e.org/confluence/display/FLINK/FLIP-305%3A+Support+atomic+for+CREATE+TABLE+AS+SELECT%28CTAS%29+statement > > > -- > > Best regards, > > Mang Zhang > > > > At 2023-05-12 13:02:14, "Jingsong Li" wrote: > >Hi Mang, > > > >Thanks for st

Re: [VOTE] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-07 Thread Jingsong Li
+1 On Wed, Jun 7, 2023 at 3:03 PM Benchao Li wrote: > > +1, binding > > Jark Wu 于2023年6月7日周三 14:44写道: > > > +1 (binding) > > > > Best, > > Jark > > > > > 2023年6月7日 14:20,liu ron 写道: > > > > > > Hi everyone, > > > > > > Thanks for all the feedback about FLIP-315: Support Operator Fusion > >

Re: [VOTE] Release flink-connector-pulsar 3.0.1, release candidate #1

2023-06-06 Thread Jingsong Li
+1 (binding) - checked NOTICE and LICENSE - Verified signatures and hashes - Build and compile the source code locally - No unexpected binaries in the source release Something can be improved: - NOTICE file can be updated to 2014-2023 from 2014-2022. Best, Jingsong On Tue, Jun 6, 2023 at 3:59 

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-06-05 Thread Jingsong Li
if there is a complete test graph with all TPC-DS queries, the > > > effect of this FLIP will be more intuitive. > > > > > > Best, > > > Jark > > > > > > > > > > > > On Wed, 31 May 2023 at 14:27, liu ron wrote:

Re: [DISCUSS] FLIP 295: Support persistence of Catalog configuration and asynchronous registration

2023-06-01 Thread Jingsong Li
Thanks Feng, Just naming, maybe `createCatalog` in TableEnv, I can see many functions are converted to createxxx from registerxxx. On Fri, Jun 2, 2023 at 11:04 AM Feng Jin wrote: > > Hi jark, thanks for your suggestion. > > > 1. How to register the CatalogStore for Table API? I think the >

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-30 Thread Jingsong Li
to Iterable > > [1]: https://iceberg.apache.org/docs/latest/spark-procedures/#migrate > [2]: > https://github.com/apache/iceberg/blob/601c5af9b6abded79dabeba177331310d5487f43/spark/v3.2/spark/src/main/java/org/apache/spark/sql/connector/iceberg/catalog/Procedure.java#L44 > > Best rega

Re: [DISCUSS] Hive dialect shouldn't fall back to Flink's default dialect

2023-05-30 Thread Jingsong Li
+1, the fallback looks weird now, it is outdated. But, it is good to provide an option. I don't know if there are some users who depend on this fallback. Best, Jingsong On Tue, May 30, 2023 at 1:47 PM Rui Li wrote: > > +1, the fallback was just intended as a temporary workaround to run >

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-05-29 Thread Jingsong Li
rting only Calc operator. In > some queries, we even get more than 30% gain, it looks like an effective > way. > > Best, > Ron > > Jingsong Li 于2023年5月29日周一 14:33写道: > > > Thanks Ron for the proposal. > > > > Do you have some benchmark results for t

Re: [DISCUSS] FLIP-311: Support Call Stored Procedure

2023-05-29 Thread Jingsong Li
Thanks Yuxia for the proposal. > CALL [catalog_name.][database_name.]procedure_name ([ expression [, > expression]* ] ) The expression can be a function call. Does this need to be a function call? Do you have some example? > Procedure returns T[] Procedure looks like a TableFunction, do you

Re: [DISCUSS] FLIP-315: Support Operator Fusion Codegen for Flink SQL

2023-05-29 Thread Jingsong Li
Thanks Ron for the proposal. Do you have some benchmark results for the performance improvement? I am more concerned about the improvement on Flink than the data in other papers. Best, Jingsong On Mon, May 29, 2023 at 2:16 PM liu ron wrote: > > Hi, dev > > I'd like to start a discussion about

Re: Re: [DISCUSS] FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-05-11 Thread Jingsong Li
Hi Mang, Thanks for starting this FLIP. I have some doubts about the `TwoPhaseCatalogTable`. Generally, our Flink design places execution in the TableFactory or directly in the Catalog, so introducing an executable table makes me feel a bit strange. (Spark is this style, but Flink may not be)

Re: [DISCUSS] Release Flink 1.16.2

2023-05-11 Thread Jingsong Li
+1 for releasing 1.16.2 Best, Jingsong On Thu, May 11, 2023 at 1:28 PM Gyula Fóra wrote: > > +1 for the release > > Gyula > > On Thu, 11 May 2023 at 05:08, weijie guo wrote: > > > [1] > > > >

Re: [DISCUSS] Release Flink 1.17.1

2023-05-11 Thread Jingsong Li
+1 for releasing 1.17.1 Best, Jingsong On Thu, May 11, 2023 at 1:29 PM Gyula Fóra wrote: > > +1 for the release > > Gyula > > On Thu, 11 May 2023 at 05:35, Yun Tang wrote: > > > +1 for release flink-1.17.1 > > > > The blocker issue might cause silent incorrect data, it's better to have a > >

Re: Re: [VOTE] FLIP-302: Support TRUNCATE TABLE statement in batch mode

2023-04-17 Thread Jingsong Li
+1 On Tue, Apr 18, 2023 at 9:39 AM Aitozi wrote: > > +1 > > Best, > Aitozi > > ron 于2023年4月18日周二 09:18写道: > > > > +1 > > > > > > > -原始邮件- > > > 发件人: "Lincoln Lee" > > > 发送时间: 2023-04-18 09:08:08 (星期二) > > > 收件人: dev@flink.apache.org > > > 抄送: > > > 主题: Re: [VOTE] FLIP-302: Support

Re: [DISCUSS] Release Paimon 0.4

2023-04-12 Thread Jingsong Li
Oh sorry to Flink devs, This email should be sent to paimon dev, please ignore it. Best, Jingsong On Thu, Apr 13, 2023 at 10:56 AM Jingsong Li wrote: > > Hi everyone, > > I'm going to check out the 0.4 branch out next Monday, and won't merge > major refactoring-related PRs int

[DISCUSS] Release Paimon 0.4

2023-04-12 Thread Jingsong Li
Hi everyone, I'm going to check out the 0.4 branch out next Monday, and won't merge major refactoring-related PRs into master branch until next Monday. Blockers: - Entire Database Sync CC @Caizhi Weng - CDC Ingestion mysql DATETIME(6) cast error [1] - MySqlSyncTableAction should support case

Re: [DISCUSS] FLIP-306: Unified File Merging Mechanism for Checkpoints

2023-04-07 Thread Jingsong Li
Hi Yun, It looks like this doc needs permission to read? [1] [1] https://docs.google.com/document/d/1NJJQ30P27BmUvD7oa4FChvkYxMEgjRPTVdO1dHLl_9I/edit# Best, Jingsong On Fri, Apr 7, 2023 at 4:34 PM Piotr Nowojski wrote: > > Hi, > > +1 To what Yun Tang wrote. We don't seem to have access to

Re: [DISCUSS] FLIP-302: Support TRUNCATE TABLE statement

2023-04-06 Thread Jingsong Li
+1 for voting. Best, Jingsong On Thu, Apr 6, 2023 at 4:52 PM yuxia wrote: > > Hi everyone. > > If there are no other questions or concerns for the FLIP[1], I'd like to > start the vote next Monday (4.10). > > [1] >

Re: [ANNOUNCE] Flink Table Store Joins Apache Incubator as Apache Paimon(incubating)

2023-03-27 Thread Jingsong Li
Congratulations! I believe Paimon will work with Flink to build the best streaming data warehouse. Best, Jingsong On Tue, Mar 28, 2023 at 8:27 AM Shammon FY wrote: > > Congratulations! > > > Best, > Shammon FY > > On Mon, Mar 27, 2023 at 11:37 PM Samrat Deb wrote: > > > congratulations > > >

Re: [VOTE] FLIP-296: Extend watermark-related features for SQL

2023-03-20 Thread Jingsong Li
+1 binding Jark Wu 于2023年3月20日 周一21:19写道: > +1 (binding) > > Best, > Jark > > > 2023年3月15日 17:42,Yun Tang 写道: > > > > +1 (binding) > > > > Thanks Kui for driving this work. > > > > > > Best > > Yun Tang > > > > From: Kui Yuan > > Sent: Wednesday, March 15, 2023

Re: [VOTE] FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null overwrite problem of partial-insert

2023-03-14 Thread Jingsong Li
+1 binding On Tue, Mar 14, 2023 at 10:54 AM Samrat Deb wrote: > > +1 (non binding) > Thanks for driving it . > > Bests, > Samrat > > On Tue, 14 Mar 2023 at 7:41 AM, Jark Wu wrote: > > > +1 (binding) > > > > Best, > > Jark > > > > > 2023年3月13日 23:25,Aitozi 写道: > > > > > > +1 (non-binding) > > >

Re: [VOTE] FLIP-293: Introduce Flink Jdbc Driver For Sql Gateway

2023-03-13 Thread Jingsong Li
+1 (binding) Not block voting. But comment about `Public Interface` in the FLIP: these classes may not be `Public interface`? I think they are just internal implementations. Best, Jingsong On Mon, Mar 13, 2023 at 2:10 PM Benchao Li wrote: > > +1 (binding) > > Shammon FY 于2023年3月13日周一 13:47写道:

Re: Re: [ANNOUNCE] New Apache Flink Committer - Yuxia Luo

2023-03-12 Thread Jingsong Li
Congratulations, Yuxia! On Mon, Mar 13, 2023 at 11:49 AM Juntao Hu wrote: > > Congratulations, Yuxia! > > Best, > Juntao > > > Wencong Liu 于2023年3月13日周一 11:33写道: > > > Congratulations, Yuxia! > > > > Best, > > Wencong Liu > > > > > > At 2023-03-13 11:20:21, "Qingsheng Ren" wrote: > >

Re: [DISCUSS] FLIP-300: Add targetColumns to DynamicTableSink#Context to solve the null overwrite problem of partial-insert

2023-03-06 Thread Jingsong Li
Wow, we have 300 FLIPs... Thanks Lincoln, Have you considered returning an Optional? Empty array looks a little weird to me. Best, Jingsong On Tue, Mar 7, 2023 at 10:32 AM Aitozi wrote: > > Hi Lincoln, > Thank you for sharing this FLIP. Overall, it looks good to me. I have > one

Re: [DISCUSS] FLIP-293: Introduce Flink Jdbc Driver For Sql Gateway

2023-03-02 Thread Jingsong Li
DBC interfaces listed in the FLIP, I think they looks good > > already. Besides `java.sql.Driver`, have you considered also adding support > > for `javax.sql.DataSource` interface? > > > > Jingsong Li 于2023年3月1日周三 17:53写道: > > > > > Thanks Shammon f

Re: [VOTE] Flink minor version support policy for old releases

2023-03-02 Thread Jingsong Li
+1 (binding) On Thu, Mar 2, 2023 at 1:30 PM Yu Li wrote: > > +1 (binding) > > Best Regards, > Yu > > > On Thu, 2 Mar 2023 at 09:53, Jark Wu wrote: > > > +1 (binding) > > > > Best, > > Jark > > > > > 2023年3月2日 05:03,Gyula Fóra 写道: > > > > > > +1 (binding) > > > > > > Gyula > > > > > > On Wed,

Re: [DISCUSS] FLIP-293: Introduce Flink Jdbc Driver For Sql Gateway

2023-03-01 Thread Jingsong Li
Thanks Shammon for driving. Big +1 for this. I heard that many users want to use FlinkGateway + JDBC to do some queries, but at present, only Hive JDBC can be used. It is Hive dialect by default, and the experience is also different from FlinkSQL. We need to have our own JDBC. I took a look at

Re: [DISCUSS] Deprecate deserialize method in DeserializationSchema

2023-02-28 Thread Jingsong Li
- `T deserialize(byte[] message)` is widely used and it is a public api. It is very friendly for single record deserializers. - `void deserialize(byte[] message, Collector out)` supports multiple records. I think we can just keep them as they are. Best, Jingsong On Tue, Feb 28, 2023 at 3:08 PM

Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-27 Thread Jingsong Li
cond point, how can we track > the performance changes of the micro benchmark? What do you think? > > Best, > Shammon > > On Mon, Feb 27, 2023 at 10:57 AM Jingsong Li wrote: > > > Thanks Yun. > > > > Another way is we can get rid of JMH, something like Spark

Re: [Discuss] Some questions on flink-table-store micro benchmark

2023-02-26 Thread Jingsong Li
Thanks Yun. Another way is we can get rid of JMH, something like Spark `org.apache.spark.benchmark.Benchmark` can replace JMH. Best, Jingsong On Mon, Feb 27, 2023 at 1:24 AM Yun Tang wrote: > > Hi dev, > > I just noticed that flink-table-store had introduced the micro benchmark > module [1]

Re: [ANNOUNCE] Flink project website is now powered by Hugo

2023-02-23 Thread Jingsong Li
Thanks Martijn! On Fri, Feb 24, 2023 at 9:46 AM yuxia wrote: > > Thanks Martijn for your work. > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jing Ge" > 收件人: "dev" > 发送时间: 星期五, 2023年 2 月 24日 上午 5:20:30 > 主题: Re: [ANNOUNCE] Flink project website is now powered by Hugo > > Congrats

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-23 Thread Jingsong Li
YT? > > Best regards, > Jing > > [1] > https://hackernoon.com/object-oriented-tricks-2-law-of-demeter-4ecc9becad85 > > On Thu, Feb 23, 2023 at 6:26 AM Ran Tao wrote: > > > Hi Jingsong. thanks. i got it. > > In this way, there is no need to introduce new API change

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-22 Thread Jingsong Li
ses() { > return catalogManager > .getCatalog(catalogManager.getCurrentCatalog()) > .get() > .listDatabases() > .toArray(new String[0]); > } > > Best Regards, > Ran Tao > > > Jingsong Li 于2023年

Re: [DISCUSS] FLIP-297: Improve Auxiliary Sql Statements

2023-02-22 Thread Jingsong Li
Thanks for the proposal. +1 for the proposal. I am confused about "Proposed TableEnvironment SQL API Changes", can we just use catalog api for this requirement? Best, Jingsong On Thu, Feb 23, 2023 at 10:48 AM Jacky Lau wrote: > > Hi Ran: > Thanks for driving the FLIP. the google doc looks

Re: [DISCUSS] FLIP-296: Watermark options for table API & SQL

2023-02-22 Thread Jingsong Li
Thanks for your proposal. +1 to yuxia, consider watermark-related hints as option hints. Personally, I am cautious about adding SQL syntax, WATERMARK_PARAMS is also SQL syntax to some extent. We can use OPTIONS to meet this requirement if possible. Best, Jingsong On Thu, Feb 23, 2023 at 10:41

Re: [ANNOUNCE] New Apache Flink Committer - Jing Ge

2023-02-13 Thread Jingsong Li
Congratulations Jing! Best, Jingsong On Tue, Feb 14, 2023 at 3:50 PM godfrey he wrote: > > Hi everyone, > > On behalf of the PMC, I'm very happy to announce Jing Ge as a new Flink > committer. > > Jing has been consistently contributing to the project for over 1 year. > He authored more than 50

[ANNOUNCE] Apache Flink Table Store 0.3.0 released

2023-01-13 Thread Jingsong Li
The Apache Flink community is very happy to announce the release of Apache Flink Table Store 0.3.0. Apache Flink Table Store is a unified storage to build dynamic tables for both streaming and batch processing in Flink, supporting high-speed data ingestion and timely data query. Please check out

[RESULT][VOTE] Apache Flink Table Store 0.3.0, release candidate #1

2023-01-13 Thread Jingsong Li
I'm happy to announce that we have unanimously approved this release. There are 3 approving votes, 3 of which are binding: * Yu Li (binding) * Jark Wu (binding) * Jingsong Lee (binding) There are no disapproving votes. Thank you for verifying the release candidate. I will now proceed to

Re: [VOTE] Apache Flink Table Store 0.3.0, release candidate #1

2023-01-13 Thread Jingsong Li
bsite release PR: *OK* > - Checked the licenses: *OK* > - Went through the quick start: *OK* > * Verified with both flink 1.14.5 and 1.15.1 using > * Verified web UI and log output, nothing unexpected > > Best, > Jark > > On Thu, 12 Jan 2023 at 20:52, Jingsong Li wrote: &

Re: [VOTE] Apache Flink Table Store 0.3.0, release candidate #1

2023-01-12 Thread Jingsong Li
- Checked the website updates: *OK* > > Best Regards, > Yu > > > On Thu, 12 Jan 2023 at 15:36, Jingsong Li wrote: > > > Thanks Yu for your validation. > > > > I created a new staging directory [1] > > > > [1] > > https://repository.apache.

Re: [VOTE] Apache Flink Table Store 0.3.0, release candidate #1

2023-01-11 Thread Jingsong Li
d, could you double > check and republish if necessary? Thanks. > > Best Regards, > Yu > > [1] https://repository.apache.org/content/repositories/orgapacheflink-1576/ > > > On Tue, 10 Jan 2023 at 16:53, Jingsong Li wrote: > > > Hi everyone, > >

[VOTE] Apache Flink Table Store 0.3.0, release candidate #1

2023-01-10 Thread Jingsong Li
Hi everyone, Please review and vote on the release candidate #1 for the version 0.3.0 of Apache Flink Table Store, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) **Release Overview** As an overview, the release consists of the

Re: [ANNOUNCE] New Apache Flink Committer - Lincoln Lee

2023-01-09 Thread Jingsong Li
Congratulations, Lincoln! Best, Jingsong On Tue, Jan 10, 2023 at 11:56 AM Leonard Xu wrote: > > Congratulations, Lincoln! > > Impressive work in streaming semantics, well deserved! > > > Best, > Leonard > > > > On Jan 10, 2023, at 11:52 AM, Jark Wu wrote: > > > > Hi everyone, > > > > On behalf

Re: [VOTE] FLIP-282: Introduce Delete & Update API

2023-01-09 Thread Jingsong Li
+1 binding On Mon, Jan 9, 2023 at 6:14 PM Samrat Deb wrote: > > +1 (non binding ) > > thank you for driving > > > > On Mon, 9 Jan 2023 at 3:36 PM, yuxia wrote: > > > Hi, all. > > > > I'd like to start a vote on FLIP-282: Introduce Delete & Update API[1]. > > You can find the discussion on it in

Re: [VOTE] FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-01-09 Thread Jingsong Li
+1 (binding) On Mon, Jan 9, 2023 at 6:19 PM Jane Chan wrote: > > Hi all, > > Thanks for all the feedback so far. > Based on the discussion[1], we have come to a consensus, so I would like to > start a vote on FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL > advice[2]. > > The vote will

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-06 Thread Jingsong Li
interface, which is different from implementing a custom connector/format. > > [1] > https://cwiki.apache.org/confluence/display/FLINK/FLIP-280%3A+Introduce+EXPLAIN+PLAN_ADVICE+to+provide+SQL+advice > [2] https://dev.mysql.com/doc/refman/8.0/en/explain.html#explain-analyze > [3] https:/

Re: [DISCUSS] FLIP-282: Introduce Delete & Update API

2023-01-05 Thread Jingsong Li
se without touching any other logic. If sources ignore this > method, it just works as normally. So I think there's > no necessary to add a new interface like SupportsXX. > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Jingsong Li" > 收件人: "dev"

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2023-01-03 Thread Jingsong Li
Thanks Jane for the FLIP! It looks very nice! Can you give examples of other systems for the syntax? In other systems, is EXPLAIN ANALYZE already PHYSICAL_PLAN? `EXPLAIN ANALYZED_PHYSICAL_PLAN ` looks a bit strange, and even stranger that it contains `advice`. The purpose of FLIP seems to be a

Re: [DISCUSS] Extending the feature freezing date of Flink 1.17

2023-01-03 Thread Jingsong Li
+1 On Tue, Jan 3, 2023 at 4:40 PM Matthias Pohl wrote: > > +1 for extending to Jan 31 > > On Tue, Jan 3, 2023 at 8:33 AM Yu Li wrote: > > > +1 for the proposal (extending the 1.17 feature freeze date to Jan 31st). > > > > Best Regards, > > Yu > > > > > > On Tue, 3 Jan 2023 at 15:11, Zhu Zhu

Re: [DISCUSS] FLIP-282: Introduce Delete & Update API

2023-01-02 Thread Jingsong Li
Thanks yuxia for the FLIP! It looks really good! I have three comments: ## RowLevelDeleteMode Can RowLevelDeleteMode be a higher level? `SupportsRowLevelDelete.RowLevelDeleteMode` is better than `SupportsRowLevelDelete.RowLevelDeleteInfo.RowLevelDeleteMode`. Same as `RowLevelUpdateMode`. ##

Re: [DISCUSSION] Scan mode in Table Store for Flink Stream and Batch job

2022-12-09 Thread Jingsong Li
estamp-millis, log.scan.timestamp-millis. Optional timestamp > used in case of \"from-timestamp\" scan mode. > b) read.compacted. Read the latest compact snapshots only. > > After discussing with @Jingsong Li and @Caizhi wen, we found that the config > in Options and St

Re: [DISCUSS] the bug with column lost comment

2022-12-07 Thread Jingsong Li
Hi, https://github.com/apache/flink/pull/21182 is being reviewed. You can take a look. Best, Jingsong On Wed, Dec 7, 2022 at 4:46 PM 黑猪 wrote: > > [DISCUSS] > i want to fix the bug with column lost comment,And I have some ideas, use > the new ResolvedSchema to be compatible with existing

Re: [VOTE] FLIP-273: Improve Catalog API to Support ALTER TABLE syntax

2022-11-30 Thread Jingsong Li
+1 (binding) Thanks Shengkai for driving this FLIP. Best, Jingsong On Thu, Dec 1, 2022 at 12:20 PM Shengkai Fang wrote: > > Hi All, > > Thanks for all the feedback so far. Based on the discussion[1] we seem > to have a consensus, so I would like to start a vote on FLIP-273. > > The vote will

Re: [ANNOUNCE] New Apache Flink PMC Members - Godfrey He, Xingbo Huang

2022-11-24 Thread Jingsong Li
Congrats, Godfrey and Xingbo! Best, Jingsong On Thu, Nov 24, 2022 at 4:03 PM Sergey Nuyanzin wrote: > > Congrats to both! > > On Thu, Nov 24, 2022 at 8:59 AM Yun Gao > wrote: > > > Congratulations Godfrey and Xingbo! > > Best, > > Yun Gao > >

  1   2   3   4   5   6   >