Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-30 Thread liu ron
+1 Best, Ron Xintong Song 于2023年7月27日周四 09:59写道: > I think we should add the release version when the FLIP is actually > released, in case of inconsistency. > > > Best, > > Xintong > > > > On Wed, Jul 26, 2023 at 9:48 PM Jing Ge > wrote: > > > +1 (binding) > > > > Please don't forget to

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Xintong Song
I think we should add the release version when the FLIP is actually released, in case of inconsistency. Best, Xintong On Wed, Jul 26, 2023 at 9:48 PM Jing Ge wrote: > +1 (binding) > > Please don't forget to update the release version to 2.0 in the FLIP. > > Best regards, > Jing > > On Wed,

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Jing Ge
+1 (binding) Please don't forget to update the release version to 2.0 in the FLIP. Best regards, Jing On Wed, Jul 26, 2023 at 5:49 PM Matthias Pohl wrote: > +1 (binding) > > On Wed, Jul 26, 2023 at 10:11 AM Yuxin Tan wrote: > > > +1 (non-binding) > > > > Best, > > Yuxin > > > > > > Xintong

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Matthias Pohl
+1 (binding) On Wed, Jul 26, 2023 at 10:11 AM Yuxin Tan wrote: > +1 (non-binding) > > Best, > Yuxin > > > Xintong Song 于2023年7月26日周三 16:08写道: > > > +1 (binding) > > > > Best, > > > > Xintong > > > > > > > > On Wed, Jul 26, 2023 at 3:35 PM Yuepeng Pan wrote: > > > > > +1 (non-binding) > > > >

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Yuxin Tan
+1 (non-binding) Best, Yuxin Xintong Song 于2023年7月26日周三 16:08写道: > +1 (binding) > > Best, > > Xintong > > > > On Wed, Jul 26, 2023 at 3:35 PM Yuepeng Pan wrote: > > > +1 (non-binding) > > > > Thanks. > > > > Yuepeng Pan. > > At 2023-07-26 14:26:04, "Wencong Liu" wrote: > > >Hi dev, > > > >

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Xintong Song
+1 (binding) Best, Xintong On Wed, Jul 26, 2023 at 3:35 PM Yuepeng Pan wrote: > +1 (non-binding) > > Thanks. > > Yuepeng Pan. > At 2023-07-26 14:26:04, "Wencong Liu" wrote: > >Hi dev, > > > > > >I'd like to start a vote on FLIP-343. > > > > > >Discussion thread: >

Re:[VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Yuepeng Pan
+1 (non-binding) Thanks. Yuepeng Pan. At 2023-07-26 14:26:04, "Wencong Liu" wrote: >Hi dev, > > >I'd like to start a vote on FLIP-343. > > >Discussion thread: >https://lists.apache.org/thread/zn11f460x70nn7f2ckqph41bvx416wxc >FLIP:

Re: [VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread weijie guo
+1 (binding) Best regards, Weijie Wencong Liu 于2023年7月26日周三 14:26写道: > Hi dev, > > > I'd like to start a vote on FLIP-343. > > > Discussion thread: > https://lists.apache.org/thread/zn11f460x70nn7f2ckqph41bvx416wxc > FLIP: >

[VOTE][2.0] FLIP-343: Remove parameter in WindowAssigner#getDefaultTrigger()

2023-07-26 Thread Wencong Liu
Hi dev, I'd like to start a vote on FLIP-343. Discussion thread: https://lists.apache.org/thread/zn11f460x70nn7f2ckqph41bvx416wxc FLIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=263425229 Best regards, Wencong Liu