+1, make sense.
Best,
Ron
Wencong Liu 于2023年7月27日周四 09:47写道:
> Hi Matthias,
>
> Thanks for your reply. Due to my busy work reasons, I would like to focus
> only on
> the `Path` class in FLIP-347 for now. As for the implementation of other
> modules,
> I will review them when I have available
Correct. I don't have the intention to block this FLIP if it's too much
effort to expand it. Sorry if that's the message that came across.
On Wed, Jul 26, 2023 at 12:17 PM Xintong Song wrote:
> I think it worth looking into all implementations of IOReadeableWritable.
> However, I would not
I think it worth looking into all implementations of IOReadeableWritable.
However, I would not consider that as a concern of this FLIP.
An important convention of the open-source community is volunteer work. If
Wencong only wants to work on the `Path` case, I think he should not be
asked to
Is the time constraint driven by the fact that you wanted to have that
effort being included in 1.18? If so, it looks like that's not possible
based on the decision being made for 1.18 to only allow document changes
[1]. So, there would be actually time to look into it. WDYT?
[1]
+1
Best,
Junrui
Jing Ge 于2023年7月24日周一 23:28写道:
> agree, since we want to try our best to deprecate APIs in 1.18, it makes
> sense.
>
>
> Best regards,
> Jing
>
> On Mon, Jul 24, 2023 at 12:11 PM Wencong Liu wrote:
>
> > Hi Jing and Matthias,
> >
> >
> > I believe it is reasonable to
agree, since we want to try our best to deprecate APIs in 1.18, it makes
sense.
Best regards,
Jing
On Mon, Jul 24, 2023 at 12:11 PM Wencong Liu wrote:
> Hi Jing and Matthias,
>
>
> I believe it is reasonable to examine all classes that implement the
> IOReadableWritable
> interface and