Re: Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15239/ --- (Updated Nov. 5, 2013, 7:42 p.m.) Review request for Flume. Changes ---

[jira] [Updated] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-2233: Attachment: FLUME-2233.patch MemoryChannel lock contention on every put due to

Re: Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Roshan Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15239/#review28209 --- Hari, were you able to take any measurements on how much perf

Re: Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan
On Nov. 5, 2013, 8 p.m., Roshan Naik wrote: Hari, were you able to take any measurements on how much perf improvement this change made ? No, not really. I really did not hit this issue myself - we had a customer run into this issue when they were running with 0 keep-alive. - Hari

[jira] [Commented] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814212#comment-13814212 ] Roshan Naik commented on FLUME-2233: Rather than optionally disabling the semaphore, i

Re: Review Request 15239: FLUME-2233. MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15239/ --- (Updated Nov. 5, 2013, 8:06 p.m.) Review request for Flume. Bugs: FLUME-2233

[jira] [Commented] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814217#comment-13814217 ] Hari Shreedharan commented on FLUME-2233: - That was my initial thought - to do

[jira] [Updated] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-2233: Attachment: FLUME-2233.patch Also note that I am not married to this approach. If other

[jira] [Commented] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814251#comment-13814251 ] Roshan Naik commented on FLUME-2233: ok. I think the byteCapacityBufferPercentage can

[jira] [Commented] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814258#comment-13814258 ] Hari Shreedharan commented on FLUME-2233: - Note sure what you mean? Are you

Re: Review Request 15107: Moving BlobHandler out of morphline sink and into HTTP source

2013-11-05 Thread Roshan Naik
On Nov. 5, 2013, 1:47 a.m., Wolfgang Hoschek wrote: flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobHandler.java, line 43 https://reviews.apache.org/r/15107/diff/1-2/?file=374518#file374518line43 realBlobHandler seems obsolete

Re: Review Request 15107: Moving BlobHandler out of morphline sink and into HTTP source

2013-11-05 Thread Roshan Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15107/ --- (Updated Nov. 5, 2013, 9:21 p.m.) Review request for Flume. Changes ---

[jira] [Updated] (FLUME-2226) Refactor BlobHandler out of morphline sink and into HTTP source

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roshan Naik updated FLUME-2226: --- Attachment: FLUME-2226.3.patch Refactor BlobHandler out of morphline sink and into HTTP source

[jira] [Commented] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814280#comment-13814280 ] Roshan Naik commented on FLUME-2233: Yes, kind of.. i was thinking

[jira] [Commented] (FLUME-1227) Introduce some sort of SpillableChannel

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814292#comment-13814292 ] Roshan Naik commented on FLUME-1227: [~hshreedharan] , all the review comments should

[jira] [Commented] (FLUME-2065) Regex Extractor Interceptor config agent name inconsistent with rest of docs

2013-11-05 Thread Roshan Naik (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814324#comment-13814324 ] Roshan Naik commented on FLUME-2065: will be happy to commit this.. but will need you

[jira] [Updated] (FLUME-2233) MemoryChannel lock contention on every put due to bytesRemaining Semaphore

2013-11-05 Thread Hari Shreedharan (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hari Shreedharan updated FLUME-2233: Attachment: FLUME-2233.patch Moving the semaphore update to commit. This should improve

[jira] [Commented] (FLUME-1488) Load Balancing RPC client should support exponential backoff of failed nodes

2013-11-05 Thread Eugene Koontz (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814404#comment-13814404 ] Eugene Koontz commented on FLUME-1488: -- FLUME-2229 fixes a bug in FLUME-1488. Load

Re: Review Request 15163: FLUME-2217 Preserve priority, timestamp and hostname fields in MultiportSyslogTcp, SyslogTcp and Udp sources

2013-11-05 Thread Jeff jlord
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15163/ --- (Updated Nov. 6, 2013, 1:49 a.m.) Review request for Flume, Hari Shreedharan

[jira] [Updated] (FLUME-2217) Preserve priority, timestamp and hostname fields in MultiportSyslogTcp and Udp sources

2013-11-05 Thread Jeff Lord (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Lord updated FLUME-2217: - Attachment: FLUME-2217.3.patch Removed baosRaw and extra byte array. Modified the initial parsing to

[jira] [Created] (FLUME-2234) Accumulo Sink

2013-11-05 Thread Matt Molek (JIRA)
Matt Molek created FLUME-2234: - Summary: Accumulo Sink Key: FLUME-2234 URL: https://issues.apache.org/jira/browse/FLUME-2234 Project: Flume Issue Type: New Feature Components:

[jira] [Updated] (FLUME-2234) Accumulo Sink

2013-11-05 Thread Matt Molek (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Molek updated FLUME-2234: -- Attachment: FLUME-2234-0.patch Accumulo Sink - Key: FLUME-2234

[jira] [Commented] (FLUME-2065) Regex Extractor Interceptor config agent name inconsistent with rest of docs

2013-11-05 Thread Ashish Paliwal (JIRA)
[ https://issues.apache.org/jira/browse/FLUME-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814588#comment-13814588 ] Ashish Paliwal commented on FLUME-2065: --- Individual patch is already there. The only