Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-28 Thread Mike Percy
On Nov. 28, 2012, 2:54 a.m., Mike Percy wrote: Looks good! Please make the following changes and then attach the patch to the JIRA: * Rename ackEveryEvent to ack-every-event to remain consistent with the existing elements. Even though we have agreed to make all new properties

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-28 Thread Rahul Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/ --- (Updated Nov. 28, 2012, 9:02 p.m.) Review request for Flume. Changes ---

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-28 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/#review13845 --- Ship it! Ship It! - Mike Percy On Nov. 28, 2012, 9:02 p.m.,

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-27 Thread Mike Percy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/#review13797 --- Ship it! Looks good! Please make the following changes and then

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-27 Thread Rahul Ravindran
On Nov. 28, 2012, 2:54 a.m., Mike Percy wrote: Looks good! Please make the following changes and then attach the patch to the JIRA: * Rename ackEveryEvent to ack-every-event to remain consistent with the existing elements. Even though we have agreed to make all new properties

Review Request: FLUME-1713 Netcat source to not return OK

2012-11-25 Thread Rahul Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/ --- Review request for Flume. Description --- FLUME-1713 Netcat source should

Re: Review Request: FLUME-1713 Netcat source to not return OK

2012-11-25 Thread Rahul Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8220/ --- (Updated Nov. 26, 2012, 2:24 a.m.) Review request for Flume. Description