[jira] [Created] (HBASE-26763) Setback occurs to AsyncFSWAL#highestProcessedAppendTxid and then IllegalArgumentException

2022-02-20 Thread Xiaolin Ha (Jira)
Xiaolin Ha created HBASE-26763: -- Summary: Setback occurs to AsyncFSWAL#highestProcessedAppendTxid and then IllegalArgumentException Key: HBASE-26763 URL: https://issues.apache.org/jira/browse/HBASE-26763

Re: Slack channel request

2022-02-20 Thread Duo Zhang
Invitation sent. Li, Dong 于2022年2月21日周一 06:59写道: > Hey Duo, > > Thx for your update, here is the email: > > alexdongli0...@gmail.com > > > BR > > > Sent from my iPhone > > > On Feb 19, 2022, at 11:03 PM, 张铎(Duo Zhang) > wrote: > > > > CAUTION: This email originated from outside of the

Re: [DISCUSS] deprecating jdk8, progress on LTS jdk support

2022-02-20 Thread Duo Zhang
I know, with —release 8 ByteBuffer will not be an problem but then sun.misc.Unsafe can not be used any more right? So the problem here is how to make use of Unsafe with —release 8. What I proposed here is that we just do not use it, then we can make use of —release 8 to address the ByteBuffer

Re: Slack channel request

2022-02-20 Thread Li, Dong
Hey Duo, Thx for your update, here is the email: alexdongli0...@gmail.com BR Sent from my iPhone > On Feb 19, 2022, at 11:03 PM, 张铎(Duo Zhang) wrote: > > CAUTION: This email originated from outside of the organization. Do not > click links or open attachments unless you can confirm the

Re: [DISCUSS] deprecating jdk8, progress on LTS jdk support

2022-02-20 Thread Andrew Purtell
The problem that leads us to consider '--release 8', or what it would promise if it worked, isn't Unsafe, it is ByteBuffer. https://www.morling.dev/blog/bytebuffer-and-the-dreaded-nosuchmethoderror/ . Although to your point Netty has ByteBuf... On Sun, Feb 20, 2022 at 5:23 AM 张铎(Duo Zhang)

Re: Deprecation of Scan#setRowPrefixFilter ?

2022-02-20 Thread Niels Basjes
Hi, I have updated my pull request as discussed. https://github.com/apache/hbase/pull/4119 Niels On Sun, Feb 20, 2022 at 3:12 PM 张铎(Duo Zhang) wrote: > Niels Basjes 于2022年2月20日周日 22:06写道: > > > Hi, > > > > Ok, a rename of the method to avoid confusion is fine with me. > > I suspect

Re: Deprecation of Scan#setRowPrefixFilter ?

2022-02-20 Thread Duo Zhang
Niels Basjes 于2022年2月20日周日 22:06写道: > Hi, > > Ok, a rename of the method to avoid confusion is fine with me. > I suspect people will find the setPrefixScan suggestion also too confusing. > How about setStartStopRowForPrefixScan ? > +1 > > Niels > > > > > > On Sun, Feb 20, 2022 at 12:45 PM

Re: Deprecation of Scan#setRowPrefixFilter ?

2022-02-20 Thread Niels Basjes
Hi, Ok, a rename of the method to avoid confusion is fine with me. I suspect people will find the setPrefixScan suggestion also too confusing. How about setStartStopRowForPrefixScan ? Niels On Sun, Feb 20, 2022 at 12:45 PM 张铎(Duo Zhang) wrote: > I think the name is a bit confusing, the

Re: [DISCUSS] deprecating jdk8, progress on LTS jdk support

2022-02-20 Thread Duo Zhang
Since we have shaded netty, I think we could make use of netty's PlatformDependent[1] class to avoid referencing Unsafe directly, then there will be no problem for us to use the '--release 8' option. If no big concerns, I will file an issue to remove all the sun.misc.Unsafe references in our code

[NOTICE] ci-hbase is broken

2022-02-20 Thread Duo Zhang
All build nodes are offline, so nightly and pre commit builds both can not be executed. Filed INFRA-22908 for it. Will report back once it comes back online. Thanks.

Re: [DISCUSS] operator tools, HBase 3 and StoreFileTracking

2022-02-20 Thread Duo Zhang
Sorry a bit late... IIRC, the design of HBCK2 is that, most of the actual fix logic should be done inside hbase(usually as a procedure), and the hbase-operator-tools is just a facade for calling these methods. It will query the cluster to find out which features are supportted. So in general, the

Re: Deprecation of Scan#setRowPrefixFilter ?

2022-02-20 Thread Duo Zhang
I think the name is a bit confusing, the name says it is a filter but actually it will change the start and stop row. So I prefer we deprecate the current setRowPrefixFilter and introduce a new method which has the same logic of the current method, maybe called setPrefixScan? Thanks. Niels