Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-26 Thread Duo Zhang
I think we have consensus here that we should set fix version to 2.5.0 only if the patch has been committed to both branch-2 and branch-2.5. And I think the solution to cleanup the incorrect fix versions also works. Thanks Nick. And thanks all for chiming in. Andrew Purtell 于2022年3月22日周二

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-21 Thread Andrew Purtell
I think the sanest policy is — lowest released first —. So if released in 2.4.11, then that’s all we need, for .0 versions. 2.5.0 changelog will be based on that of 2.4.11 or later. 2.6.0 changelog will be based on 2.5.0 or later. It all rolls up. When committing to releasing code lines we

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-21 Thread Nick Dimiduk
So for example, if I apply a patch to master, branch-2, branch-2.5, and branch-2.4, I should only set its fixFor version to 2.4.x and 2.5.0, because 2.6.0 is assumed by 2.5.0 and 3.0.0 is assumed by 2.6.0 ? On Mon, Mar 21, 2022 at 3:59 PM Andrew Purtell wrote: > I have used JQL searches and git

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-21 Thread Andrew Purtell
I have used JQL searches and git log inspection previously but will be trying out our git-jira-release-audit tool this time. After populating the local DB from git and JIRA for the three respective versions, SQL query against the generated SQLite file should be convenient. > > On Mar 21,

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-21 Thread Nick Dimiduk
I have also been doing as Andrew, whether it is the right thing or not. I think Duo is correct in that until 2.5.0, a commit to both branch-2.5 and branch-2 should only be marked as 2.5.0. This should be easy enough to fix -- once 2.5.0 is released, we can search Jira for all issues with

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-20 Thread Andrew Purtell
Per the earlier discussion, to be comprehensive, there is also this rule: 4. If a change is in branch-2.4, branch-2.5, and branch-2: fix version = 2.4.x, the version the change was released in. (Fix versions 2.5.0 and 2.6.0 will be dropped for already released changes.) The 2.5.0 change log

Re: [DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-20 Thread Andrew Purtell
I have been setting both but don’t claim that is correct. This is partly my fault for pushing back 2.5.0 for about six months since cutting the branch. Partly this was waiting for always the next thing to squeeze in, and partly life and work obligations getting in the way. I am actually

[DISCUSS] On setting fix versions with both 2.5.0 and 2.6.0

2022-03-20 Thread Duo Zhang
Recently I've seen we set both 2.5.0 and 2.6.0 as fix versions for some issues. But from my understanding, I always choose to only set 2.5.0 as fix versions if the patch has been committed to both branch-2 and branch-2.5. The assumption is that all issues resolved in 2.5.0 should also be included