[GitHub] helix pull request #297: ZkClient related improvments

2019-01-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/297 ---

[GitHub] helix pull request #297: ZkClient related improvments

2019-01-25 Thread jiajunwang
Github user jiajunwang commented on a diff in the pull request: https://github.com/apache/helix/pull/297#discussion_r251134740 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkConnection.java --- @@ -84,6 +83,25 @@ public void close() throws

[GitHub] helix pull request #297: ZkClient related improvments

2019-01-24 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/297#discussion_r250807912 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkConnection.java --- @@ -84,6 +83,25 @@ public void close() throws

[GitHub] helix pull request #297: ZkClient related improvments

2019-01-24 Thread lei-xia
Github user lei-xia commented on a diff in the pull request: https://github.com/apache/helix/pull/297#discussion_r250795524 --- Diff: helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java --- @@ -674,12 +684,24 @@ public void handleChildChange(String

[GitHub] helix pull request #297: ZkClient related improvments

2019-01-11 Thread jiajunwang
GitHub user jiajunwang opened a pull request: https://github.com/apache/helix/pull/297 ZkClient related improvments We identify 2 potential issues that may cause a retrying ZK operation failed unexpectedly. These commits fix the problem. You can merge this pull request into a Git