Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-05 Thread Marion Christophe JAILLET
Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead? 'connect_to_peer' is called only in one place with module_index=APLOG_MODULE_INDEX - Do things like

Re: svn commit: 1573360 - SSLPassPhraseDialog arguments changed in 2.4.x

2014-04-05 Thread Kaspar Brand
On 04.04.2014 12:22, Jan Kaluža wrote: commit 1553824 (1573360 in 2.4.x) breaks the compatibility in arguments passed to exec:/path/to/program pass phrase program. This should be clear from the following part of mentioned commit(s): -argv[1] = cpVHostID; -argv[2] =

Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS

2014-04-05 Thread Jeff Trawick
First, thanks for looking! On Sat, Apr 5, 2014 at 2:24 AM, Marion Christophe JAILLET christophe.jail...@wanadoo.fr wrote: Hi, I've gone quickly thru the module and I have a few remarks: - What is the use of FN_LOG_MARK on line 87? Couldn't we use APLOG_MARK instead?

Re: svn commit: r1584417 - in /httpd/httpd/trunk: docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c

2014-04-05 Thread Eric Covener
Thanks to both of you for reviews. I added a flag in 1585157 that controls how it handles ' ' in both paths. I also renamed the little stack method since this is the only caller. On Fri, Apr 4, 2014 at 8:13 AM, Yann Ylavic ylavic@gmail.com wrote: On Fri, Apr 4, 2014 at 1:15 PM, Eric

Where to find the unistd.h header for Apache 2.4.7??

2014-04-05 Thread Miguel Villarreal
Miguel Antonio

Re: Where to find the unistd.h header for Apache 2.4.7??

2014-04-05 Thread Mario Brandt
it should be included in your distro if you use linux or unix. 2014-04-05 21:01 GMT+02:00 Miguel Villarreal miguel_villarrea...@hotmail.com: Miguel Antonio

Re: Where to find the unistd.h header for Apache 2.4.7??

2014-04-05 Thread Reindl Harald
to be more precise it is part of glibc [builduser@testserver:~]$ rpm -q --file /usr/include/unistd.h glibc-headers-2.18-13.fc20.x86_64 Am 05.04.2014 21:33, schrieb Mario Brandt: it should be included in your distro if you use linux or unix signature.asc Description: OpenPGP digital

Is there any way to get all the neede headers to compile mod_log_config with apxs????

2014-04-05 Thread Miguel Villarreal
Hello. Is it possible to get the needed headers to compile the the mod_log_config module at once. It is a kind of difficult to know all the headers needed for that. Each time a get a header, that header includes a bunch of additional headers. Please, let me know Miguel Antonio

Re: Is there any way to get all the neede headers to compile mod_log_config with apxs????

2014-04-05 Thread Eric Covener
On Sat, Apr 5, 2014 at 3:46 PM, Miguel Villarreal miguel_villarrea...@hotmail.com wrote: Hello. Is it possible to get the needed headers to compile the the mod_log_config module at once. It is a kind of difficult to know all the headers needed for that. Each time a get a header, that header

Re: Is there any way to get all the neede headers to compile mod_log_config with apxs????

2014-04-05 Thread Jeff Trawick
On Sat, Apr 5, 2014 at 3:46 PM, Miguel Villarreal miguel_villarrea...@hotmail.com wrote: Hello. Is it possible to get the needed headers to compile the the mod_log_config module at once. It is a kind of difficult to know all the headers needed for that. Each time a get a header, that header