Re: [DISCUSS] Rename iceberg-hive module?

2020-09-03 Thread Mass Dosage
I have raised a PR for this: https://github.com/apache/iceberg/pull/1418 Please take a look and comment. Thanks, Adrian On Thu, 20 Aug 2020 at 17:30, Ryan Blue wrote: > Sounds unanimous. Thanks, everyone! > > On Thu, Aug 20, 2020 at 9:10 AM John Zhuge wrote: > >> +1 for the rename >> >> On

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-20 Thread Ryan Blue
Sounds unanimous. Thanks, everyone! On Thu, Aug 20, 2020 at 9:10 AM John Zhuge wrote: > +1 for the rename > > On Thu, Aug 20, 2020 at 7:22 AM Junjie Chen > wrote: > >> +1 for `iceberg-hive-metastore`, also +1 to have a new module to contain >> the `iceberg-mr`. >> >> On Thu, Aug 20, 2020 at

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-20 Thread John Zhuge
+1 for the rename On Thu, Aug 20, 2020 at 7:22 AM Junjie Chen wrote: > +1 for `iceberg-hive-metastore`, also +1 to have a new module to contain > the `iceberg-mr`. > > On Thu, Aug 20, 2020 at 8:13 PM Saisai Shao > wrote: > >> +1 for the changes. >> >> Mass Dosage 于2020年8月20日周四 下午5:46写道： >>

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-20 Thread Junjie Chen
+1 for `iceberg-hive-metastore`, also +1 to have a new module to contain the `iceberg-mr`. On Thu, Aug 20, 2020 at 8:13 PM Saisai Shao wrote: > +1 for the changes. > > Mass Dosage 于2020年8月20日周四 下午5:46写道： > >> +1 for `iceberg-hive-metastore` as I found this confusing when I first >> started

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-20 Thread Saisai Shao
+1 for the changes. Mass Dosage 于2020年8月20日周四 下午5:46写道： > +1 for `iceberg-hive-metastore` as I found this confusing when I first > started working with the code. > > On Thu, 20 Aug 2020 at 03:27, Jungtaek Lim > wrote: > >> +1 for `iceberg-hive-metastore` and also +1 for RD's proposal. >> >>

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-20 Thread Mass Dosage
+1 for `iceberg-hive-metastore` as I found this confusing when I first started working with the code. On Thu, 20 Aug 2020 at 03:27, Jungtaek Lim wrote: > +1 for `iceberg-hive-metastore` and also +1 for RD's proposal. > > Thanks, > Jungtaek Lim (HeartSaVioR) > > > > On Thu, Aug 20, 2020 at 11:20

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-19 Thread Jungtaek Lim
+1 for `iceberg-hive-metastore` and also +1 for RD's proposal. Thanks, Jungtaek Lim (HeartSaVioR) On Thu, Aug 20, 2020 at 11:20 AM Jingsong Li wrote: > +1 for `iceberg-hive-metastore` > > I'm confused about `iceberg-hive` and `iceberg-mr`. > > Best, > Jingsong > > On Thu, Aug 20, 2020 at

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-19 Thread Jingsong Li
+1 for `iceberg-hive-metastore` I'm confused about `iceberg-hive` and `iceberg-mr`. Best, Jingsong On Thu, Aug 20, 2020 at 9:48 AM Dongjoon Hyun wrote: > +1 for `iceberg-hive-metastore`. > > Maybe, is `Apache Iceberg 1.0.0` a good candidate to have that breaking > change? > > Bests, >

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-19 Thread Dongjoon Hyun
+1 for `iceberg-hive-metastore`. Maybe, is `Apache Iceberg 1.0.0` a good candidate to have that breaking change? Bests, Dongjoon. On Wed, Aug 19, 2020 at 6:35 PM RD wrote: > I'm +1 for this rename. I think we should keep the iceberg-mr module as > is and maybe add a new module

Re: [DISCUSS] Rename iceberg-hive module?

2020-08-19 Thread RD
I'm +1 for this rename. I think we should keep the iceberg-mr module as is and maybe add a new module iceberg-hive-exec [not sure if it is a good idea to salvage iceberg-hive for this purpose] which contains hive specific StorageHandler, Serde and IcebergHivInputFormat classes. -R On Wed, Aug

[DISCUSS] Rename iceberg-hive module?

2020-08-19 Thread Ryan Blue
In the discussion this morning, we talked about what to name the runtime module we want to add for Hive, iceberg-hive-runtime. Unfortunately, iceberg-hive is the Hive _metastore_ module, so it is a bit misleading to name the Hive runtime module iceberg-hive-runtime. It was also pointed out that