Re: NoopSwapSpaceSpi and dynamically started caches

Hello. Patch for https://issues.apache.org/jira/browse/IGNITE-2650 is available. Please review. On Thu, Feb 18, 2016 at 2:10 PM, Konstantin Margorin wrote: > Yakov, thank you. Sounds good. I'll do this way. > > On Thu, Feb 18, 2016 at 1:43 PM, Yakov Zhdanov

Re: NoopSwapSpaceSpi and dynamically started caches

Yakov, thank you. Sounds good. I'll do this way. On Thu, Feb 18, 2016 at 1:43 PM, Yakov Zhdanov wrote: > Konstantin, > > Here are my comments. > > 1. I would force same swap configuration on all servers. Therefore, I would > add "checkClient" attribute to annotation which

Re: NoopSwapSpaceSpi and dynamically started caches

Konstantin, Here are my comments. 1. I would force same swap configuration on all servers. Therefore, I would add "checkClient" attribute to annotation which is "true" by default 2. I think all users should properly configure swap along the cluster if they want to handle possible memory

Re: NoopSwapSpaceSpi and dynamically started caches

Hi all. Sorry for asking again, but after some experiments I want to discuss several options for grid swap policy. Some of them have odd side effects. It's better to explicitly write them down to select the best solution. 1. Strict policy. - @IgniteSpiConsistencyChecked(optional = false) used in

Re: NoopSwapSpaceSpi and dynamically started caches

I think, yes --Yakov 2016-02-16 14:19 GMT+03:00 Konstantin Margorin : > Should we use optional=false in @IgniteSpiConsistencyChecked ? > > On Tue, Feb 16, 2016 at 1:15 PM, Dmitriy Setrakyan > wrote: > > > Sounds good to me. > > > > On Tue, Feb 16, 2016

Re: NoopSwapSpaceSpi and dynamically started caches

Should we use optional=false in @IgniteSpiConsistencyChecked ? On Tue, Feb 16, 2016 at 1:15 PM, Dmitriy Setrakyan wrote: > Sounds good to me. > > On Tue, Feb 16, 2016 at 2:13 AM, Yakov Zhdanov > wrote: > > > Let's require that all nodes should have

Re: NoopSwapSpaceSpi and dynamically started caches

Sounds good to me. On Tue, Feb 16, 2016 at 2:13 AM, Yakov Zhdanov wrote: > Let's require that all nodes should have same swap space SPI. I think we > can put @GridSpiConsistencyChecked on file swap space SPI (any other > suggestions?). > > --Yakov > > 2016-02-15 23:31

Re: NoopSwapSpaceSpi and dynamically started caches

Let's require that all nodes should have same swap space SPI. I think we can put @GridSpiConsistencyChecked on file swap space SPI (any other suggestions?). --Yakov 2016-02-15 23:31 GMT+03:00 Konstantin Margorin : > Probably I can handle this ticket, but I want to clarify one

Re: NoopSwapSpaceSpi and dynamically started caches

Probably I can handle this ticket, but I want to clarify one thing. Suppose dynamic cache with enabled swap should be partitioned between two nodes with backups=1. First node started with FileSwapSpaceSpi, second with NoopSwapSpaceSpi. How cache should start in this case? On Mon, Feb 15, 2016

Re: NoopSwapSpaceSpi and dynamically started caches

I've created a newbie issue for that: https://issues.apache.org/jira/browse/IGNITE-2650. -- Artem -- On Wed, Feb 10, 2016 at 8:53 PM, Dmitriy Setrakyan wrote: > Artem, > > I like the option with proper exception in case if a dynamic cache is > started with swap enabled

Re: NoopSwapSpaceSpi and dynamically started caches

Artem, I like the option with proper exception in case if a dynamic cache is started with swap enabled while there was no swap configured in Ignite. Starting FileSwapSpaceSpi all the time is not a good option as user will face the same problem when trying to change to a different SPI. D. On

NoopSwapSpaceSpi and dynamically started caches

Igniters, I've noticed an issue with NoopSwapSpaceSpi and dynamically started cashes. We have the following logic on node start: if (cfg.getSwapSpaceSpi() == null) { boolean needSwap = false; if (cfg.getCacheConfiguration() != null &&