[jira] [Commented] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-22 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14069899#comment-14069899 ] Dmitry Bugaychenko commented on KAFKA-1539: --- Going to test power failure again

[jira] [Commented] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-22 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070274#comment-14070274 ] Dmitry Bugaychenko commented on KAFKA-1539: --- With fileOutputStream.getFD.sync()

[jira] [Updated] (KAFKA-1539) Due to OS caching Kafka might loose offset files which causes full reset of data

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1539: - Fix Version/s: 0.8.2 Due to OS caching Kafka might loose offset files which causes full reset of data

[jira] [Updated] (KAFKA-1535) return all live brokers in TopicMetadataResponse

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1535: - Affects Version/s: (was: 0.8.2) 0.8.1.1 Fix Version/s: 0.8.2 return

[jira] [Updated] (KAFKA-1519) Console consumer: expose configuration option to enable/disable writing the line separator

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1519: - Fix Version/s: 0.8.2 Console consumer: expose configuration option to enable/disable writing the line

[jira] [Updated] (KAFKA-1512) Limit the maximum number of connections per ip address

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1512: - Fix Version/s: 0.8.2 Limit the maximum number of connections per ip address

[jira] [Updated] (KAFKA-1298) Controlled shutdown tool doesn't seem to work out of the box

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1298: - Fix Version/s: 0.8.2 Controlled shutdown tool doesn't seem to work out of the box

[jira] [Updated] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1491: - Fix Version/s: 0.8.2 ConsumerMetadataResponse is not read completely

[jira] [Updated] (KAFKA-1316) Refactor Sender

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1316: - Fix Version/s: 0.8.2 Refactor Sender --- Key: KAFKA-1316

[jira] [Updated] (KAFKA-1443) Add delete topic to topic commands and update DeleteTopicCommand

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1443: - Fix Version/s: 0.8.2 Add delete topic to topic commands and update DeleteTopicCommand

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1469: - Fix Version/s: 0.8.2 Util.abs function does not return correct absolute values for negative values

[jira] [Updated] (KAFKA-1300) Added WaitForReplaction admin tool.

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1300: - Fix Version/s: (was: 0.8.1) 0.8.2 Added WaitForReplaction admin tool.

[jira] [Updated] (KAFKA-1444) kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString method

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1444: - Fix Version/s: 0.8.2 kafka.javaapi.TopicMetadata and PartitionMetadata doesn't forward the toString

[jira] [Updated] (KAFKA-1238) New producer hangs in a loop detecting metadata for auto created topics

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1238: - Fix Version/s: 0.8.2 New producer hangs in a loop detecting metadata for auto created topics

[jira] [Updated] (KAFKA-1328) Add new consumer APIs

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1328: - Fix Version/s: 0.8.2 Add new consumer APIs - Key: KAFKA-1328

[jira] [Updated] (KAFKA-1431) ConsoleConsumer - Option to clean zk consumer path

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1431: - Fix Version/s: 0.8.2 ConsoleConsumer - Option to clean zk consumer path

[jira] [Updated] (KAFKA-1425) provide logStartOffset in addition to LogEndOffset metric

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1425: - Fix Version/s: 0.8.2 provide logStartOffset in addition to LogEndOffset metric

[jira] [Updated] (KAFKA-1189) kafka-server-stop.sh doesn't stop broker

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1189: - Fix Version/s: 0.8.2 kafka-server-stop.sh doesn't stop broker

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Manikumar Reddy O
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165 Would key also be null possibly? This line is surrounded by if(msg.hasKey) check. msg.hasKey

[GitHub] kafka pull request: Clarify log deletion configuration options in ...

2014-07-22 Thread MarkRose
GitHub user MarkRose opened a pull request: https://github.com/apache/kafka/pull/27 Clarify log deletion configuration options in server.properties I spent a bit of time tracking down why files were being deleted before they reached log.retention.hours of age. It turns out that the

[GitHub] kafka pull request: Clarify log expiry configuration options (for ...

2014-07-22 Thread MarkRose
GitHub user MarkRose opened a pull request: https://github.com/apache/kafka/pull/28 Clarify log expiry configuration options (for trunk) I spent a bit of time tracking down why files were being deleted before they reached log.retention.hours of age. It turns out that the time and

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Guozhang Wang
On July 21, 2014, 6:16 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/DumpLogSegments.scala, line 165 https://reviews.apache.org/r/23705/diff/3/?file=636778#file636778line165 Would key also be null possibly? Manikumar Reddy O wrote: This line is surrounded by

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070489#comment-14070489 ] Anton Karamanov commented on KAFKA-1414: Here are some measurements for 4 disks,

Re: Review Request 23767: Fix KAFKA-1430

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23767/#review48283 --- Thanks for the patch. There are some unused imports. Detailed

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070542#comment-14070542 ] Jay Kreps commented on KAFKA-1414: -- Cool, that is a great speed-up either way. I'm fine

Re: Review Request 23339: Patch for KAFKA-1507

2014-07-22 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/ --- (Updated July 22, 2014, 5:27 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-07-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1507: -- Attachment: KAFKA-1507_2014-07-22_10:27:45.patch Using GetOffsetShell against

[jira] [Commented] (KAFKA-1507) Using GetOffsetShell against non-existent topic creates the topic unintentionally

2014-07-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070551#comment-14070551 ] Sriharsha Chintalapani commented on KAFKA-1507: --- Updated reviewboard

[jira] [Updated] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-1414: - Fix Version/s: 0.8.2 Speedup broker startup after hard reset ---

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070555#comment-14070555 ] Dmitry Bugaychenko commented on KAFKA-1414: --- We would prefer the second

[jira] [Commented] (KAFKA-1462) Add new request and response formats for the new consumer and coordinator communication

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070585#comment-14070585 ] Jun Rao commented on KAFKA-1462: Thanks for the reviews. Committed the followup patch.

[jira] [Updated] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1550: Description: 1) kafka-patch-review.py uses git-diff to generate patch for jira ticket. The resulting

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-07-22 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070630#comment-14070630 ] Neha Narkhede commented on KAFKA-1476: -- Thanks for the updated patch

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070634#comment-14070634 ] Anton Karamanov commented on KAFKA-1414: Second approach seems fine to me as well.

[jira] [Comment Edited] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Anton Karamanov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070634#comment-14070634 ] Anton Karamanov edited comment on KAFKA-1414 at 7/22/14 6:26 PM:

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Dmitry Bugaychenko (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070642#comment-14070642 ] Dmitry Bugaychenko commented on KAFKA-1414: --- data dir and log dir seems more

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/#review48392 --- Looks good. Thanks for improving our tools. I have a minor comment.

Re: Review Request 23655: Patch for KAFKA-687

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23655/#review48165 --- core/src/main/scala/kafka/consumer/ConsumerConfig.scala

Re: Review Request 23702: Patch for KAFKA-1070

2014-07-22 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23702/ --- (Updated July 22, 2014, 6:34 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1070) Auto-assign node id

2014-07-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1070: -- Attachment: KAFKA-1070_2014-07-22_11:34:18.patch Auto-assign node id

[jira] [Commented] (KAFKA-1070) Auto-assign node id

2014-07-22 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070658#comment-14070658 ] Sriharsha Chintalapani commented on KAFKA-1070: --- Updated reviewboard

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Dong Lin
On July 22, 2014, 6:30 p.m., Neha Narkhede wrote: kafka-patch-review.py, line 120 https://reviews.apache.org/r/23692/diff/1/?file=635684#file635684line120 formatted patch is a little misleading and is a git specific command. diff is easier to understand. So I'd recommend we keep

[jira] [Created] (KAFKA-1555) provide strong consistency with reasonable availability

2014-07-22 Thread Jiang Wu (JIRA)
Jiang Wu created KAFKA-1555: --- Summary: provide strong consistency with reasonable availability Key: KAFKA-1555 URL: https://issues.apache.org/jira/browse/KAFKA-1555 Project: Kafka Issue Type:

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/ --- (Updated July 22, 2014, 6:41 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1550: Attachment: KAFKA-1550_2014-07-22_11:41:57.patch Patch review tool should use git format-patch to

Re: Review Request 23339: Patch for KAFKA-1507

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23339/#review48397 --- Thanks for the patch and doing the rebasing. Some comments below.

Re: [DISCUSS] Kafka Security Specific Features

2014-07-22 Thread Pramod Deshmukh
Anyone getting this issue. Is it something related to environment or it is the code. Producer works fine when run with secure=false (no security) mode. pdeshmukh$ bin/kafka-console-producer.sh --broker-list localhost:9092:true --topic secureTopic [2014-07-18 13:12:29,817] WARN Property topic is

[jira] [Commented] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-22 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070751#comment-14070751 ] nicu marasoiu commented on KAFKA-1549: -- [~jkreps] [~junrao] Hi, can you help me

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-22 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070756#comment-14070756 ] Jonathan Natkins commented on KAFKA-1420: - Hi Guozhang, The particular case I'm

[jira] [Comment Edited] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-22 Thread Jonathan Natkins (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070756#comment-14070756 ] Jonathan Natkins edited comment on KAFKA-1420 at 7/22/14 7:30 PM:

[jira] [Updated] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-22 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Attachment:

[jira] [Updated] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-22 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicu marasoiu updated KAFKA-1549: - Attachment: (was:

Re: Review Request 23648: Patch for KAFKA-1524

2014-07-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23648/#review48338 --- clients/src/main/java/org/apache/kafka/clients/NetworkClient.java

Re: Review Request 23569: Patch for KAFKA-1525

2014-07-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/#review48416 --- Ship it! Ship It! - Joel Koshy On July 16, 2014, 9:30 p.m.,

Kafka Go Client

2014-07-22 Thread Pradeep Gollakota
Hi All, I was watching the talks from the Kafka meet up at LinkedIn last month. While answering a question on producers spilling to disk, Neha mentioned that there was a Go client that had this feature. I was wondering if the client that does this is https://github.com/Shopify/sarama/issues. I'm

[jira] [Resolved] (KAFKA-1533) transient unit test failure in ProducerFailureHandlingTest

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1533. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Guozhang Wang Thanks for the patch. +1

Re: Review Request 23569: Patch for KAFKA-1525

2014-07-22 Thread Dong Lin
On July 22, 2014, 7:59 p.m., Joel Koshy wrote: Ship It! Since we recently added txControl to message header, I will also include this in the output of DumpLogSements. - Dong --- This is an automatically generated e-mail. To reply,

[jira] [Commented] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070933#comment-14070933 ] Jun Rao commented on KAFKA-1549: Thanks for the patch. Could we define inReadLock and

[jira] [Commented] (KAFKA-1414) Speedup broker startup after hard reset

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070945#comment-14070945 ] Jun Rao commented on KAFKA-1414: Anton, Just curious in your experiment, is the data

[jira] [Commented] (KAFKA-1421) Error: Could not find or load main class kafka.perf.SimpleConsumerPerformance

2014-07-22 Thread Andrew Ehrlich (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14070976#comment-14070976 ] Andrew Ehrlich commented on KAFKA-1421: --- I am seeing this behavior in 0.8.1.1

[jira] [Commented] (KAFKA-1419) cross build for scala 2.11

2014-07-22 Thread Adriaan Moors (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071024#comment-14071024 ] Adriaan Moors commented on KAFKA-1419: -- Sorry about the sbt gymnastics! Here's how we

Re: Review Request 23705: Addressing Jun's comments

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23705/#review48440 --- Looks good. Just one minor comment below.

Re: [GitHub] kafka pull request: Clarify log expiry configuration options (for ...

2014-07-22 Thread Jun Rao
Thanks for pointing this out. Could you file a Apache jira and attach you patch there? Jun On Tue, Jul 22, 2014 at 8:40 AM, MarkRose g...@git.apache.org wrote: GitHub user MarkRose opened a pull request: https://github.com/apache/kafka/pull/28 Clarify log expiry configuration

[jira] [Commented] (KAFKA-1421) Error: Could not find or load main class kafka.perf.SimpleConsumerPerformance

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071071#comment-14071071 ] Jun Rao commented on KAFKA-1421: Hmm, I can't seem to find the script in trunk. Where did

[jira] [Commented] (KAFKA-1554) Corrupt index found on clean startup

2014-07-22 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071078#comment-14071078 ] Jun Rao commented on KAFKA-1554: Is this easily reproducible? Thanks, Corrupt index

[jira] [Commented] (KAFKA-1421) Error: Could not find or load main class kafka.perf.SimpleConsumerPerformance

2014-07-22 Thread Andrew Ehrlich (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071102#comment-14071102 ] Andrew Ehrlich commented on KAFKA-1421: --- I found it in the binary download on the

[jira] [Commented] (KAFKA-1420) Replace AdminUtils.createOrUpdateTopicPartitionAssignmentPathInZK with TestUtils.createTopic in all unit tests

2014-07-22 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071123#comment-14071123 ] Guozhang Wang commented on KAFKA-1420: -- Hello Jonathan, Thanks for the comment. You

Re: Review Request 23569: Patch for KAFKA-1522

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/ --- (Updated July 22, 2014, 11:42 p.m.) Review request for kafka. Summary

Re: Review Request 23567: Patch for KAFKA-1522

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23567/ --- (Updated July 22, 2014, 11:43 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071126#comment-14071126 ] Dong Lin commented on KAFKA-1522: - Updated reviewboard

[jira] [Commented] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071127#comment-14071127 ] Dong Lin commented on KAFKA-1522: - Updated reviewboard

[jira] [Updated] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Attachment: KAFKA-1522_2014-07-22_16:43:18.patch Transactional messaging request/response definitions

[jira] [Updated] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Attachment: KAFKA-1522_2014-07-22_16:42:50.patch Transactional messaging request/response definitions

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568/ --- (Updated July 22, 2014, 11:45 p.m.) Review request for kafka. Bugs:

Re: Review Request 23569: Patch for KAFKA-1525

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/ --- (Updated July 22, 2014, 11:50 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1525: Attachment: KAFKA-1525_2014-07-22_16:48:45.patch DumpLogSegments should print transaction IDs

[jira] [Issue Comment Deleted] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1522: Comment: was deleted (was: Updated reviewboard https://reviews.apache.org/r/23569/diff/ against branch

[jira] [Commented] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071134#comment-14071134 ] Dong Lin commented on KAFKA-1525: - Updated reviewboard

Re: Review Request 23567: Patch for KAFKA-1522

2014-07-22 Thread Dong Lin
On July 21, 2014, 5:49 p.m., Joel Koshy wrote: core/src/main/scala/kafka/api/TransactionRequest.scala, line 87 https://reviews.apache.org/r/23567/diff/4/?file=635090#file635090line87 TxControlTypes would be clearer I think (also based on what I have seen so far in KAFKA-1523 rb -

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-22 Thread Dong Lin
On July 21, 2014, 6:56 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/KafkaApis.scala, line 157 https://reviews.apache.org/r/23568/diff/4/?file=635099#file635099line157 Looking at this method in the other patch - this only gives the head - what about the other

[jira] [Commented] (KAFKA-1523) Implement transaction manager module

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14071130#comment-14071130 ] Dong Lin commented on KAFKA-1523: - Updated reviewboard

[jira] [Updated] (KAFKA-1523) Implement transaction manager module

2014-07-22 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated KAFKA-1523: Attachment: KAFKA-1523_2014-07-22_16:45:42.patch Implement transaction manager module

Re: Review Request 23569: Patch for KAFKA-1525

2014-07-22 Thread Dong Lin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/ --- (Updated July 22, 2014, 11:48 p.m.) Review request for kafka. Summary

Re: Review Request 23692: Patch for KAFKA-1550

2014-07-22 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23692/#review48455 --- Ship it! Ship It! - Guozhang Wang On July 22, 2014, 6:41 p.m.,

Re: Review Request 23442: Updated WIP simple consumer

2014-07-22 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23442/#review48445 --- Ship it! Some minor comments below.