Here are my cents:
We could use lazy as the default policy for KIP, i.e. :
1. Once a KIP is created at least one committer should engage and provide
feedbacks within a few days;
2. If the committer(s) think it may be a bigger issue / change and requires
broader discussion, she(they) may call out
[
https://issues.apache.org/jira/browse/KAFKA-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-1730.
Resolution: Fixed
Assignee: Manikumar Reddy
Thanks for the metrics doc patch. +1 and committed to
[
https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309645#comment-14309645
]
Guozhang Wang commented on KAFKA-1634:
--
Updated reviewboard
I created KIP-12
https://cwiki.apache.org/confluence/display/KAFKA/KIP-12+change+broker+configuration+properties+to+be+consistent+with+the+rest+of+the+code
and linked it to this thread and the JIRA with the v1 patch. The rebased
version with updates for the current review should be ready to review
Guozhang's idea is interesting. It does promote collaboration.
Not all KIPs are created equally and anyone (including the person reviewing
it) would be able to call out and request a stronger vote for it to go in.
I think that having 3 x +1 is good (sometimes) because it reduces the risk
of
On Feb. 4, 2015, 2:15 a.m., Joel Koshy wrote:
core/src/main/scala/kafka/api/OffsetCommitRequest.scala, line 48
https://reviews.apache.org/r/27391/diff/11/?file=832423#file832423line48
I our convention is to include the if in the previous line.
I checked the code base and it seems
[
https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309671#comment-14309671
]
Guozhang Wang commented on KAFKA-1884:
--
I think the behavior that producer's sender
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30743/
---
Review request for kafka.
Bugs: KAFKA-1839
I think we are focused on making committing new changes easier, but what we
have seen is actually that isn't the bulk of the work (especially with this
kind of public interface change where it generally has a big user
impact). I think we actually really need the core committers and any other
[
https://issues.apache.org/jira/browse/KAFKA-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309817#comment-14309817
]
Joel Koshy commented on KAFKA-1729:
---
I will be making a few more edits after some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30063/#review71482
---
Ship it!
Ship It!
- Guozhang Wang
On Feb. 1, 2015, 8:17 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310119#comment-14310119
]
Guozhang Wang commented on KAFKA-1333:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1333:
-
Attachment: KAFKA-1333_2015-02-06_15:02:48.patch
Add consumer co-ordinator module to the server
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309966#comment-14309966
]
Francois Saint-Jacques commented on KAFKA-1367:
---
Instead of silently
[
https://issues.apache.org/jira/browse/KAFKA-1919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310112#comment-14310112
]
Steven Zhen Wu commented on KAFKA-1919:
---
[~jkreps] I tried your patch, it seems to
[
https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310283#comment-14310283
]
Guozhang Wang commented on KAFKA-1884:
--
That is a bit weird, the metadata requests
[
https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310241#comment-14310241
]
Pradeep Gollakota commented on KAFKA-1884:
--
[~guozhang] That's what I figured at
[
https://issues.apache.org/jira/browse/KAFKA-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310548#comment-14310548
]
Pradeep Gollakota commented on KAFKA-1884:
--
I guess that makes sense... I'll
[
https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14310590#comment-14310590
]
Jay Kreps commented on KAFKA-1865:
--
A key aspect of this that isn't obvious is that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27391/
---
(Updated Feb. 6, 2015, 7:01 p.m.)
Review request for kafka.
Bugs: KAFKA-1634
[
https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-1634:
-
Attachment: KAFKA-1634_2015-02-06_11:01:08.patch
Improve semantics of timestamp in
I updated the installation and sample usage for the existing patches on the
KIP site
https://cwiki.apache.org/confluence/display/KAFKA/KIP-4+-+Command+line+and+centralized+administrative+operations
There are still a few pending items here.
1) There was already some discussion about using the
[
https://issues.apache.org/jira/browse/KAFKA-1904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308964#comment-14308964
]
Andrii Biletskyi commented on KAFKA-1904:
-
[~joestein] - I was able to run tests
this looks like it might help us too with getting the release documentation
content/changes along with code test contributions in patches without the
extra step with the site in the commits with svn
-- Forwarded message --
From: Dave Lester (JIRA) j...@apache.org
Date: Tue, Dec
strong +1
In addition to keeping the docs updated in sync with the patches, and
helping us avoid two source control systems, this will also allow automated
integration with https://readthedocs.org/, to make the docs immediately
available online, versioned and searchable.
Gwen
On Fri, Feb 6,
+1 from me too. I've seen the best way to keep docs in sync with the code
is to have contributors submit changes to both as part of the same patch.
Otherwise we keep playing catchup with the changing codebase.
On Fri, Feb 6, 2015 at 9:07 AM, Gwen Shapira gshap...@cloudera.com wrote:
strong +1
[
https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14309529#comment-14309529
]
Neha Narkhede commented on KAFKA-1476:
--
[~onurkaraman] To answer your questions below
I think this is a good change. Is there general agreement that we are
moving forward with this approach? It would be nice to start using this for
future work.
Thanks
Jeff
On Tue, Feb 3, 2015 at 9:34 AM, Joe Stein joe.st...@stealth.ly wrote:
I updated the RB changing some of the HIGH to MEDIUM
28 matches
Mail list logo
