[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339751#comment-14339751
]
Jun Rao commented on KAFKA-1988:
Actually, we can probably keep the same logic in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29231/
---
(Updated Feb. 27, 2015, 7:05 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339818#comment-14339818
]
Gwen Shapira commented on KAFKA-1824:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1824:
Attachment: KAFKA-1824_2015-02-26_23:05:10.patch
in ConsoleProducer - properties key.separator and
See https://builds.apache.org/job/Kafka-trunk/408/changes
Changes:
[junrao] kafka-1881; transient unit test failure in testDeleteTopicWithCleaner
due to OOME; patched by Ewen Cheslack-Postava; reviewed by Jun Rao
--
[...truncated 1022 lines...]
Hey Becket,
The KIP proposes addition of a --no.data.loss command line option to the
MirrorMaker. Though when would the user not want that option? I'm wondering
what the benefit of providing that option is if every user would want that
for correct mirroring behavior.
Other than that, the KIP
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Pekar updated KAFKA-1792:
Attachment: rebalance_use_cases.txt
change behavior of --generate to produce assignment config
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338489#comment-14338489
]
Dmitry Pekar edited comment on KAFKA-1792 at 2/26/15 3:00 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338489#comment-14338489
]
Dmitry Pekar commented on KAFKA-1792:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Pekar updated KAFKA-1792:
Attachment: (was: rebalance_use_cases.txt)
change behavior of --generate to produce assignment
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote:
Ah, now I get what dedupe buffer refers to :)
I never managed to reproduce the oom, but this looks like the right fix.
Ewen Cheslack-Postava wrote:
This happened consistently for me, which provided good motivation to
figure out
On Feb. 26, 2015, 7:14 a.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java,
line 132
https://reviews.apache.org/r/30763/diff/5/?file=877020#file877020line132
synchronized no longer matches the regular non-Mock version.
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1755:
--
Attachment: KAFKA-1755_2015-02-26_10:54:50.patch
Improve error handling in log cleaner
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/
---
(Updated Feb. 26, 2015, 6:54 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338944#comment-14338944
]
Jun Rao commented on KAFKA-1865:
The KIP
Hi Neha,
Thanks for the comment. That’s a really good point.
Originally I’m thinking about allowing user to tweak some parameter as
needed.
For example, some user might want to have pipeline enabled and can
tolerate reordering, some user might want to use acks=1 or acks=0, some
might want to
KAFKA-1650 added this option, but we don’t have ―no.data.loss in any
official release.
On 2/26/15, 12:01 PM, Gwen Shapira gshap...@cloudera.com wrote:
Did --no.data.loss exist in previous releases of irrorMaker?
If it does, maybe we want to keep it around for backward compatibility?
(i.e. so
On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote:
clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java,
line 87
https://reviews.apache.org/r/30763/diff/6/?file=878560#file878560line87
Do we really want to print the stack trace?
Jay Kreps wrote:
I think so,
Did --no.data.loss exist in previous releases of MirrorMaker?
If it does, maybe we want to keep it around for backward compatibility?
(i.e. so existing deployments won't break)?
Gwen
On Thu, Feb 26, 2015 at 11:57 AM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
Hi Neha,
Thanks for the
[
https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jay Kreps updated KAFKA-1865:
-
Attachment: KAFKA-1865_2015-02-26_10:37:16.patch
Add a flush() call to the new producer API
[
https://issues.apache.org/jira/browse/KAFKA-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338880#comment-14338880
]
Jay Kreps commented on KAFKA-1865:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338907#comment-14338907
]
Joel Koshy commented on KAFKA-1755:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31306/#review74329
---
core/src/main/scala/kafka/message/ByteBufferMessageSet.scala
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30763/#review74332
---
Ship it!
Looks good to me. Just a couple of minor comments.
[
https://issues.apache.org/jira/browse/KAFKA-1684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338996#comment-14338996
]
Suresh Vallabhaneni commented on KAFKA-1684:
There appears to be a patch
On Feb. 17, 2015, 9:28 p.m., Jiangjie Qin wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java,
line 80
https://reviews.apache.org/r/30763/diff/1/?file=853738#file853738line80
I think we have to execute the callback before we wake up the
On Feb. 26, 2015, 3:23 a.m., Guozhang Wang wrote:
core/src/main/scala/kafka/message/ByteBufferMessageSet.scala, line 205
https://reviews.apache.org/r/31306/diff/2/?file=873162#file873162line205
Can we add the key-validation logic into analyzeAndValidateMessageSet()?
No - because we
On Feb. 26, 2015, 7:15 p.m., Jun Rao wrote:
clients/src/test/java/org/apache/kafka/clients/producer/MetadataTest.java,
line 87
https://reviews.apache.org/r/30763/diff/6/?file=878560#file878560line87
Do we really want to print the stack trace?
I think so, we are not expecting an
On Feb. 26, 2015, 5:47 a.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java,
line 503
https://reviews.apache.org/r/30763/diff/5/?file=877019#file877019line503
Not sure how we make sure only a single flush at a time. Could you
explain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30763/
---
(Updated Feb. 26, 2015, 6:37 p.m.)
Review request for kafka.
Summary
On Feb. 24, 2015, 5:20 p.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordBatch.java,
line 91
https://reviews.apache.org/r/30763/diff/4/?file=873442#file873442line91
I still think it is kind of waste to create duplicate
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote:
Ah, now I get what dedupe buffer refers to :)
I never managed to reproduce the oom, but this looks like the right fix.
Ewen Cheslack-Postava wrote:
This happened consistently for me, which provided good motivation to
figure out
On Feb. 26, 2015, 3:07 a.m., Gwen Shapira wrote:
Ah, now I get what dedupe buffer refers to :)
I never managed to reproduce the oom, but this looks like the right fix.
Ewen Cheslack-Postava wrote:
This happened consistently for me, which provided good motivation to
figure out
Todd Palino created KAFKA-1987:
--
Summary: Potential race condition in partition creation
Key: KAFKA-1987
URL: https://issues.apache.org/jira/browse/KAFKA-1987
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339225#comment-14339225
]
Joel Koshy commented on KAFKA-1987:
---
Looking at the code I think this is possible when
[
https://issues.apache.org/jira/browse/KAFKA-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14338303#comment-14338303
]
Po Zhou commented on KAFKA-1460:
I occasionally encountered the issue with the following
This is the second candidate for release of Apache Kafka 0.8.2.1. This
fixes 4 critical issue in 0.8.2.0.
Release Notes for the 0.8.2.1 release
https://people.apache.org/~junrao/kafka-0.8.2.1-candidate2/RELEASE_NOTES.html
*** Please download, test and vote by Monday, Mar 2, 3pm PT
Kafka's KEYS
[
https://issues.apache.org/jira/browse/KAFKA-1881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1881:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339452#comment-14339452
]
Jun Rao commented on KAFKA-1400:
Provide a simple fix to send enough bytes to trigger a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/#review74411
---
Ship it!
LGTM. Tested 50 times with no failures.
- Ewen
+1 (binding)
On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote:
+1 binding
On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira gshap...@cloudera.com wrote:
+1 (non-binding)
On Tue, Feb 24, 2015 at 5:14 PM, Jiangjie Qin j...@linkedin.com.invalid
wrote:
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Status: Patch Available (was: Open)
org.apache.kafka.common.utils.Utils.abs method returns wrong value for
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tong Li updated KAFKA-1988:
---
Attachment: KAFKA-1988.patch
org.apache.kafka.common.utils.Utils.abs method returns wrong value for
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339478#comment-14339478
]
Tong Li commented on KAFKA-1988:
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31449/#review74380
---
Ship it!
Ship It!
- Joel Koshy
On Feb. 25, 2015, 11:54 p.m.,
See https://builds.apache.org/job/KafkaPreCommit/21/changes
Changes:
[junrao] kafka-1881; transient unit test failure in testDeleteTopicWithCleaner
due to OOME; patched by Ewen Cheslack-Postava; reviewed by Jun Rao
--
[...truncated 2088 lines...]
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339451#comment-14339451
]
Jun Rao commented on KAFKA-1400:
Created reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31517/
---
Review request for kafka.
Bugs: KAFKA-1988
Tong Li created KAFKA-1988:
--
Summary: org.apache.kafka.common.utils.Utils.abs method returns
wrong value for negative numbers.
Key: KAFKA-1988
URL: https://issues.apache.org/jira/browse/KAFKA-1988
Project:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/#review74415
---
Ship it!
Ship It!
- Jiangjie Qin
On Feb. 27, 2015, 12:15 a.m.,
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1988:
---
Priority: Blocker (was: Major)
Affects Version/s: 0.8.2.0
Fix Version/s: 0.8.2.1
Since
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1400:
---
Attachment: kafka-1400.patch
transient unit test failure in SocketServerTest
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-1400:
---
Assignee: Jun Rao (was: Neha Narkhede)
Status: Patch Available (was: Reopened)
transient unit test
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31510/
---
Review request for kafka.
Bugs: kafka-1400
[
https://issues.apache.org/jira/browse/KAFKA-1988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339500#comment-14339500
]
Jun Rao commented on KAFKA-1988:
Thanks for the patch. +1.
We actually made the same
On Feb. 11, 2015, 9:45 a.m., Jun Rao wrote:
core/src/main/scala/kafka/server/KafkaConfig.scala, lines 70-72
https://reviews.apache.org/r/28769/diff/17/?file=846168#file846168line70
Same comment as above, does a null string translate into a null in
endPoint.host?
yes. null string
+1 (binding)
On Thu, Feb 26, 2015 at 2:14 PM, Joel Koshy jjkosh...@gmail.com wrote:
+1 (binding)
On Tue, Feb 24, 2015 at 06:37:53PM -0800, Guozhang Wang wrote:
+1 binding
On Tue, Feb 24, 2015 at 5:24 PM, Gwen Shapira gshap...@cloudera.com
wrote:
+1 (non-binding)
On Tue, Feb
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339541#comment-14339541
]
Gwen Shapira commented on KAFKA-1400:
-
Any reason you prefer to try and detect a
See https://builds.apache.org/job/KafkaPreCommit/22/changes
Changes:
[junrao] kafka-1400; transient unit test failure in SocketServerTest; patched
by Jun Rao; reviewed by Ewen Cheslack-Postava and Jiangjie Qin
--
[...truncated 306 lines...]
[
https://issues.apache.org/jira/browse/KAFKA-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwen Shapira updated KAFKA-1809:
Attachment: KAFKA-1809.v2.patch
Updated per review from Jun Rao.
Refactor brokers to allow
On Feb. 11, 2015, 9:45 a.m., Jun Rao wrote:
core/src/main/scala/kafka/consumer/ConsumerConfig.scala, lines 184-186
https://reviews.apache.org/r/28769/diff/17/?file=846154#file846154line184
I thought we won't support security in the old client?
We don't, but I need to test my code
Can we change the command line arguments for mm to match the command line
arguments elsewhere. This proposal seems to have two formats:
*--consumer.rebalance.listener*
and
*--abortOnSendFail*
The '.' separators for command line options predate this JIRA but I think
the new camelCase option is a
On Feb. 12, 2015, 7:46 p.m., Jun Rao wrote:
clients/src/main/java/org/apache/kafka/common/protocol/ApiVersion.java,
lines 20-27
https://reviews.apache.org/r/28769/diff/17/?file=846135#file846135line20
It seems that we rely on the lexicographical ordering of the enum name
for
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339552#comment-14339552
]
Jun Rao commented on KAFKA-1400:
Well, this test is supposed to test the client behavior.
[
https://issues.apache.org/jira/browse/KAFKA-1400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14339588#comment-14339588
]
Gwen Shapira commented on KAFKA-1400:
-
I was under the impression that this was there
See https://builds.apache.org/job/Kafka-trunk/409/changes
Changes:
[junrao] kafka-1400; transient unit test failure in SocketServerTest; patched
by Jun Rao; reviewed by Ewen Cheslack-Postava and Jiangjie Qin
--
[...truncated 894 lines...]
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28769/
---
(Updated Feb. 27, 2015, 4:31 a.m.)
Review request for kafka.
Changes
---
67 matches
Mail list logo
