Re: [VOTE] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-31 Thread Boyang Chen
Thanks omkar for taking the initiative, +1 (non-binding). From: omkar mestry Sent: Saturday, June 1, 2019 1:40 PM To: dev@kafka.apache.org Subject: [VOTE] KIP-474: To deprecate WindowStore#put(key, value) Hi all, Since we seem to have an agreement in the

[VOTE] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-31 Thread omkar mestry
Hi all, Since we seem to have an agreement in the discussion I would like to start the vote on KIP-474. KIP 474 :- https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 Thanks & Regards Omkar Mestry

[jira] [Resolved] (KAFKA-8199) ClassCastException when trying to groupBy after suppress

2019-05-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-8199. -- Resolution: Fixed > ClassCastException when trying to groupBy after suppress >

[jira] [Created] (KAFKA-8461) Flakey test UncleanLeaderElectionTest#testUncleanLeaderElectionDisabledByTopicOverride

2019-05-31 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8461: -- Summary: Flakey test UncleanLeaderElectionTest#testUncleanLeaderElectionDisabledByTopicOverride Key: KAFKA-8461 URL: https://issues.apache.org/jira/browse/KAFKA-8461

[jira] [Created] (KAFKA-8460) Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition

2019-05-31 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8460: -- Summary: Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition Key: KAFKA-8460 URL: https://issues.apache.org/jira/browse/KAFKA-8460 Project: Kafka

Re: [DISCUSS] KIP-472: Add header to RecordContext

2019-05-31 Thread Matthias J. Sax
Sure thing :) For the original issue to preserve partition-time within a task across restarts, we don't need this KIP. And I agree that downstream time propagation via heartbeats is nothing critical atm but may require a big change. Hence, maybe not worth the effort right now. If you are fine

Jenkins build is back to normal : kafka-2.3-jdk8 #30

2019-05-31 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-05-31 Thread Oleksandr Diachenko
On 2019/05/30 06:06:12, Cyrus Vafadari wrote: > Hello Dev, > > I'd like to start the discussion of KIP-475: New Metric to Measure Number > of Tasks on a Connector. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-475%3A+New+Metric+to+Measure+Number+of+Tasks+on+a+Connector > > The

Re: [VOTE] 2.2.1 RC1

2019-05-31 Thread Matthias J. Sax
Thanks for running the release Harsha! - downloaded source code, built, and run tests locally; required 3 runs to get tests passing Failing test tracked as: - https://issues.apache.org/jira/browse/KAFKA-8260 - https://issues.apache.org/jira/browse/KAFKA-8458 - run quickstart with Scala

Re: [DISCUSS] KIP-472: Add header to RecordContext

2019-05-31 Thread Richard Yu
Hi Matthias, Thanks for responding. :) I suppose from the scope of the change that is needed to fix the timestamp propagation bug is too complex (in other words, probably not worth it). So should this KIP be closed since it might be a little excessive? There probably is no need for too big of a

Re: [DISCUSS] KIP-472: Add header to RecordContext

2019-05-31 Thread Matthias J. Sax
Thanks for the KIP. However, I have some doubts that this would work. In the example, you mention 4 records > r1(2), r2(3), r3(7), and r4(9) and that if r3 and r4 would be filtered, the downstream task would not advance partition time from 3 to 9. However, if r3 and r4 are filtered, no record

[jira] [Created] (KAFKA-8459) Flakey test BaseQuotaTest#testThrottledRequest

2019-05-31 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8459: -- Summary: Flakey test BaseQuotaTest#testThrottledRequest Key: KAFKA-8459 URL: https://issues.apache.org/jira/browse/KAFKA-8459 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-466: Add support for List serialization and deserialization

2019-05-31 Thread Matthias J. Sax
(1) The current PR suggests to always instantiate an `ArrayList` -- however, if a user wants to use any other list implementation, they have no way to specify this. It might be good to either allow users to specify the list-type on the deserializer, or encode the list type directly in the bytes,

Re: [DISCUSS] KIP-476: Add Java AdminClient Interface

2019-05-31 Thread Matthias J. Sax
Thanks for the KIP Andy! Using an interface instead of an abstract class makes totally sense to me. -Matthias On 5/31/19 2:59 AM, Andy Coates wrote: > Hi folks, > > I'd like to start a discussion thread for KIP-476: > >

[jira] [Created] (KAFKA-8458) Flaky Test AdminClientIntegrationTest#testElectPreferredLeaders

2019-05-31 Thread Matthias J. Sax (JIRA)
Matthias J. Sax created KAFKA-8458: -- Summary: Flaky Test AdminClientIntegrationTest#testElectPreferredLeaders Key: KAFKA-8458 URL: https://issues.apache.org/jira/browse/KAFKA-8458 Project: Kafka

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

2019-05-31 Thread sapiensy
Hey everyone, just bumping this thread again. We need one more vote from the committers. Thanks! :) On 2019/05/19 14:31:15, Kamal Chandraprakash wrote: > +1 (non-binding). Thanks for the KIP! > > On Sun, May 19, 2019 at 6:36 PM Dongjin Lee wrote: > > > +1 (non-binding). > > > > Binding: +2

Jenkins build is back to normal : kafka-trunk-jdk11 #591

2019-05-31 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-8457) Remove Log dependency from Replica

2019-05-31 Thread Vikas Singh (JIRA)
Vikas Singh created KAFKA-8457: -- Summary: Remove Log dependency from Replica Key: KAFKA-8457 URL: https://issues.apache.org/jira/browse/KAFKA-8457 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-8456) Flaky Test StoreUpgradeIntegrationTest#shouldMigratePersistentWindowStoreToTimestampedWindowStoreUsingPapi

2019-05-31 Thread Boyang Chen (JIRA)
Boyang Chen created KAFKA-8456: -- Summary: Flaky Test StoreUpgradeIntegrationTest#shouldMigratePersistentWindowStoreToTimestampedWindowStoreUsingPapi Key: KAFKA-8456 URL:

Re: [VOTE] 2.2.1 RC1

2019-05-31 Thread Mickael Maison
+1 non-binding We've been running it for a few days in a few clusters, so far no issues. I also ran unit tests and checked signatures. Thanks Vahid for running this release On Fri, May 31, 2019 at 9:01 AM Andrew Schofield wrote: > > +1 (non-binding) > > Built and ran source and sink connectors.

[jira] [Created] (KAFKA-8455) Add NothingSerde to Serdes

2019-05-31 Thread John Roesler (JIRA)
John Roesler created KAFKA-8455: --- Summary: Add NothingSerde to Serdes Key: KAFKA-8455 URL: https://issues.apache.org/jira/browse/KAFKA-8455 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-8454) Add Java AdminClient interface

2019-05-31 Thread Andy Coates (JIRA)
Andy Coates created KAFKA-8454: -- Summary: Add Java AdminClient interface Key: KAFKA-8454 URL: https://issues.apache.org/jira/browse/KAFKA-8454 Project: Kafka Issue Type: Bug

[DISCUSS] KIP-476: Add Java AdminClient Interface

2019-05-31 Thread Andy Coates
Hi folks, I'd like to start a discussion thread for KIP-476: https://cwiki.apache.org/confluence/display/KAFKA/KIP-476%3A+Add+Java+AdminClient+Interface Thanks, Andy

[jira] [Created] (KAFKA-8453) AdminClient describeTopic should handle partition level errors

2019-05-31 Thread Jason Gustafson (JIRA)
Jason Gustafson created KAFKA-8453: -- Summary: AdminClient describeTopic should handle partition level errors Key: KAFKA-8453 URL: https://issues.apache.org/jira/browse/KAFKA-8453 Project: Kafka