Re: KIP-800: Add reason to LeaveGroupRequest

Hi David, Thanks for the KIP. It makes sense to me. Some comments: 1. Should we bump the `LeaveGroupRequest` protocol version to 5? 2. the description in the new field: "about": "The reason" -> "about": "The reason why the member left the group" 3. For the `removeMembersFromConsumerGroup` case,

[DISCUSS] KIP-792: Add "generation" field into consumer protocol

Hi all, I'd like to start the discussion for KIP-792: Add "generation" field into consumer protocol. The goal of this KIP is to allow assignor/consumer coordinator/group coordinator to have a way to identify the out-of-date members/assignments. Detailed description can be found here:

Re: [DISCUSS] KIP-796: Interactive Query v2

Thanks for taking a look, Sophie! Ah, that was a revision error. I had initially been planning an Optional> with Optional.empty() meaning to fetch all partitions, but then decided it was needlessly complex and changed it to the current proposal with two methods: boolean isAllPartitions(); Set

Re: [DISCUSS] KIP-796: Interactive Query v2

Thanks John, I've been looking forward to this for a while now. It was pretty horrifying to learn how present-day IQ works (or rather, doesn't work) with custom state stores :/ One minor cosmetic point, In the InteractiveQueryRequest class, the # getPartitions method has a return type of Set,

Re: [DISCUSS] KIP-795: Add public APIs for AbstractCoordinator

Hi Tom, Thanks for taking time reviewing the KIP. I think it's reasonable to ask if Kafka's Group Coordination protocol should be used for use cases other than the distributed event log. This was actually briefly addressed by Gwen Shapira during her presentation at the strangeloop conference

Re: [DISCUSS] KIP-779: Allow Source Tasks to Handle Producer Exceptions

Hi Knowles, I think this looks good for the most part but I'd still like to see an explicit mention in the KIP (and proposed doc/Javadoc changes) that states that, with exactly-once support enabled, producer exceptions that result from failures related to exactly-once support (including but not

Re: [DISCUSS] KIP-796: Interactive Query v2

Hello again, all, Just bumping this discussion on a new, more flexible Interactive Query API in Kafka Streams. If there are no concerns, I'll go ahead and call a vote on Monday. Thanks! -John On Tue, 2021-11-09 at 17:37 -0600, John Roesler wrote: > Hello all, > > I'd like to start the

Re: [VOTE] KIP-779: Allow Source Tasks to Handle Producer Exceptions

Thanks, Knowles! I'm +1 (binding) -John On Wed, 2021-11-10 at 12:42 -0500, Christopher Shannon wrote: > +1 (non-binding). This looks good to me and will be useful as a way to > handle producer errors. > > On Mon, Nov 8, 2021 at 8:55 AM Knowles Atchison Jr > wrote: > > > Good morning, > > >

Re: [DISCUSS] KIP-799 Align behaviour for producer callbacks with documented behaviour

Thanks for the reply, Séamus, Ah, I missed that the actual value of the placeholder is that otherwise, you wouldn't know the topic/partition of the error. I guess, on balance, it doesn't feel like this situation really justifies moving to a new callback interface (to pass back the

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #562

See Changes: -- [...truncated 498519 lines...] [2021-11-11T17:46:19.929Z] > Task :raft:testClasses UP-TO-DATE [2021-11-11T17:46:19.929Z] > Task :connect:json:testJar

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.1 #7

See Changes: -- [...truncated 497765 lines...] [2021-11-11T17:37:51.416Z] [2021-11-11T17:37:51.416Z] SaslOAuthBearerSslEndToEndAuthorizationTest >

Re: [DISCUSS] KIP-799 Align behaviour for producer callbacks with documented behaviour

Hey John, > did you consider just going back to the original behavior? I hadn't considered going back to the exact original behaviour as I think there's a valid point made in discussions around KAFKA-7412 (I forget whether in a JIRA or PR comment) that returning the topic partition when

KIP-800: Add reason to LeaveGroupRequest

Hi folks, I'd like to discuss this very small KIP which proposes to add a reason field to the LeaveGroupRequest in order to let the broker know why a member left the group. This would be really handy for administrators. KIP: https://cwiki.apache.org/confluence/x/eYyqCw Cheers, David

[jira] [Created] (KAFKA-13451) Add reason to LeaveGroupRequest

David Jacot created KAFKA-13451: --- Summary: Add reason to LeaveGroupRequest Key: KAFKA-13451 URL: https://issues.apache.org/jira/browse/KAFKA-13451 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-799 Align behaviour for producer callbacks with documented behaviour

Thanks for the KIP, Séamus! I agree that the current situation you’re describing doesn’t seem ideal, and it’s probably worth a slight behavior change to fix it. It’s too bad that we introduced that placeholder record, since it seems less error prone for users if we have the invariant that

[DISCUSS] KIP-799 Align behaviour for producer callbacks with documented behaviour

Hi, As outlined in KIP-799: Align behaviour for producer callbacks with documented behaviour , there is an inconsistency between the documented behaviour and

[jira] [Created] (KAFKA-13450) Kafka broker to return alternating sets of listeners to clients for multipathing

Sudarshan Pathalam created KAFKA-13450: -- Summary: Kafka broker to return alternating sets of listeners to clients for multipathing Key: KAFKA-13450 URL: https://issues.apache.org/jira/browse/KAFKA-13450

Re: [VOTE] KIP-791: Add Record Metadata to State Store Context

Thanks everyone for voting. Voting passed after 3 days with the following +1s: - Luke Chen - Vasiliki (Vicky) Papavasileiou - Guozhang Wang (binding) - John Roesler (binding) - Bruno Cadonna (binding) I'll update the KIP status accordingly. Best, Patrick On Wed, Nov 10, 2021 at 5:03 PM

[jira] [Created] (KAFKA-13449) Comment optimization for parameter log.cleaner.delete.retention.ms

RivenSun created KAFKA-13449: Summary: Comment optimization for parameter log.cleaner.delete.retention.ms Key: KAFKA-13449 URL: https://issues.apache.org/jira/browse/KAFKA-13449 Project: Kafka