Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread ziming deng
Congratulations, Divij! Well deserved! -- Ziming > On Jun 14, 2023, at 09:41, Luke Chen wrote: > > Congratulations, Divij! > Well deserved! > > Luke > > On Wed, Jun 14, 2023 at 7:01 AM Viktor Somogyi-Vass > wrote: > >> Congrats Divij! >> >> On Tue, Jun 13, 2023, 20:27 Philip Nee wrote:

[ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread hudeqi
Congratulations! Divij! -原始邮件- 发件人: "Joobi S.B" 发送时间: 2023-06-14 00:49:57 (星期三) 收件人: dev@kafka.apache.org 抄送: 主题: Re: [ANNOUNCE] New committer: Divij Vaidya

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Luke Chen
Congratulations, Divij! Well deserved! Luke On Wed, Jun 14, 2023 at 7:01 AM Viktor Somogyi-Vass wrote: > Congrats Divij! > > On Tue, Jun 13, 2023, 20:27 Philip Nee wrote: > > > Congrats! > > > > On Tue, Jun 13, 2023 at 8:17 PM Randall Hauch wrote: > > > > > Congratulations! > > > > > > On

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Viktor Somogyi-Vass
Congrats Divij! On Tue, Jun 13, 2023, 20:27 Philip Nee wrote: > Congrats! > > On Tue, Jun 13, 2023 at 8:17 PM Randall Hauch wrote: > > > Congratulations! > > > > On Tue, Jun 13, 2023 at 12:48 PM Matthias J. Sax > wrote: > > > > > Congrats! > > > > > > On 6/13/23 10:24 AM, Satish Duggana

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #1921

2023-06-13 Thread Apache Jenkins Server
See

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Philip Nee
Congrats! On Tue, Jun 13, 2023 at 8:17 PM Randall Hauch wrote: > Congratulations! > > On Tue, Jun 13, 2023 at 12:48 PM Matthias J. Sax wrote: > > > Congrats! > > > > On 6/13/23 10:24 AM, Satish Duggana wrote: > > > Congratulations Divij!! > > > > > > On Tue, 13 Jun 2023 at 22:41, Manyanda

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Randall Hauch
Congratulations! On Tue, Jun 13, 2023 at 12:48 PM Matthias J. Sax wrote: > Congrats! > > On 6/13/23 10:24 AM, Satish Duggana wrote: > > Congratulations Divij!! > > > > On Tue, 13 Jun 2023 at 22:41, Manyanda Chitimbo > > wrote: > >> > >> Congratulations Divij. > >> > >> On Tue 13 Jun 2023 at

Re: First Contribution

2023-06-13 Thread Lovish Madhu
Looks good, but I am also a newbie. However I feel like variables such as n = 10 as some meaningful variable name as it is global constant. Also you forgot to use n and instead used 10 here: refreshed_collaborators[:10] On Tue, Jun 13, 2023 at 11:23 PM Steven Booke wrote: > To whom this may

First Contribution

2023-06-13 Thread Steven Booke
To whom this may concern, This is my first time contributing and I have just submitted my first PR. I have made changes to both apache/kafka-site and apache/kafka repos. I believe I have followed the detailed instructions for contributing a code change and am looking for feedback. Here are the

First Contribution

2023-06-13 Thread Steven Booke
To whom this may concern, This is my first time contributing and I have just submitted my first PR. I have made changes to both apache/kafka-site and apache/kafka repos. I believe I have followed the detailed instructions for contributing a code change and am looking for feedback. Here are the

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Matthias J. Sax
Congrats! On 6/13/23 10:24 AM, Satish Duggana wrote: Congratulations Divij!! On Tue, 13 Jun 2023 at 22:41, Manyanda Chitimbo wrote: Congratulations Divij. On Tue 13 Jun 2023 at 17:50, Bruno Cadonna wrote: Hi all, The PMC of Apache Kafka is pleased to announce a new Kafka committer

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Satish Duggana
Congratulations Divij!! On Tue, 13 Jun 2023 at 22:41, Manyanda Chitimbo wrote: > > Congratulations Divij. > > On Tue 13 Jun 2023 at 17:50, Bruno Cadonna wrote: > > > Hi all, > > > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > > Divij Vaidya. > > > > Divij's major

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Manyanda Chitimbo
Congratulations Divij. On Tue 13 Jun 2023 at 17:50, Bruno Cadonna wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Divij Vaidya. > > Divij's major contributions are: > > GDPR compliance enforcement of kafka-site - >

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Andrew Schofield
Congratulations. Always good to see new committers. > On 13 Jun 2023, at 17:15, Mickael Maison wrote: > > Congratulations! > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: >> >> Congratulations Divij! >> >> On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna wrote: >> >>> Hi all, >>> >>> The

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.5 #20

2023-06-13 Thread Apache Jenkins Server
See

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Joobi S.B
Congratulations ! On Tue, Jun 13, 2023 at 10:15 PM David Arthur wrote: > Congrats Divij! > > On Tue, Jun 13, 2023 at 12:34 PM Igor Soarez wrote: > > > Congratulations Divij! > > > > -- > > Igor > > > > > -- > -David >

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread John Roesler
Congratulations, Divij! -John On Tue, Jun 13, 2023, at 09:44, David Arthur wrote: > Congrats Divij! > > On Tue, Jun 13, 2023 at 12:34 PM Igor Soarez wrote: > >> Congratulations Divij! >> >> -- >> Igor >> > > > -- > -David

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Chia-Ping Tsai
Congratulations Divij :) > David Arthur 於 2023年6月14日 上午12:44 寫道: > > Congrats Divij! > > On Tue, Jun 13, 2023 at 12:34 PM Igor Soarez wrote: > >> Congratulations Divij! >> >> -- >> Igor >> > > > -- > -David

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread David Arthur
Congrats Divij! On Tue, Jun 13, 2023 at 12:34 PM Igor Soarez wrote: > Congratulations Divij! > > -- > Igor > -- -David

Re: Contributing to Kafka

2023-06-13 Thread Joobi S.B
Sure. Thank you ! On Tue, Jun 13, 2023 at 6:34 AM Luke Chen wrote: > Hi Joobi, > > Thanks for the interest in Apache Kafka. > You can read the contributor guide here first: > https://kafka.apache.org/contributing > And find tickets you're interested from JIRA: >

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Igor Soarez
Congratulations Divij! -- Igor

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Jorge Esteban Quilcate Otoya
Awesome news! Congrats Divij! On Tue 13. Jun 2023 at 19.30, Tom Bentley wrote: > Congratulations Divij! > > On Tue, 13 Jun 2023 at 17:21, Mickael Maison > wrote: > > > Congratulations! > > > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > > > Congratulations Divij! > > > > > > On

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Tom Bentley
Congratulations Divij! On Tue, 13 Jun 2023 at 17:21, Mickael Maison wrote: > Congratulations! > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > Congratulations Divij! > > > > On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna > wrote: > > > > > Hi all, > > > > > > The PMC of Apache

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Kirk True
Congrats Well deserved! On Tue, Jun 13, 2023, at 9:22 AM, Greg Harris wrote: > Congratulations! > > On Tue, Jun 13, 2023 at 9:15 AM Mickael Maison > wrote: > > > > Congratulations! > > > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > > > Congratulations Divij! > > > > > > On

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Greg Harris
Congratulations! On Tue, Jun 13, 2023 at 9:15 AM Mickael Maison wrote: > > Congratulations! > > On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > > > Congratulations Divij! > > > > On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna wrote: > > > > > Hi all, > > > > > > The PMC of Apache Kafka is

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #1920

2023-06-13 Thread Apache Jenkins Server
See Changes: -- [...truncated 470731 lines...] [2023-06-13T10:43:10.947Z] [2023-06-13T10:43:10.947Z] Gradle Test Run :streams:integrationTest > Gradle Test Executor 180

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-13 Thread Greg Harris
David, Thanks for finding that gradle plugin. The `changedModules` mode is exactly what I had in mind for fairness to modules earlier in the dependency graph. > if we moved to a policy where PRs only need some of the tests to pass > to merge, when would we run the full CI? On each trunk commit

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Mickael Maison
Congratulations! On Tue, Jun 13, 2023 at 6:05 PM Yash Mayya wrote: > > Congratulations Divij! > > On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna wrote: > > > Hi all, > > > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > > Divij Vaidya. > > > > Divij's major contributions

Re: [ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Yash Mayya
Congratulations Divij! On Tue, Jun 13, 2023 at 9:20 PM Bruno Cadonna wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Divij Vaidya. > > Divij's major contributions are: > > GDPR compliance enforcement of kafka-site - >

[ANNOUNCE] New committer: Divij Vaidya

2023-06-13 Thread Bruno Cadonna
Hi all, The PMC of Apache Kafka is pleased to announce a new Kafka committer Divij Vaidya. Divij's major contributions are: GDPR compliance enforcement of kafka-site - https://issues.apache.org/jira/browse/KAFKA-13868 Performance improvements: Improve performance of VarInt encoding and

[DISCUSS] KIP-714: Client metrics and observability

2023-06-13 Thread Andrew Schofield
Hi, I would like to start a new discussion thread on KIP-714: Client metrics and observability. https://cwiki.apache.org/confluence/display/KAFKA/KIP-714%3A+Client+metrics+and+observability I have edited the proposal significantly to reduce the scope. The overall mechanism for client metric

[jira] [Created] (KAFKA-15084) Remove lock contention in RemoteIndexCache

2023-06-13 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-15084: Summary: Remove lock contention in RemoteIndexCache Key: KAFKA-15084 URL: https://issues.apache.org/jira/browse/KAFKA-15084 Project: Kafka Issue Type:

Re: [DISCUSS] Partial CI builds - Reducing flakiness with fewer tests

2023-06-13 Thread David Arthur
Hey folks, interesting discussion. I came across a Gradle plugin that calculates a DAG of modules based on the diff and can run only the affected module's tests or the affected + downstream tests. https://github.com/dropbox/AffectedModuleDetector I tested it out locally, and it seems to work as

[jira] [Resolved] (KAFKA-15080) Fetcher's lag never set when partition is idle

2023-06-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15080. - Fix Version/s: 3.5.1 3.6.0 Resolution: Fixed > Fetcher's lag never

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Luke Chen
Looks good. Thanks for the update. On Tue, Jun 13, 2023 at 8:08 PM Ivan Yurchenko wrote: > Hi all! > > Thank you for your votes. > > Based on the proposal of Satish in the discussion thread, I modified the > KIP a little bit by lowering the default value of >

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.5 #19

2023-06-13 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Ivan Yurchenko
Hi all! Thank you for your votes. Based on the proposal of Satish in the discussion thread, I modified the KIP a little bit by lowering the default value of `remote.log.metadata.custom.metadata.max.size` from 10 KiB to 128 bytes. I hope this doesn't change your vote, but feel free to raise your

Re: [DISCUSS] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Ivan Yurchenko
Hi Satish, I understand your point and I agree with it. TBH, I didn't take into account the in-memory cache. Surely, 10 KiB is a relatively arbitrary number. Lowering it to the proposed 128 bytes won't probably change anything for most of the implementations. Others could ask for an increase.

[GitHub] [kafka-site] mimaison commented on pull request #522: MINOR: Default to 3.5 docs

2023-06-13 Thread via GitHub
mimaison commented on PR #522: URL: https://github.com/apache/kafka-site/pull/522#issuecomment-1589098313 Sorry @jlprat I was still making changes I should have kept the PR in draft mode. I think I've done all the necessary changes now. It looks like we missed a bunch of updates when

[GitHub] [kafka-site] mimaison opened a new pull request, #522: MINOR: Default to 3.5 docs

2023-06-13 Thread via GitHub
mimaison opened a new pull request, #522: URL: https://github.com/apache/kafka-site/pull/522 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[jira] [Created] (KAFKA-15083) Passing "remote.log.metadata.*" configs into RLMM

2023-06-13 Thread Luke Chen (Jira)
Luke Chen created KAFKA-15083: - Summary: Passing "remote.log.metadata.*" configs into RLMM Key: KAFKA-15083 URL: https://issues.apache.org/jira/browse/KAFKA-15083 Project: Kafka Issue Type:

Re: [DISCUSS] KIP-937 Improve Message Timestamp Validation

2023-06-13 Thread Luke Chen
Hi Mehari, Thanks for the update. The KIP LGTM now. Luke On Tue, Jun 13, 2023 at 12:20 AM Beyene, Mehari wrote: > Hi Luke, Divij and All, > > I have updated the KIP to incorporate Luke's comment. We now have two new > configurations for validating the message timestamp difference. The >

Re: [VOTE] 3.5.0 RC1

2023-06-13 Thread Mickael Maison
Hi, I'm now closing the vote. The vote passes with - 4 +1 bindings votes from Luke, John, Bill and David - 4 +1 non-binding votes from Federico, Jakub, Josep and Satish - 0 -1 votes I'll go ahead and finish the release process. Thanks, Mickael On Mon, Jun 12, 2023 at 8:05 PM David Arthur

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Josep Prat
Hi Ivan, Thank you very much for this KIP. +1 (binding) from me. Best, On Tue, Jun 13, 2023 at 10:03 AM Luke Chen wrote: > +1 (binding) from me. > > Thanks. > Luke > > On Tue, Jun 13, 2023 at 3:44 PM Matthew Benedict de Detrich > wrote: > > > > +1 (non binding). Thanks for KIP > > > > On

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Luke Chen
+1 (binding) from me. Thanks. Luke On Tue, Jun 13, 2023 at 3:44 PM Matthew Benedict de Detrich wrote: > > +1 (non binding). Thanks for KIP > > On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding). Thanks for the KIP! > > > > On

Re: [VOTE] KIP-858: Handle JBOD broker disk failure in KRaft

2023-06-13 Thread ziming deng
Hi Igor, Thanks for this work. +1(binding) from me -- Best, Ziming > On Jun 12, 2023, at 18:07, Igor Soarez wrote: > > Hi everyone, > > We're getting closer to dropping ZooKeeper support, and JBOD > in KRaft mode is one of the outstanding big missing features. > > It's been a while since

Re: [VOTE] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Matthew Benedict de Detrich
+1 (non binding). Thanks for KIP On Tue, Jun 13, 2023 at 3:38 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding). Thanks for the KIP! > > On Mon, Jun 12, 2023, 21:23 Divij Vaidya wrote: > > > I have reviewed the proposal and feel that it would be beneficial to >

Re: Can't creare a Jira

2023-06-13 Thread Bruno Cadonna
Hi Assane, I cannot find neither assane.diop nor adiop in the Kafka JIRA project. I also cannot find assane.diop in the Apache JIRA. Are you sure you did not request an account in a different Apache project before? I could not find your request on the Kafka private mailing list (since

Re: [DISCUSS] KIP-917: Additional custom metadata for remote log segment

2023-06-13 Thread Satish Duggana
Thanks Ivan for taking the feedback/suggestions into the KIP. 10kb limit as default is huge for each segment metadata. This should only be used for a few keys pointing to more values if needed from a different store. This is intended to be used for purposes like pointing to a specific cluster or