Re: [DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-07 Thread Andrew Schofield
Hi Artem, I think you make a very good point. This also looks to me like it deserves a version bump for the request. Andrew > On 8 Nov 2023, at 04:12, Artem Livshits > wrote: > > Hi Raman, > > Thank you for the KIP. I think using the tagged field > in DescribeTransactionsResponse should be

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-07 Thread Qichao Chu
Hi Divij, Thank you for the feedback. I updated the KIP to make it a little bit more generic: filters will stay in an array instead of different top-level objects. In this way, if we need language filters in the future. The logic relationship of filters is also added. Hi Jorge, Thank you for

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-07 Thread Matthias J. Sax
I am ok with the config proposal. For consumer/producer/admin client configs, I still don't understand why one would want to instantiate the object (for StreamsConfig with its complex "overwrite logic" of internal client configs, it makes more sense). But there is also no real harm done to

Re: [DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-07 Thread Artem Livshits
Hi Raman, Thank you for the KIP. I think using the tagged field in DescribeTransactionsResponse should be good -- if either the client or the server don't support it, it's not printed, which is reasonable behavior. For the ListTransactionsRequest, though, I think using the tagged field could

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2368

2023-11-07 Thread Apache Jenkins Server
See Changes: -- [...truncated 431838 lines...] > Task :connect:json:testJar > Task :connect:api:generateMetadataFileForMavenJavaPublication > Task

Re: [VOTE] KIP-982: Enhance Custom KafkaPrincipalBuilder to Access SslPrincipalMapper and KerberosShortNamer

2023-11-07 Thread Raghu B
Hi Contributors, I kindly request your valuable input on KIP-982, which is currently open for voting and review. At present, we have one binding +1 vote and one non-binding +1 vote. Please take a moment to review the KIP and cast your vote, as your expertise and contribution would greatly help.

Re: [DISCUSS] KIP-982: Access SslPrincipalMapper and kerberosShortNamer in Custom KafkaPrincipalBuilder

2023-11-07 Thread Raghu B
Hi Mickael, Yes, it is a more elegant solution with minor code changes but considering the backward compatibility and impact on existing custom KafkaPrincipalBuilder implementations I thought the proposed solution is a better option. Thanks, Raghu On Thu, Nov 2, 2023 at 7:20 AM Mickael Maison

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-07 Thread Jorge Esteban Quilcate Otoya
Hi Qichao, Thanks for the KIP! This will be a valuable contribution and improve the tooling for troubleshooting. I have a couple of comments: 1. It's unclear from the `metrics.verbosity` description what the supported values are. In the description mentions "If the value is high ... In the low

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-07 Thread Divij Vaidya
Thanks again for making the changes. 1) sounds good 3) sounds good For 2) I was recommending something different where we have a schema such that we can add a list consisting of generic filters but we will start with implementing a singleton list containing only topic filter. I need some more

[jira] [Created] (KAFKA-15798) Flaky Test NamedTopologyIntegrationTest.shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology()

2023-11-07 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15798: -- Summary: Flaky Test NamedTopologyIntegrationTest.shouldAddAndRemoveNamedTopologiesBeforeStartingAndRouteQueriesToCorrectTopology() Key: KAFKA-15798 URL:

[jira] [Created] (KAFKA-15797) Flaky test EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true]

2023-11-07 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15797: -- Summary: Flaky test EosV2UpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosV2[true] Key: KAFKA-15797 URL: https://issues.apache.org/jira/browse/KAFKA-15797

Re: [DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-07 Thread Adam Bellemare
Let's take this moment to celebrate the creation of KIP-1000! On Tue, Nov 7, 2023 at 3:49 PM Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I would like to start discussion of a small KIP which fills a gap in the > administration of client metrics configuration. > > >

[DISCUSS] KIP-924: customizable task assignment for Streams

2023-11-07 Thread Rohan Desai
Hello All, I'd like to start a discussion on KIP-924 ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-924%3A+customizable+task+assignment+for+Streams) which proposes an interface to allow users to plug into the streams partition assignor. The motivation section in the KIP goes into some

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2367

2023-11-07 Thread Apache Jenkins Server
See Changes: -- [...truncated 225286 lines...] Progress (1): 2.2/5.6 MB Progress (1): 2.2/5.6 MB Progress (1): 2.2/5.6 MB Progress (1): 2.2/5.6 MB Progress (1): 2.3/5.6 MB

[DISCUSS] KIP-1000: List Client Metrics Configuration Resources

2023-11-07 Thread Andrew Schofield
Hi, I would like to start discussion of a small KIP which fills a gap in the administration of client metrics configuration. https://cwiki.apache.org/confluence/display/KAFKA/KIP-1000%3A+List+Client+Metrics+Configuration+Resources Thanks, Andrew

Re: [DISCUSS] KIP-877: Mechanism for plugins and connectors to register metrics

2023-11-07 Thread Mickael Maison
Hi, A bit later than initially planned I finally restarted looking at this KIP. I made a few significant changes to the proposed APIs. I considered Chris' idea of automatically removing metrics but decided to leave that responsibility to the plugins. All plugins that will support this feature

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2366

2023-11-07 Thread Apache Jenkins Server
See

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-07 Thread Mickael Maison
Hi Tina, Thanks for the KIP. For clarity it might make sense to mention this feature will be useful when using a ConfigProvider with Kafka Connect as providers are set in the runtime and can then be used by connectors. This feature has no use when using a ConfigProvider in server.properties or in

Re: [DISCUSS] KIP-977: Partition-Level Throughput Metrics

2023-11-07 Thread Qichao Chu
Hi Divij, It would be very nice if you could take a look at the recent changes, thank you! If there's no more required changes, shall we move to vote stage? Best, Qichao Chu Software Engineer | Data - Kafka [image: Uber] On Thu, Nov 2, 2023 at 12:06 AM Qichao Chu wrote: >

Re: [DISCUSS] KIP-967: Support custom SSL configuration for Kafka Connect RestServer

2023-11-07 Thread Taras Ledkov
Hi Chris, Regarding item 4: Thanks for clarification. I really missed it. I've updated the 'compatibility' section [1] and prototype [2] accordingly. Regarding item 5: Perfect naming is the one of hardest things and not my strong point. > The best I've been able to come up with is establishing

Re: KIP-993: Allow restricting files accessed by File and Directory ConfigProviders

2023-11-07 Thread Gantigmaa Selenge
Hi everyone, Please let me know if you have any comments on the KIP. I will leave it for a few more days. If there are still no comments, I will start the vote on it. Regards, Tina On Wed, Oct 25, 2023 at 8:31 AM Gantigmaa Selenge wrote: > Hi everyone, > > I would like to start a discussion

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #2365

2023-11-07 Thread Apache Jenkins Server
See

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.5 #92

2023-11-07 Thread Apache Jenkins Server
See Changes: -- [...truncated 473521 lines...] Gradle Test Run :streams:integrationTest > Gradle Test Executor 189 > TableTableJoinIntegrationTest > [caching enabled = true]

Jenkins build is unstable: Kafka » Kafka Branch Builder » 3.6 #106

2023-11-07 Thread Apache Jenkins Server
See

Re: Requesting permission to contribute to Apache Kafka.

2023-11-07 Thread Yash Mayya
Hi Afshin, I've granted you the necessary permissions. Thanks for your interest in contributing to Apache Kafka! Cheers, Yash On Tue, Nov 7, 2023 at 3:52 PM Afshin Moazami wrote: > Hi, > I would like to request permission to contribute to Apache Kafka. > wiki ID: amoazami > Jira ID: afshing >

RE: Java 1.8 and TLSv1.3

2023-11-07 Thread Andreas Martens1
Hi Edoardo, Yes, that’s exactly what I’m saying! If I run the console consumer in the build with: kafka-console-consumer.sh --bootstrap-server :443 --topic --consumer.config $PWD/consumer.properties Where consumer.properties contains: sasl.mechanism=PLAIN security.protocol=SASL_SSL

Requesting permission to contribute to Apache Kafka.

2023-11-07 Thread Afshin Moazami
Hi, I would like to request permission to contribute to Apache Kafka. wiki ID: amoazami Jira ID: afshing Thanks, Afshin Moazami

[DISCUSS] KIP-994: Minor Enhancements to ListTransactions and DescribeTransactions APIs

2023-11-07 Thread Raman Verma
I would like to start a discussion on KIP-994 https://cwiki.apache.org/confluence/display/KAFKA/KIP-994%3A+Minor+Enhancements+to+ListTransactions+and+DescribeTransactions+APIs

RE: Java 1.8 and TLSv1.3

2023-11-07 Thread Andreas Martens1
Ahh, that’s it, the second property needs to be set too, we weren’t doing that! By setting both ssl.protocol and ssl.enabled.protocols we can get TLSv1.3. Annoyingly the JRE implementations differ, some interpret “TLSv1.3” to mean “TLS 1.3 and TLS 1.2” and some to mean “TLS 1.3 only”. I can’t

[jira] [Resolved] (KAFKA-15771) ProduceRequest#partitionSizes() is not an atomic operation

2023-11-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya resolved KAFKA-15771. -- Resolution: Fixed > ProduceRequest#partitionSizes() is not an atomic operation >