Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka-site]

2024-02-21 Thread via GitHub
showuon closed pull request #585: KAFKA-16283: notify users about RoundRobinPartitioner bug URL: https://github.com/apache/kafka-site/pull/585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [DISCUSS] KIP-939: Support Participation in 2PC

2024-02-21 Thread Artem Livshits
Hi Jun, > 20A. One option is to make the API initTransactions(boolean enable2PC). We could do that. I think there is a little bit of symmetry between the client and server that would get lost with this approach (server has enable2PC as config), but I don't really see a strong reason for

Re: [DISCUSS] KIP-939: Support Participation in 2PC

2024-02-21 Thread Artem Livshits
Hi Rowland, > The Open Group DTP model and the XA interface requires that resource managers be able to report prepared transactions only, so a prepare RPC will be required. It's required in the XA protocol, but I'm not sure we have to build it into a Kafka. Looks like we just need a catalog of

Re: [DISCUSS] KIP-939: Support Participation in 2PC

2024-02-21 Thread Jun Rao
Hi, Artem, Thanks for the reply. 20A. One option is to make the API initTransactions(boolean enable2PC). Then, it's clear from the code whether 2PC related logic should be added. 20B. But realistically, we want Flink (and other apps) to have a single implementation of the 2PC logic, not two

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.7 #97

2024-02-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-1020: Deprecate `window.size.ms` in `StreamsConfig`

2024-02-21 Thread Matthias J. Sax
Thanks for the KIP. Sounds like a nice cleanup. window.size.ms is not a true KafkaStreams config, and results in an error when set from a KStreams application What error? Given that the configs is used by `TimeWindowedDeserializer` I am wondering if we should additionally add public

[jira] [Created] (KAFKA-16295) Align RocksDB and in-memory store inti() sequence

2024-02-21 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16295: --- Summary: Align RocksDB and in-memory store inti() sequence Key: KAFKA-16295 URL: https://issues.apache.org/jira/browse/KAFKA-16295 Project: Kafka

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.6 #144

2024-02-21 Thread Apache Jenkins Server
See

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2664

2024-02-21 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-1019: Expose method to determine Metric Measurability

2024-02-21 Thread Jason Gustafson
+1 Thanks for the KIP! On Wed, Feb 21, 2024 at 9:15 AM Jun Rao wrote: > Hi, Apoorv, > > Thanks for the KIP. +1 > > Jun > > On Mon, Feb 19, 2024 at 2:32 PM Apoorv Mittal > wrote: > > > Hi, > > I’d like to start the voting for KIP-1019: Expose method to determine > > Metric Measurability. > > >

[jira] [Created] (KAFKA-16294) Add group protocol migration enabling config

2024-02-21 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16294: --- Summary: Add group protocol migration enabling config Key: KAFKA-16294 URL: https://issues.apache.org/jira/browse/KAFKA-16294 Project: Kafka Issue Type:

[jira] [Resolved] (KAFKA-15665) Enforce ISR to have all target replicas when complete partition reassignment

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-15665. Resolution: Fixed > Enforce ISR to have all target replicas when complete partition

Re: [DISCUSS] KIP-939: Support Participation in 2PC

2024-02-21 Thread Artem Livshits
Hi Jun, > 20A. This only takes care of the abort case. The application still needs to be changed to handle the commit case properly My point here is that looking at the initTransactions() call it's not clear what the semantics is. Say I'm doing code review, I cannot say if the code is correct

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2024-02-21 Thread Mickael Maison
Hi Jun, Good catch! The new configuration is indeed compression.zstd.level instead of compression.snappy.level. I've updated the KIP. Thanks, Mickael On Wed, Feb 21, 2024 at 7:38 PM Jun Rao wrote: > > Hi, Mickael, > > Thanks for the updated KIP. > > There is a typo. The KIP says that it adds a

Re: [VOTE] KIP-390: Support Compression Level (rebooted)

2024-02-21 Thread Jun Rao
Hi, Mickael, Thanks for the updated KIP. There is a typo. The KIP says that it adds a new option compression.snappy.level, but later says that Snappy is excluded. Otherwise, the changes look good to me. Jun On Wed, Feb 7, 2024 at 6:40 AM Mickael Maison wrote: > Hi Divij, > > Thanks for

[jira] [Resolved] (KAFKA-16194) KafkaConsumer.groupMetadata() should be correct when first records are returned

2024-02-21 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-16194. --- Resolution: Fixed > KafkaConsumer.groupMetadata() should be correct when first records are

Re: [VOTE] KIP-1019: Expose method to determine Metric Measurability

2024-02-21 Thread Jun Rao
Hi, Apoorv, Thanks for the KIP. +1 Jun On Mon, Feb 19, 2024 at 2:32 PM Apoorv Mittal wrote: > Hi, > I’d like to start the voting for KIP-1019: Expose method to determine > Metric Measurability. > > >

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

2024-02-21 Thread Jun Rao
Hi, Apoorv, Thanks for the reply. So it sounds like we could only take further actions on Measurable. Then the new API makes sense. Jun On Wed, Feb 21, 2024 at 4:24 AM Apoorv Mittal wrote: > Hi Jun, > Thanks for reviewing. > > KafkaMetrics uses 2 types of MetricValueProvider as of now i.e.

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
soarez commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1497820259 ## 37/upgrade.html: ## @@ -18,8 +18,85 @@

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
soarez commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1495950924 ## 37/upgrade.html: ## @@ -18,8 +18,85 @@

[jira] [Resolved] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-02-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-16010. Resolution: Duplicate > Fix

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
pprovenzano commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1497677488 ## 37/upgrade.html: ## @@ -18,8 +18,85 @@

[jira] [Created] (KAFKA-16293) Test log directory failure in Kraft

2024-02-21 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-16293: - Summary: Test log directory failure in Kraft Key: KAFKA-16293 URL: https://issues.apache.org/jira/browse/KAFKA-16293 Project: Kafka Issue Type: Test

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

2024-02-21 Thread Apoorv Mittal
Hi Jun, Thanks for reviewing. KafkaMetrics uses 2 types of MetricValueProvider as of now i.e. Measurable and Gauge. Gauge metrics are generally implemented as anonymous inner classes but Measurable has different implementations. KIP-714 ( KafkaMetricsCollector

Re: [PR] 37: remove jbod as missing feature in kraft [kafka-site]

2024-02-21 Thread via GitHub
gaurav-narula commented on PR #584: URL: https://github.com/apache/kafka-site/pull/584#issuecomment-1956441126 Ah my bad. Closing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] 37: remove jbod as missing feature in kraft [kafka-site]

2024-02-21 Thread via GitHub
gaurav-narula closed pull request #584: 37: remove jbod as missing feature in kraft URL: https://github.com/apache/kafka-site/pull/584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
divijvaidya commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1497354965 ## blog.html: ## @@ -22,6 +22,125 @@ Blog + + + +Apache

[jira] [Created] (KAFKA-16292) Revamp upgrade.html page

2024-02-21 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16292: -- Summary: Revamp upgrade.html page Key: KAFKA-16292 URL: https://issues.apache.org/jira/browse/KAFKA-16292 Project: Kafka Issue Type: Improvement

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2663

2024-02-21 Thread Apache Jenkins Server
See Changes: -- [...truncated 2554 lines...] [2024-02-21T10:27:16.284Z] > Task :core:checkstyleMain [2024-02-21T10:27:17.627Z] > Task :shell:checkstyleMain

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1497321697 ## blog.html: ## @@ -22,6 +22,125 @@ Blog + + + +

Re: [PR] 3.7: Add blog post for Kafka 3.7 [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #578: URL: https://github.com/apache/kafka-site/pull/578#discussion_r1497321697 ## blog.html: ## @@ -22,6 +22,125 @@ Blog + + + +

Re: [PR] 37: Add upgrade notes for the 3.7.0 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on PR #581: URL: https://github.com/apache/kafka-site/pull/581#issuecomment-1956386382 Thanks for catching this Ismael. Here is the PR https://github.com/apache/kafka/pull/15406. What I plan to do after I mentioned in

Re: [PR] 37: Add upgrade notes for the 3.7.0 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski closed pull request #581: 37: Add upgrade notes for the 3.7.0 release URL: https://github.com/apache/kafka-site/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] 37: Add upgrade notes for the 3.7.0 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #581: URL: https://github.com/apache/kafka-site/pull/581#discussion_r1497291874 ## 37/upgrade.html: ## @@ -18,8 +18,85 @@

Re: [PR] 37: Add upgrade notes for the 3.7.0 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #581: URL: https://github.com/apache/kafka-site/pull/581#discussion_r1497280308 ## 37/upgrade.html: ## @@ -18,8 +18,85 @@

Re: [PR] MINOR: Update stale `upgrade_3_6_0` header links in documentation [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #580: URL: https://github.com/apache/kafka-site/pull/580#discussion_r1497276374 ## blog.html: ## @@ -55,7 +55,7 @@ 10 Oct 2023 - Satish Duggana (https://twitter.com/0xeed;>@SatishDuggana)

Re: [PR] 37: Add upgrade notes for the 3.7.0 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on PR #581: URL: https://github.com/apache/kafka-site/pull/581#issuecomment-1956351907 I had no idea that's in the apache/kafka repo! Let me open a PR there. In fact, I see a section exists there -- This is an automated message from the Apache Git Service. To

Re: [PR] 37: Add download section for the latest 3.7 release [kafka-site]

2024-02-21 Thread via GitHub
stanislavkozlovski commented on code in PR #583: URL: https://github.com/apache/kafka-site/pull/583#discussion_r1497268896 ## downloads.html: ## @@ -6,12 +6,45 @@ Download -3.6.1 is the latest release. The current stable version is 3.6.1 +3.7.0 is the

[jira] [Created] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
Claudio Benfatto created KAFKA-16291: Summary: Mirrormaker2 wrong checkpoints Key: KAFKA-16291 URL: https://issues.apache.org/jira/browse/KAFKA-16291 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-16290) Investigate propagating subscription state updates via queues

2024-02-21 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-16290: -- Summary: Investigate propagating subscription state updates via queues Key: KAFKA-16290 URL: https://issues.apache.org/jira/browse/KAFKA-16290 Project: Kafka

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2662

2024-02-21 Thread Apache Jenkins Server
See Changes: -- [...truncated 2552 lines...] [2024-02-21T08:22:47.758Z] constructor call into a block. The corresponding AnnotationInfo [2024-02-21T08:22:47.758Z] will