Re: [VOTE] KIP-1038: Add Custom Error Handler to Producer

2024-05-20 Thread Walker Carlson
Hey Alieh, Thanks for the KIP. +1 binding Walker On Tue, May 7, 2024 at 10:57 AM Alieh Saeedi wrote: > Hi all, > > It seems that we have no more comments, discussions, or feedback on > KIP-1038; therefore, I’d like to open voting for the KIP: Add Custom Error > Handler to Producer > < >

[jira] [Created] (KAFKA-16699) Have Streams treat InvalidPidMappingException like a ProducerFencedException

2024-05-10 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-16699: -- Summary: Have Streams treat InvalidPidMappingException like a ProducerFencedException Key: KAFKA-16699 URL: https://issues.apache.org/jira/browse/KAFKA-16699

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-04-30 Thread Walker Carlson
o type parameters . > The nice aspect of this idea is that the option to enable/disable > reprocessing on restore is only needed when a processor supplier is > passed into the methods. That is not true for idea (a). > > > (2) Yes, that was my intent. > > > Best, > Brun

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-04-09 Thread Walker Carlson
better. > >> -- If we want, we could make it somewhat flexible and support both > >> `KeyValueStore` and `TimestampedKeyValueStore` -- ie, the signature > >> would be `KeyValueStore` but we explicitly check if the builder gives > >> us a `TimestampedKeyValu

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-03-28 Thread Walker Carlson
reprocessing using an instance from the customer processor supplier" > >> which > >>> I suppose fixed a long-standing bug ( > >>> https://issues.apache.org/jira/browse/KAFKA-8037) but only for > >>> GlobalKTables and not for normal KTab

[VOTE] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-03-25 Thread Walker Carlson
Hello everybody, I think we have had some pretty good discussion on this kip and it seems that we are close if not yet settled on the final version. So I would like to open up the voting for KIP-1024: https://cwiki.apache.org/confluence/x/E4t3EQ Thanks everyone! Walker

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-03-25 Thread Walker Carlson
ility in naming. Why do you not use > Named for the name of the source node? > > 2. > Did you consider Matthias' proposal to restrict the type of the store > builder to `StoreBuilder` (or even > `StoreBuilder`) for the case where > the processor is built-in? > > >

Re: [DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-03-13 Thread Walker Carlson
Thanks for the feedback Bruno, Matthias, and Lucas! There is a decent amount but I'm going to try and just hit the major points as I would like to keep this change simple. I've made corrections for the mistakes pointed out. Thanks for the suggestions everyone. The main sticking point seems to

[jira] [Created] (KAFKA-16316) Make the restore behavior of GlobalKTables with custom processors configureable

2024-02-29 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-16316: -- Summary: Make the restore behavior of GlobalKTables with custom processors configureable Key: KAFKA-16316 URL: https://issues.apache.org/jira/browse/KAFKA-16316

[DISCUSS] KIP-1024: Make the restore behavior of GlobalKTables with custom processors configureable

2024-02-29 Thread Walker Carlson
Hello everybody, I wanted to propose a change to our addGlobalStore methods so that the restore behavior can be controlled on a preprocessor level. This should help Kafka Stream users to better tune Global stores added with the processor API to better fit their needs. Details are in the kip

Re: [VOTE] KIP-969: Support range interactive queries (IQv2) for versioned state stores

2023-12-13 Thread Walker Carlson
+1 binding Thanks for the KIP Alieh! On Mon, Dec 11, 2023 at 2:14 PM Alieh Saeedi wrote: > Hi everyone, > > Thanks to everyone who has reviewed KIP-969, and participated in the > discussion thread! > > I'd also like to thank you in advance for taking the time to vote. > > Cheers, > Alieh >

Re: [VOTE] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-17 Thread Walker Carlson
+1 (binding_ Thanks! On Tue, Oct 17, 2023 at 3:22 AM Lucas Brutschy wrote: > +1 (binding) > > Thanks for the KIP! > > On Tue, Oct 17, 2023 at 2:31 AM Matthias J. Sax wrote: > > > > +1 (binding) > > > > > > On 10/13/23 9:24 AM, Hanyu (Peter) Zheng wrote: > > > Hello everyone, > > > > > > I

Re: [VOTE] KIP-960: Support single-key_single-timestamp interactive queries (IQv2) for versioned state stores

2023-10-11 Thread Walker Carlson
+1 (binding) Thanks for the kip Alieh! Walker On Wed, Oct 11, 2023 at 3:52 AM Bruno Cadonna wrote: > Thanks for the KIP, Alieh! > > +1 (binding) > > Best, > Bruno > > On 10/10/23 1:14 AM, Matthias J. Sax wrote: > > One more nit: as discussed on the related KIP-698 thread, we should not > >

Re: [DISCUSS] KIP-985 Add reverseRange and reverseAll query over kv-store in IQv2

2023-10-03 Thread Walker Carlson
Hello Hanyu, Looking over your kip things mostly make sense but I have a couple of comments. 1. You have "withDescandingOrder()". I think you mean "descending" :) Also there are still a few places in the do where its called "setReverse" 2. Also I like "WithDescendingKeys()" better

Re: [DISCUSS] KIP-968: Support single-key_multi-timestamp interactive queries (IQv2) for versioned state stores

2023-10-03 Thread Walker Carlson
Hey Alieh thanks for the KIP, Weighing in on the AsOf vs Until debate I think either is fine from a natural language perspective. Personally AsOf makes more sense to me where until gives me the idea that the query is making a change. It's totally a connotative difference and not that important. I

Re: [ANNOUNCE] New committer: Lucas Brutschy

2023-09-21 Thread Walker Carlson
Congrats Lucas! On Thu, Sep 21, 2023 at 11:42 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > Congrats Lucas! > > On Thu, Sep 21, 2023, 22:05 Boudjelda Mohamed Said > wrote: > > > Congratulations, Lucas!! > > > > On Thu 21 Sep 2023 at 18:34, Lianet M. wrote: > > > > >

Re: [DISCUSS] KIP-960: Support interactive queries (IQv2) for versioned state stores

2023-09-11 Thread Walker Carlson
Thanks for the KIP Alieh! I don't have anything to add to the 960 discussion right now as it seems rather straightforward. I think after you address Bruno's comments we can bring it to a vote. I'll review the two spawned KIPs separately. Keep it up, Walker On Wed, Sep 6, 2023 at 5:11 AM Bruno

[jira] [Resolved] (KAFKA-14936) Add Grace Period To Stream Table Join

2023-09-04 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-14936. Resolution: Done > Add Grace Period To Stream Table J

[jira] [Created] (KAFKA-15379) Add option for Grace period Joins to disable changelog creation

2023-08-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-15379: -- Summary: Add option for Grace period Joins to disable changelog creation Key: KAFKA-15379 URL: https://issues.apache.org/jira/browse/KAFKA-15379 Project: Kafka

Re: [VOTE] KIP-759: Unneeded repartition canceling

2023-08-01 Thread Walker Carlson
+1 (binding) On Mon, Jul 31, 2023 at 10:43 PM Matthias J. Sax wrote: > +1 (binding) > > On 7/11/23 11:16 AM, Shay Lin wrote: > > Hi all, > > > > I'd like to call a vote on KIP-759: Unneeded repartition canceling > > The KIP has been under discussion for quite some time(two years). This > is a >

Re: [VOTE] KIP-923: Add A Grace Period to Stream Table Join

2023-06-06 Thread Walker Carlson
hanks for the KIP. > >> > >> I've caught up on the discussion thread and I'm satisfied with all > >> responses. > >> > >> +1(binding) > >> > >> -Bill > >> > >> On Mon, Jun 5, 2023 at 10:20 AM Bruno Cadonna > wrote: > &

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-06-06 Thread Walker Carlson
ords from the stream-side > >> of the > >> join, for which multiple records with the same key should be treated as > >> separate updates will all must be tracked in the buffer, rather than > >> updates which replace each other. > >> > >> Thanks, >

Re: [VOTE] KIP-925: rack aware task assignment in Kafka Streams

2023-06-05 Thread Walker Carlson
+1 (binding) On Mon, Jun 5, 2023 at 3:14 AM Bruno Cadonna wrote: > Hi Hao, > > +1 (binding) > > Thanks! > Bruno > > On 30.05.23 21:16, Colt McNealy wrote: > > +1 (non-binding) > > > > Thank you Hao! > > > > Colt McNealy > > > > *Founder, LittleHorse.dev* > > > > > > On Tue, May 30, 2023 at 9:50 

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-06-02 Thread Walker Carlson
e period". I guess that should be "... will dequeue when > the record timestamp is less than (or equal?) stream time minus the > grace period" > > > 5. > What is the difference between not setting the grace period and setting > it to zero? If there is a

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-06-01 Thread Walker Carlson
posed buffer, affects processing latency? Could you > please add some words about this to the KIP? > > > Best, > Bruno > > > > > On 31.05.23 01:49, Walker Carlson wrote: > > Thanks for all the additional comments. I will either address them here > or > > upd

Re: [DISCUSS] KIP-925: rack aware task assignment in Kafka Streams

2023-05-31 Thread Walker Carlson
Hi Hao, Most of the comments I had on this kip are already mentioned, but I did want to share my two major concerns. 1. Stability. I worry about stability. If we only have the HA assignor work with rack awareness we will have a lot of state movement in many cases. Sophie and Bruno have this

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-05-30 Thread Walker Carlson
able of a stream-table > join is > >> versioned, then the DSL's stream-table join processor will > automatically > >> perform timestamped lookups into the table, in order to take > advantage of > >> the new timestamp-aware store to provide better

[VOTE] KIP-923: Add A Grace Period to Stream Table Join

2023-05-24 Thread Walker Carlson
Hello everybody, I'm opening the vote on KIP-923 here . If we have more to discus please continue the discussion on the existing thread https://www.mail-archive.com/dev@kafka.apache.org/msg130657.html best, Walker

Re: [DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-05-18 Thread Walker Carlson
WindowStoreSupplier`. Would it make sense > >> for `Joined` to have this as well? I can imagine one may want to limit > >> the number of records in the buffer, for example. If we hit the > >> maximum, the only option would be to drop semantic guarantees, but &g

[DISCUSS] KIP-923: Add A Grace Period to Stream Table Join

2023-04-25 Thread Walker Carlson
Hello everybody, I have a stream proposal to improve the stream table join by adding a grace period and buffer to the stream side of the join to allow processing in timestamp order matching the recent improvements of the versioned tables. Please take a look here

[jira] [Created] (KAFKA-14936) Add Grace Period To Stream Table Join

2023-04-25 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-14936: -- Summary: Add Grace Period To Stream Table Join Key: KAFKA-14936 URL: https://issues.apache.org/jira/browse/KAFKA-14936 Project: Kafka Issue Type

Re: [VOTE] KIP-907: Add Boolean Serde to public interface

2023-03-01 Thread Walker Carlson
+1 Binding On Mon, Feb 27, 2023 at 1:46 PM Chia-Ping Tsai wrote: > +1 (binding) >

Re: [VOTE] KIP-904: Kafka Streams - Guarantee subtractor is called before adder if key has not changed

2023-03-01 Thread Walker Carlson
+1 Binding On Mon, Feb 27, 2023 at 12:48 PM Guozhang Wang wrote: > +1. > > On Sun, Feb 26, 2023 at 4:27 PM Fq Public wrote: > > > > Hi everyone, > > > > I'd like to start the vote on KIP-904: Kafka Streams - Guarantee > subtractor > > is called before adder if key has not changed. > > The KIP

Re: [VOTE] KIP-869: Improve Streams State Restoration Visibility

2023-01-24 Thread Walker Carlson
d provide the lowest necessary metrics levels, and > > users can do the roll-ups however they want". > > > >> > >> (6) What about "warmup tasks"? Internally, we treat them as standbys, > >> but it seems it's hard for users to reason about it in

Re: [DISCUSS] KIP-878: Autoscaling for Statically Partitioned Streams

2022-10-25 Thread Walker Carlson
Hey Sophie, Thanks for the KIP. I think this could be useful for a lot of cases. I also think that this could cause a lot of confusion. Just to make sure we are doing our best to prevent people from misusing this feature, I wanted to clarify a couple of things. 1) There will be only an interface

Re: [VOTE] KIP-869: Improve Streams State Restoration Visibility

2022-10-25 Thread Walker Carlson
+1 non binding Thanks for the kip! On Thu, Oct 20, 2022 at 10:25 PM John Roesler wrote: > Thanks for the KIP, Guozhang! > > I'm +1 (binding) > > -John > > On Wed, Oct 12, 2022, at 16:36, Nick Telford wrote: > > Can't wait! > > +1 (non-binding) > > > > On Wed, 12 Oct 2022, 18:02 Guozhang Wang,

Re: [VOTE] KIP-837 Allow MultiCasting a Result Record.

2022-08-09 Thread Walker Carlson
+1 (non binding) Walker On Tue, May 31, 2022 at 4:44 AM Sagar wrote: > Hi All, > > I would like to start a voting thread on > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=211883356 > . > > I am just starting this as the discussion thread has been open for 10+ > days. In

Re: [DISCUSS] KIP-837 Allow MultiCasting a Result Record.

2022-08-09 Thread Walker Carlson
022 at 4:03 PM Sagar wrote: > > > Thanks Walker for the comments > > > > I have updated the KIP with all the suggestions. > > > > Thanks! > > > > On Tue, Jul 12, 2022 at 10:59 PM Walker Carlson > > wrote: > > > >> Hi Sagar, >

Re: [DISCUSS] KIP-837 Allow MultiCasting a Result Record.

2022-07-12 Thread Walker Carlson
Hi Sagar, I just finished reading the KIP and this seems to be a great addition. I agree with Matthias that the interface with a default implementation and deprecating partition() does seem cleaner. It has been a pattern that we have followed in the past. How I would handle a custom streams

Re: [VOTE] KIP-846: Processor-level Streams metrics for records/bytes Producedd

2022-05-31 Thread Walker Carlson
+1 non binding On Tue, May 31, 2022 at 12:19 PM John Roesler wrote: > +1 (binding) > > Thanks, > John > > On Mon, May 30, 2022, at 13:00, Bill Bejeck wrote: > > +1 (binding) > > > > -Bill > > > > On Mon, May 30, 2022 at 4:49 AM Sagar wrote: > > > >> +1 (non-binding). > >> > >> Thanks! > >>

Re: [VOTE] KIP-834: Pause / Resume KafkaStreams Topologies

2022-05-13 Thread Walker Carlson
+1 from me (non-binding) Walker On Wed, May 11, 2022 at 12:36 PM Leah Thomas wrote: > Thanks Jim, great discussion. +1 from me (non-binding) > > Cheers, > Leah > > On Wed, May 11, 2022 at 10:14 AM Bill Bejeck wrote: > > > Thanks for the KIP! > > > > +1 (binding) > > > > -Bill > > > > On Wed,

[jira] [Created] (KAFKA-13676) When processing in ALOS we might as well commit progress made other tasks on a task specific exception

2022-02-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13676: -- Summary: When processing in ALOS we might as well commit progress made other tasks on a task specific exception Key: KAFKA-13676 URL: https://issues.apache.org/jira/browse

Re: [VOTE] KIP-591: Add Kafka Streams config to set default state store

2022-01-20 Thread Walker Carlson
+1 non binding On Thu, Jan 20, 2022 at 2:00 PM Matthias J. Sax wrote: > +1 (binding) > > On 1/20/22 10:52 AM, Guozhang Wang wrote: > > Thanks Luke! I'm +1 on the KIP. > > > > > > Guozhang > > > > On Wed, Jan 19, 2022 at 5:58 PM Luke Chen wrote: > > > >> Hi devs, > >> > >> I'd like to start a

[jira] [Created] (KAFKA-13588) We should consolidate `changelogFor` methods to simplify the generation of internal topic names

2022-01-10 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13588: -- Summary: We should consolidate `changelogFor` methods to simplify the generation of internal topic names Key: KAFKA-13588 URL: https://issues.apache.org/jira/browse/KAFKA

Re: [VOTE] Add TaskId field to StreamsException

2021-10-18 Thread Walker Carlson
Hey Sophie, +1 for me, I think that is would only help. Walker On Mon, Oct 18, 2021 at 1:45 AM Luke Chen wrote: > Hi Sophie, > Add taskId to make the exception much clear is a good improvement. > + 1 (non-binding) > > Thank you. > Luke > > On Mon, Oct 18, 2021 at 12:10 PM Sophie Blee-Goldman

[jira] [Created] (KAFKA-13246) StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAndRemovingStreamThread does not gate on stream state well

2021-08-27 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-13246: -- Summary: StoreQueryIntegrationTest#shouldQueryStoresAfterAddingAndRemovingStreamThread does not gate on stream state well Key: KAFKA-13246 URL: https://issues.apache.org

[jira] [Resolved] (KAFKA-13215) Flaky test org.apache.kafka.streams.integration.TaskMetadataIntegrationTest.shouldReportCorrectEndOffsetInformation

2021-08-24 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-13215. Resolution: Fixed > Flaky t

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-08-09 Thread Walker Carlson
> > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, May 13, 2021 at 6:42 PM Sophie Blee-Goldman < > > > > > > > > sop...@confluent.io> > > > > &

Re: [VOTE] KIP-761: Add Total Blocked Time Metric to Streams

2021-08-02 Thread Walker Carlson
Thanks for the KIP +1 from me (non binding)! Walker On Fri, Jul 30, 2021 at 1:20 PM Sophie Blee-Goldman wrote: > Thanks for updating the KIP, +1 (binding) > > -Sophie > > > On Tue, Jul 27, 2021 at 9:57 AM Guozhang Wang wrote: > > > Hello Rohan, > > > > Thanks for the KIP. As Bruno mentioned

Re: [ANNOUNCE] New Kafka PMC Member: Konstantine Karantasis

2021-06-21 Thread Walker Carlson
Congratulations! On Mon, Jun 21, 2021 at 12:25 PM Dhruvil Shah wrote: > Congratulations Konstantine! Well deserved! > > On Mon, Jun 21, 2021 at 10:20 AM Boyang Chen > wrote: > > > Congratulations Konstantine! > > > > On Mon, Jun 21, 2021 at 10:16 AM Matthias J. Sax > wrote: > > > > >

Re: [VOTE] KIP-741: Change default serde to be null

2021-05-24 Thread Walker Carlson
+1 (non-binding) from me, Leah Walker On Mon, May 24, 2021 at 1:51 PM Leah Thomas wrote: > Hi, > > I'd like to kick-off voting for KIP-741: Change default serde to be null. > < > https://cwiki.apache.org/confluence/display/KAFKA/KIP-741%3A+Change+default+serde+to+be+null > > > The > discussion

[jira] [Created] (KAFKA-12781) Improve the endOffsets accuracy in TaskMetadata

2021-05-13 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12781: -- Summary: Improve the endOffsets accuracy in TaskMetadata Key: KAFKA-12781 URL: https://issues.apache.org/jira/browse/KAFKA-12781 Project: Kafka Issue

Re: [VOTE] KIP-740: Use TaskId instead of String for the taskId field in TaskMetadata

2021-05-13 Thread Walker Carlson
+1 from me! (non-binding) Walker On Thu, May 13, 2021 at 1:53 PM Sophie Blee-Goldman wrote: > Hey all, > > I'm just going to take this KIP straight to a vote since it should be a > trivial and uncontroversial change. Of course please raise any concerns > should they come up, and I can take

[jira] [Created] (KAFKA-12754) TaskMetadata endOffsets does not update when the offsets are read

2021-05-05 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12754: -- Summary: TaskMetadata endOffsets does not update when the offsets are read Key: KAFKA-12754 URL: https://issues.apache.org/jira/browse/KAFKA-12754 Project: Kafka

[jira] [Created] (KAFKA-12711) Add a back off option to Replace thread

2021-04-23 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12711: -- Summary: Add a back off option to Replace thread Key: KAFKA-12711 URL: https://issues.apache.org/jira/browse/KAFKA-12711 Project: Kafka Issue Type

[jira] [Created] (KAFKA-12705) Task idling is not sufficiently tested

2021-04-21 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12705: -- Summary: Task idling is not sufficiently tested Key: KAFKA-12705 URL: https://issues.apache.org/jira/browse/KAFKA-12705 Project: Kafka Issue Type

[jira] [Created] (KAFKA-12699) Streams no longer overrides the java default uncaught exception handler

2021-04-20 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12699: -- Summary: Streams no longer overrides the java default uncaught exception handler Key: KAFKA-12699 URL: https://issues.apache.org/jira/browse/KAFKA-12699

[jira] [Created] (KAFKA-12691) TaskMetadata timeSinceIdlingStarted not reporting correctly

2021-04-19 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12691: -- Summary: TaskMetadata timeSinceIdlingStarted not reporting correctly Key: KAFKA-12691 URL: https://issues.apache.org/jira/browse/KAFKA-12691 Project: Kafka

Re: [VOTE] KIP-633: Drop 24 hour default of grace period in Streams

2021-04-06 Thread Walker Carlson
This makes sense to me +1! Walker On Tue, Apr 6, 2021 at 11:08 AM Guozhang Wang wrote: > +1. Thanks! > > On Tue, Apr 6, 2021 at 7:00 AM Leah Thomas > wrote: > > > Thanks for picking this up, Sophie. +1 from me, non-binding. > > > > Leah > > > > On Mon, Apr 5, 2021 at 9:42 PM John Roesler

[jira] [Created] (KAFKA-12565) Global thread only topologies should be able to shutdown applications via the uncaught exception handler

2021-03-26 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12565: -- Summary: Global thread only topologies should be able to shutdown applications via the uncaught exception handler Key: KAFKA-12565 URL: https://issues.apache.org/jira/browse

[jira] [Created] (KAFKA-12538) Global Threads should be able to be replaced like stream threads

2021-03-23 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12538: -- Summary: Global Threads should be able to be replaced like stream threads Key: KAFKA-12538 URL: https://issues.apache.org/jira/browse/KAFKA-12538 Project: Kafka

[jira] [Created] (KAFKA-12537) Single Threaded EOS applications will not work with SHUTDOWN_APPLICATION

2021-03-23 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12537: -- Summary: Single Threaded EOS applications will not work with SHUTDOWN_APPLICATION Key: KAFKA-12537 URL: https://issues.apache.org/jira/browse/KAFKA-12537 Project

Re: [DISCUSS] Apache Kafka 2.8.0 release

2021-03-19 Thread Walker Carlson
I set its priority to blocker since the bug might break at-least-once > > and exactly-once processing guarantees. > > > > Feel free to set it back to major, if you think that it is not a blocker. > > > > Best, > > Bruno > > > > > > On 13.03.21 00:

[jira] [Created] (KAFKA-12503) Resizing the thread cache in a non thread safe way can cause records to be redirected throughout the topology

2021-03-18 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12503: -- Summary: Resizing the thread cache in a non thread safe way can cause records to be redirected throughout the topology Key: KAFKA-12503 URL: https://issues.apache.org/jira

Re: [DISCUSS] Apache Kafka 2.8.0 release

2021-03-12 Thread Walker Carlson
Hello John, We found a Blocker for 2.8 in our streams soak environment. https://issues.apache.org/jira/browse/KAFKA-12462 - We found a case where a StreamThread can try to transition to PARTITIONS_REVOKED when it was already in PENDING_SHUTDOWN causing an IllegalStateException. Will have a

[jira] [Created] (KAFKA-12462) Threads in PENDING_SHUTDOWN entering a rebalance can cause an illegal state exception

2021-03-12 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12462: -- Summary: Threads in PENDING_SHUTDOWN entering a rebalance can cause an illegal state exception Key: KAFKA-12462 URL: https://issues.apache.org/jira/browse/KAFKA-12462

[jira] [Reopened] (KAFKA-12347) Improve Kafka Streams ability to track progress

2021-03-05 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson reopened KAFKA-12347: > Improve Kafka Streams ability to track progr

Re: [VOTE] KIP-715: Expose Committed offset in streams

2021-03-02 Thread Walker Carlson
t;> On Mon, Mar 1, 2021 at 10:04 AM Leah Thomas > wrote: > >> > >>> Hey Walker, > >>> > >>> Thanks for leading this discussion. +1 from me, non-binding > >>> > >>> Leah > >>> > >>> On Mon, Mar 1, 2021 at 12:37

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-03-02 Thread Walker Carlson
not partial for a > > single local instance). > > > >> Also I mention that they return the highest value they had seen > >> so far for any tasks they have assigned to them. > > > > For the shutdown case maybe, but after a task is closed its metadata > >

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-03-01 Thread Walker Carlson
nce? If yes, this should be > > pointed out, because if one want to implement a health check this needs > > to be taken into account. > > > > -Matthias > > > > > > On 2/27/21 11:32 AM, Walker Carlson wrote: > > > Sure thing Boyang, > > > > > &g

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-02-27 Thread Walker Carlson
ust as why we > don't choose to expose as metrics, and how a new method on KStream is not > favorable. These would be valuable when we look back on our design > decisions. > > On Fri, Feb 26, 2021 at 11:23 AM Walker Carlson > wrote: > > > I understand now. I think that is a

[VOTE] KIP-715: Expose Committed offset in streams

2021-02-26 Thread Walker Carlson
Hello all, I would like to bring KIP-715 to a vote. Here is the KIP: https://cwiki.apache.org/confluence/x/aRRRCg. Walker

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-02-26 Thread Walker Carlson
gets the > assigned topology and should be able to infer all the exact tasks to be up > and running when the service is healthy. > > On Thu, Feb 25, 2021 at 11:25 AM Walker Carlson > wrote: > > > Thanks for the follow up Boyang and Guozhang, > > > > I have updated the k

[jira] [Resolved] (KAFKA-12362) Determine if a Task is idling

2021-02-26 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-12362. Resolution: Abandoned > Determine if a Task is idl

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-02-25 Thread Walker Carlson
feel we have a better way to achieve this, such as querying all the > > input/intermediate topic metadata directly from Kafka for the baseline, I > > think that should be good as well and worth mentioning it in the KIP. > > > > Also it seems that the KIP hasn't reflected what you prop

Re: [DISCUSS] KIP-715: Expose Committed offset in streams

2021-02-24 Thread Walker Carlson
for all “supposed to be running” tasks, > > so that on the metrics collector side it could catch any missing tasks. > > > > 5. It seems not clear how users should use `isTaskIdling`. Why not > report a > > map/set for idling tasks just as what we did for committed offsets?

[DISCUSS] KIP-715: Expose Committed offset in streams

2021-02-22 Thread Walker Carlson
Hello all, I would like to start discussion on KIP-715. This kip aims to make it easier to monitor Kafka Streams progress by exposing the committed offset in a similar way as the consumer client does. Here is the KIP: https://cwiki.apache.org/confluence/x/aRRRCg Best, Walker

[jira] [Created] (KAFKA-12362) Determine if a Task is idling

2021-02-22 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12362: -- Summary: Determine if a Task is idling Key: KAFKA-12362 URL: https://issues.apache.org/jira/browse/KAFKA-12362 Project: Kafka Issue Type: Improvement

[jira] [Created] (KAFKA-12347) Improve Kafka Streams ability to track progress

2021-02-19 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12347: -- Summary: Improve Kafka Streams ability to track progress Key: KAFKA-12347 URL: https://issues.apache.org/jira/browse/KAFKA-12347 Project: Kafka Issue

[jira] [Resolved] (KAFKA-4640) Improve Streams unit test coverage

2021-02-03 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-4640. --- Resolution: Fixed > Improve Streams unit test cover

[jira] [Resolved] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2021-01-29 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson resolved KAFKA-10015. Resolution: Fixed > React Smartly to Unexpected Errors on Stream Thre

[jira] [Created] (KAFKA-12247) Make removeStreamThread work better with static membership

2021-01-28 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12247: -- Summary: Make removeStreamThread work better with static membership Key: KAFKA-12247 URL: https://issues.apache.org/jira/browse/KAFKA-12247 Project: Kafka

[jira] [Created] (KAFKA-12184) Once the Error Classification is better update the default streams uncaught exception handler to replace threads

2021-01-12 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-12184: -- Summary: Once the Error Classification is better update the default streams uncaught exception handler to replace threads Key: KAFKA-12184 URL: https://issues.apache.org/jira

Re: [DISCUSS] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-20 Thread Walker Carlson
> document. > > > > You talk about SHUTDOWN_CLIENT in the KIP, but never explain that it is > > a possible action that can be taken in the Streams uncaught exception > > handler. Could you please clarify that? > > > > Best, > > Bruno > > > &g

Re: [VOTE] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-14 Thread Walker Carlson
gt; > Leah > > > > > > On Wed, Dec 9, 2020 at 1:04 PM John Roesler > wrote: > > > > > >> Thanks, Walker! > > >> > > >> I'm also +1 (binding) > > >> > > >> -John > > >> > > >> On Wed

Re: [VOTE] KIP-695: Improve Streams Time Synchronization

2020-12-11 Thread Walker Carlson
Thanks for the KIP! +1 (non-binding) walker On Wed, Dec 9, 2020 at 11:40 AM Bruno Cadonna wrote: > Thanks for the KIP, John! > > +1 (non-binding) > > Best, > Bruno > > On 08.12.20 18:03, John Roesler wrote: > > Hello all, > > > > There hasn't been much discussion on KIP-695 so far, so I'd > >

Re: [VOTE] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-09 Thread Walker Carlson
Sorry I forgot to change the subject line to vote. Thanks for the comments. If there are no further concerns I would like to call for a vote on KIP-696 to clarify and clean up the Streams State Machine. On Wed, Dec 9, 2020 at 10:04 AM Walker Carlson wrote: > Thanks for the comme

Re: [DISCUSS] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-09 Thread Walker Carlson
> On Tue, 2020-12-08 at 18:29 -0800, Walker Carlson wrote: > > Thanks for the feedback Guozhang! > > > > I clarified some of the points in the Proposed Changes section so > hopefully > > it will be more clear what is going on now. I also agree with your > > sugge

Re: [DISCUSS] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-08 Thread Walker Carlson
IRA" field? > > https://issues.apache.org/jira/browse/KAFKA-10555 > https://issues.apache.org/jira/browse/KAFKA-9638 > https://issues.apache.org/jira/browse/KAFKA-6520 > > And maybe we can also left a comment on those tickets explaining what would > happen to tackle the iss

[DISCUSS] KIP-696: Update Streams FSM to clarify ERROR state meaning

2020-12-08 Thread Walker Carlson
Hello all, I'd like to propose KIP-696 to clarify the meaning of ERROR state in the KafkaStreams Client State Machine. This will update the States to be consistent with changes in KIP-671 and KIP-663. Here are the details: https://cwiki.apache.org/confluence/x/lCvZCQ Thanks, Walker

[jira] [Created] (KAFKA-10810) Add a replace thread option to the streams uncaught exception handler

2020-12-04 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-10810: -- Summary: Add a replace thread option to the streams uncaught exception handler Key: KAFKA-10810 URL: https://issues.apache.org/jira/browse/KAFKA-10810 Project

Re: [VOTE] KIP-689: Extend `StreamJoined` to allow more store configs

2020-12-02 Thread Walker Carlson
+1 (non-binding) Thank you, walker On Wed, Dec 2, 2020 at 8:15 AM Bruno Cadonna wrote: > +1 (non-binding) > > Thanks Leah! > > Best, > Bruno > > On 02.12.20 16:55, Leah Thomas wrote: > > Hi all, > > > > I'd like to start the vote for KIP-689 for enabling/disabling logging for > >

Re: [DISCUSS] KIP-689: Extend `StreamJoined` to allow more store configs

2020-12-01 Thread Walker Carlson
On Mon, Nov 30, 2020 at 5:35 PM Matthias J. Sax > wrote: > > > > > Thanks for the KIP Leah. > > > > > > Should `withLoggingEnabled()` take a `Map config` > > > similar to the one from `Materialized`? > > > > > > > > > -Matthias > >

Re: [DISCUSS] KIP-689: Extend `StreamJoined` to allow more store configs

2020-11-30 Thread Walker Carlson
r false. I've removed the `WindowBytesStoreSupplier otherStoreSupplier` > from the methods in the KIP > 2. I think the fix to 1 answers this question, otherwise, I'm not quite > sure what you're asking. With the updated method calls, there shouldn't be > any duplication. > > Cheers, > Leah &

Re: [DISCUSS] KIP-689: Extend `StreamJoined` to allow more store configs

2020-11-30 Thread Walker Carlson
Hello Leah, Thank you for the KIP. I had a couple questions that maybe you can expand on from what is on the KIP. 1) Why are we enabling/disabling the logging by passing in a `WindowBytesStoreSupplier`? It seems to me that these two things should be separate. 2) There is already

[jira] [Created] (KAFKA-10705) Avoid World Readable RocksDB

2020-11-10 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-10705: -- Summary: Avoid World Readable RocksDB Key: KAFKA-10705 URL: https://issues.apache.org/jira/browse/KAFKA-10705 Project: Kafka Issue Type: Bug

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-19 Thread Walker Carlson
at the global thread doesn’t have > “replace”, > > > but as of today, none of the threads have “replace”. Why not add that > > > ability when we add it for the other threads? > > > > > > The nature of an uncaught exception handler is that there is

Re: [ANNOUNCE] New committer: A. Sophie Blee-Goldman

2020-10-19 Thread Walker Carlson
Congratulations Sophie! On Mon, Oct 19, 2020 at 9:43 AM Navinder Brar wrote: > That's great news. Congrats Sophie! Well deserved. > > Regards, > Navinder > On Monday, 19 October, 2020, 10:12:16 pm IST, Bruno Cadonna < > br...@confluent.io> wrote: > > Congrats Sophie! Very well deserved! >

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-13 Thread Walker Carlson
e the best > > user experience: for example, if there is no global thread, one should > > not need to implement the global handler method (and the other way > around). > > > > Thus, it might be good to add default for both methods. If we add > > defaults, we sh

Re: [VOTE] KIP-671: Add method to Shutdown entire Streams Application

2020-10-12 Thread Walker Carlson
/diffpagesbyversion.action?pageId=158876566=21=23 If you have any problems with these changes let me know and we can discuss them further Thank you, Walker On Wed, Sep 30, 2020 at 7:33 AM Walker Carlson wrote: > > Bruno Cadonna > 4:51 AM (2 hours ago) > to dev > Thank you all for voting! > >

  1   2   >