[GitHub] kafka pull request #4345: KAFKA-6390: Update ZooKeeper to 3.4.11, Gradle and...

2017-12-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4345 KAFKA-6390: Update ZooKeeper to 3.4.11, Gradle and other minor updates Updates: - Gradle, gradle plugins and maven artifact updated - Bug fix updates for ZooKeeper, Jackson, EasyMock

[GitHub] kafka pull request #4297: KAFKA-6317: Maven artifact for kafka should not de...

2017-12-06 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4297 KAFKA-6317: Maven artifact for kafka should not depend on log4j It should only depend on slf4j-api (like kafka-clients). The release tarball still includes log4j and slf4j-log4j12

[GitHub] kafka pull request #4283: (WIP) KAFKA-6193: Flaky shouldPerformMultipleReass...

2017-12-01 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4283 (WIP) KAFKA-6193: Flaky shouldPerformMultipleReassignmentOperationsOverVariousTopics I have been unable to reproduce it locally, so enabled additional logging while running it in Jenkins

[GitHub] kafka pull request #4265: KAFKA-6065: Latency metric for KafkaZkClient

2017-11-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4265 KAFKA-6065: Latency metric for KafkaZkClient Measures the latency of each request batch. Updated existing `ZkUtils` test to use `KafkaZkClient` instead. ### Committer Checklist

[GitHub] kafka pull request #4262: MINOR: Temporarily disable testLogStartOffsetCheck...

2017-11-24 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4262 MINOR: Temporarily disable testLogStartOffsetCheckpoint It's failing often and it seems like there are multiple reasons. PR #4238 will re-enable it. ### Committer Checklist (excluded from

[GitHub] kafka pull request #4261: MINOR: Avoid intermediate strings when parsing/dec...

2017-11-24 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4261 MINOR: Avoid intermediate strings when parsing/decoding ZK JSON Also: - Fix bug in result type of `createSequentialPersistentPath` - Remove duplicated code from `ReplicationUtils` - Move

[GitHub] kafka pull request #4250: KAFKA-6261: Fix exception thrown by request loggin...

2017-11-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4250 KAFKA-6261: Fix exception thrown by request logging if acks=0 Only expect responseAsString to be set if request logging is enabled _and_ responseSend is defined. Also fixed a couple

[GitHub] kafka pull request #4220: KAFKA-6210: IllegalArgumentException if 1.0.0 is u...

2017-11-15 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4220 KAFKA-6210: IllegalArgumentException if 1.0.0 is used for inter.broker.protocol.version or log.message.format.version Added unit test for ApiVersion and testApiVersions from Scala to Java

[GitHub] kafka pull request #4219: MINOR: Fix NPE in unregisterPartitionReassignmentI...

2017-11-15 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4219 MINOR: Fix NPE in unregisterPartitionReassignmentIsrChangeHandlers I was looking at a transient failures of `shouldPerformMultipleReassignmentOperationsOverVariousTopics` and came across a NPE

[GitHub] kafka pull request #4202: MINOR: Exclude Committer Checklist section from co...

2017-11-10 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4202 MINOR: Exclude Committer Checklist section from commit message ### Committer Checklist - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] kafka pull request #4201: MINOR: Exclude PULL_REQUEST_TEMPLATE.md from rat c...

2017-11-10 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4201 MINOR: Exclude PULL_REQUEST_TEMPLATE.md from rat checks ### Committer Checklist - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] kafka pull request #551: KAFKA-2858; Introduce `SimplePrincipal` and use it ...

2017-11-10 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/551 ---

[GitHub] kafka pull request #4200: MINOR: Update to Scala 2.11.12 (part 2)

2017-11-09 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4200 MINOR: Update to Scala 2.11.12 (part 2) Missed a few places in the previous commit. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[GitHub] kafka pull request #4192: MINOR: Remove unnecessary batch iteration in FileR...

2017-11-08 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4192 MINOR: Remove unnecessary batch iteration in FileRecords.downConvert You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka avoid

[GitHub] kafka pull request #4185: MINOR: Update Scala 2.11 to 2.11.12

2017-11-06 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4185 MINOR: Update Scala 2.11 to 2.11.12 The main change is Java 9 support. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka scala-2.11.12

[GitHub] kafka pull request #4174: MINOR: Add pull request template

2017-11-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4174 MINOR: Add pull request template You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka pull-request-template Alternatively you can review

[GitHub] kafka pull request #4172: MINOR: Remove clients/out directory

2017-11-02 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4172 MINOR: Remove clients/out directory It was committed inadvertently. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka remove-out-folder

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

2017-11-01 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148400321 --- Diff: 100/javadoc/script.js --- @@ -1,30 +0,0 @@ -function show(type) -{ -count = 0; -for (var key in methods

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

2017-11-01 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148393662 --- Diff: 10/documentation.html --- @@ -69,15 +69,15 @@ 8. Kafka Connect -9. Kafka Streams +9. Kafka Streams

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

2017-11-01 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148303796 --- Diff: downloads.html --- @@ -9,48 +9,75 @@ You can verify your download by following these http://www.apache.org/info

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

2017-11-01 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148303944 --- Diff: downloads.html --- @@ -9,48 +9,75 @@ You can verify your download by following these http://www.apache.org/info

[GitHub] kafka-site pull request #107: MINOR: Follow-up Update on 1.0.0 release

2017-11-01 Thread ijuma
Github user ijuma commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/107#discussion_r148303219 --- Diff: 10/documentation.html --- @@ -0,0 +1,83 @@ + + +<!--#include virtual="js/templat

[GitHub] kafka pull request #4158: KAFKA-2903: FileRecords.read doesn't handle size >...

2017-10-30 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4158 KAFKA-2903: FileRecords.read doesn't handle size > sizeInBytes when start is not zero You can merge this pull request into a Git repository by running: $ git pull https://github.com/ij

[GitHub] kafka pull request #4154: KAFKA-4203: Align broker default for max.message.b...

2017-10-28 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4154 KAFKA-4203: Align broker default for max.message.bytes with Java producer default You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[GitHub] kafka pull request #4152: MINOR: Eliminate unnecessary Topic(And)Partition a...

2017-10-28 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4152 MINOR: Eliminate unnecessary Topic(And)Partition allocations in Controller - Eliminated all the unnecessary allocations of `TopicPartition` and `TopicAndPartition` in the Controller. We now use

[GitHub] kafka pull request #4144: MINOR: Ensure that the producer in testAlterReplic...

2017-10-27 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4144 MINOR: Ensure that the producer in testAlterReplicaLogDirs is always closed Failure to close the producer could cause a transient failure, more details below. The request timeout was only

[GitHub] kafka pull request #4143: MINOR: PartitionReassignmentHandler should generat...

2017-10-27 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4143 MINOR: PartitionReassignmentHandler should generate event only when znode is created and eliminate unnecessary allocations As suggested by Jun in https://github.com/apache/kafka/pull/4141, we

[GitHub] kafka pull request #4142: MINOR: Use Scala Future in CoreUtils test

2017-10-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4142 MINOR: Use Scala Future in CoreUtils test Also rename UtilsTest to CoreUtilsTest and note that `getOrElseUpdate` has the right behaviour in Scala 2.12. You can merge this pull request

[GitHub] kafka pull request #4138: MINOR: Revert EmbeddedZooKeeper rename

2017-10-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4138 MINOR: Revert EmbeddedZooKeeper rename Even though this class is internal, it's widely used by other projects and it's better to avoid breaking them until we have a publicly supported test

[GitHub] kafka pull request #4117: MINOR: Configure owasp.dependencycheck gradle plug...

2017-10-23 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4117 MINOR: Configure owasp.dependencycheck gradle plugin It seems to output a few false positives, but still worth verifying. You can merge this pull request into a Git repository by running

[GitHub] kafka pull request #4112: MINOR: Rename ZookeeperClient to ZooKeeperClient a...

2017-10-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4112 MINOR: Rename ZookeeperClient to ZooKeeperClient and move it to kafka.zookeeper You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[GitHub] kafka pull request #4102: MINOR: Update Scala to 2.12.4

2017-10-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4102 MINOR: Update Scala to 2.12.4 Mainly for Java 9 fixes and improved compilation times (5-10% reduction). You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka pull request #4097: MINOR: Update docs with regards to max.in.flight a...

2017-10-19 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4097 MINOR: Update docs with regards to max.in.flight and idempotent producer The idempotent producer doesn't change that setting any more and the accepted range has changed. You can merge this pull

[GitHub] kafka pull request #4088: MINOR: Controller and async ZookeeperClient improv...

2017-10-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4088 MINOR: Controller and async ZookeeperClient improvements (WIP) More to come. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka async

[GitHub] kafka pull request #4087: MINOR: Remove dead code

2017-10-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4087 MINOR: Remove dead code You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka remove-dead-code Alternatively you can review and apply

[GitHub] kafka pull request #4067: MINOR: Merge script improvements

2017-10-12 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4067 MINOR: Merge script improvements - Remove "list commits" since we never use it - Fix release branch detection to just look for branches that start with digits - Make script execu

[GitHub] kafka pull request #4066: MINOR: Don't register signal handlers if running o...

2017-10-12 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4066 MINOR: Don't register signal handlers if running on Windows Also remove stray printStackTrace in test. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] kafka pull request #4040: KAFKA-5829; Remove stray `printStackTrace()` in te...

2017-10-08 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4040 KAFKA-5829; Remove stray `printStackTrace()` in test You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5829-follow-up

[GitHub] kafka pull request #4034: MINOR: Remove TLS renegotiation code

2017-10-06 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4034 MINOR: Remove TLS renegotiation code This has been disabled since the start and since it's removed in TLS 1.3, there are no plans to ever support it. You can merge this pull request

[GitHub] kafka pull request #4023: KAFKA-5829: Only delete producer snapshots before ...

2017-10-05 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4023 KAFKA-5829: Only delete producer snapshots before the recovery point You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5829

[GitHub] kafka pull request #4016: MINOR: Simplify log cleaner and fix compiler warni...

2017-10-04 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4016 MINOR: Simplify log cleaner and fix compiler warnings - Simplify LogCleaner.cleanSegments and add comment regarding thread unsafe usage of `LogSegment.append`. This was a result of investigating

[GitHub] kafka pull request #4007: MINOR: Java 9 version handling improvements

2017-10-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/4007 MINOR: Java 9 version handling improvements - Upgrade Gradle to 4.2.1, which handles Azul Zulu 9's version correctly. - Add tests to our Java version handling code - Refactor the code

[GitHub] kafka pull request #3996: KAFKA-5746; Return 0.0 from Metric.value() instead...

2017-09-29 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3996 KAFKA-5746; Return 0.0 from Metric.value() instead of throwing exception This is less likely to break custom metric reporters and since the method is deprecated, people will be warned about

[GitHub] kafka pull request #3989: KAFKA-5746; Fix conversion count computed in `down...

2017-09-28 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3989 KAFKA-5746; Fix conversion count computed in `downConvert` It should be the number of records instead of the number of batches. A few additional clean-ups: minor renames, removal

[GitHub] kafka pull request #3954: KAFKA-5758: Don't fail fetch request if replica is...

2017-09-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3954 KAFKA-5758: Don't fail fetch request if replica is no longer a follower for a partition We log a warning instead, which is what we also do if the partition hasn't been created yet. You can

[GitHub] kafka pull request #3945: MINOR: Move ChannelState.exception() to its own cl...

2017-09-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3945 MINOR: Move ChannelState.exception() to its own class Given that Java doesn't support pattern matching, the benefit is not as clear. Also implemented ChannelState.toString and removed

[GitHub] kafka pull request #3930: KAFKA-5856; AdminClient.createPartitions() follow-...

2017-09-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3930 KAFKA-5856; AdminClient.createPartitions() follow-up (KIP-195) - Remove DelayedCreatePartitions to reduce code duplication - Avoid unnecessary ZK calls (call it once per request instead

[GitHub] kafka pull request #3923: MINOR: Upgrade to Gradle 4.2

2017-09-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3923 MINOR: Upgrade to Gradle 4.2 It includes the usual performance improvements, but the nicest improvement for me is that the findBugs plugin no longer outputs almost 1000 lines in Jenkins

[GitHub] kafka pull request #3910: MINOR: Only include transactional id in LogContext...

2017-09-19 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3910 MINOR: Only include transactional id in LogContext if it's set You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka transactional-id

[GitHub] kafka pull request #3901: MINOR: Fix unresolvable address in `testUnresolvab...

2017-09-19 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3901 MINOR: Fix unresolvable address in `testUnresolvableConnectString` Before this change, the test always failed on my MacBook Pro. You can merge this pull request into a Git repository by running

[GitHub] kafka pull request #3895: MINOR: Protocol schema refactor follow-up

2017-09-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3895 MINOR: Protocol schema refactor follow-up Minor clean-ups from the review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka protocol

[GitHub] kafka pull request #3890: MINOR: Fix replica_verification_tool.py to handle ...

2017-09-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3890 MINOR: Fix replica_verification_tool.py to handle slight change in output format The string representation of TopicPartition was changed to be {topic}-{partitition} consistently in the following

[GitHub] kafka pull request #3881: MINOR: Update powermock and enable its tests when ...

2017-09-17 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3881 MINOR: Update powermock and enable its tests when running with Java 9 Also fix WorkerTest to use the correct `Mock` annotations. `org.easymock.Mock` is not supported by PowerMock 2.x. You can

[GitHub] kafka pull request #3879: KAFKA-5915: Support unmapping of mapped/direct buf...

2017-09-15 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3879 KAFKA-5915: Support unmapping of mapped/direct buffers in Java 9 As mentioned in MappedByteBuffers' class documentation, its implementation was inspired by Lucene's MMapDirectory: https

[GitHub] kafka pull request #3609: MINOR: Make the state change log more consistent

2017-09-15 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/3609 ---

[GitHub] kafka pull request #3869: MINOR: Make the state change log more consistent

2017-09-15 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3869 MINOR: Make the state change log more consistent Use logIdent to achieve this. Also fixed an issue where we were logging about replicas going offline with an empty set of replicas (i.e

[GitHub] kafka pull request #3856: MINOR: Remove unused SecurityProtocol.TRACE

2017-09-14 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3856 MINOR: Remove unused SecurityProtocol.TRACE It adds complexity for no benefit since we don't use it anywhere. Also removed a few unused imports, variables and default parameters. You

[GitHub] kafka pull request #3845: KAFKA-4501: Fix EasyMock and disable PowerMock tes...

2017-09-13 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3845 KAFKA-4501: Fix EasyMock and disable PowerMock tests under Java 9 - EasyMock 3.5 supports Java 9. - Removed unnecessary PowerMock dependency from 3 tests. - Disable remaining PowerMock tests

[GitHub] kafka pull request #3844: MINOR: Use sha512 instead of sha2 suffix in releas...

2017-09-13 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3844 MINOR: Use sha512 instead of sha2 suffix in release artifacts As per Apache guidelines: http://www.apache.org/dev/release-distribution#sigs-and-sums You can merge this pull request

[GitHub] kafka pull request #3834: MINOR: Tweak detection of kafka server start-up in...

2017-09-11 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3834 MINOR: Tweak detection of kafka server start-up in system tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka tweak-system-test

[GitHub] kafka pull request #3808: MINOR: Always specify the keystore type in system ...

2017-09-07 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3808 MINOR: Always specify the keystore type in system tests Also throw an exception if a null keystore type is seen in `SecurityStore`. This should never happen. The default keystore type has

[GitHub] kafka pull request #3801: MINOR: Include response in request log

2017-09-06 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3801 MINOR: Include response in request log It's implemented such that there is no overhead if request logging is disabled. Also: - Reduce metrics computation duplication

[GitHub] kafka pull request #3789: MINOR: Fix a couple of ftp related issues in relea...

2017-09-05 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3789 MINOR: Fix a couple of ftp related issues in release.py You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka ftp-release-py-fixes

[GitHub] kafka pull request #3738: KAFKA-5790: SocketServer.processNewResponses shoul...

2017-08-25 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/3738 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3738: MINOR: Remove try/finally from processNewResponses

2017-08-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3738 MINOR: Remove try/finally from processNewResponses The previous code would skip a response if an exception was thrown. You can merge this pull request into a Git repository by running: $ git

[GitHub] kafka pull request #3734: KAFKA-5785; Always close connection if KafkaChanne...

2017-08-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3734 KAFKA-5785; Always close connection if KafkaChannel.setSend throws exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka

[GitHub] kafka-site issue #71: KAFKA-4869: Update 0.10.2.0 upgrade notes

2017-08-25 Thread ijuma
Github user ijuma commented on the issue: https://github.com/apache/kafka-site/pull/71 Thanks for the PR, we also need to fix it in the main repo: https://github.com/apache/kafka/blob/0.10.2/docs/upgrade.html#L90 --- If your project is set up for it, you can reply to this email

[GitHub] kafka pull request #3706: KAFKA-5753: ShellTest.testRunProgramWithErrorRetur...

2017-08-21 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3706 KAFKA-5753: ShellTest.testRunProgramWithErrorReturn fails on macOS You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka fix-shell-test-mac

[GitHub] kafka pull request #3658: MINOR: AdminClient should register with `AppInfoPa...

2017-08-11 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3658 MINOR: AdminClient should register with `AppInfoParser` Also make "created" message more consistent across clients. You can merge this pull request into a Git repository by running:

[GitHub] kafka pull request #3647: KAFKA-4501: Java 9 compilation fixes

2017-08-08 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3647 KAFKA-4501: Java 9 compilation fixes Compilation fixes: - Avoid ambiguity error when appending to Properties in Scala code - Use position() and limit() to fix ambiguity issue - Disable

[GitHub] kafka pull request #3634: MINOR: Deprecate LogConfig.Compact

2017-08-07 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3634 MINOR: Deprecate LogConfig.Compact It actually refers to the `delete` cleanup policy. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[GitHub] kafka pull request #3619: MINOR: Update dependencies for 1.0.0 release

2017-08-03 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3619 MINOR: Update dependencies for 1.0.0 release Notable updates: 1. Gradle 4.1 includes a number of performance and CLI improvements as well as initial Java 9 support. There's also

[GitHub] kafka pull request #3609: MINOR: Only log about marking replicas as offline ...

2017-08-02 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3609 MINOR: Only log about marking replicas as offline if there is a replica I noticed a bunch of these log messages with an empty set for the replicas. You can merge this pull request into a Git

[GitHub] kafka pull request #3596: MINOR: Null out all buffer references in RequestCh...

2017-07-29 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3596 MINOR: Null out all buffer references in RequestChannel.Request The previous code kept two references to `Buffer` and only nulled out one of them. You can merge this pull request into a Git

[GitHub] kafka pull request #3595: MINOR: Request log should be enabled by debug leve...

2017-07-29 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3595 MINOR: Request log should be enabled by debug level At some point, we lost the ability to output request logging at debug level (which is a little less verbose than at trace level). You can

[GitHub] kafka pull request #3579: Bump version to 0.11.0.1-SNAPSHOT

2017-07-28 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/3579 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3587: MINOR: Support versions with 3 segments in _kafka_...

2017-07-27 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3587 MINOR: Support versions with 3 segments in _kafka_jar_versions The bump from 0.11.1.0-SNAPSHOT to 1.0.0-SNAPSHOT broker a couple of tests: * TestVerifiableProducer.test_simple_run

[GitHub] kafka pull request #3580: MINOR: Next release will be 1.0.0

2017-07-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3580 MINOR: Next release will be 1.0.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka bump-to-1.0.0-SNAPSHOT Alternatively you can

[GitHub] kafka pull request #3579: Bump version to 0.11.0.1-SNAPSHOT

2017-07-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3579 Bump version to 0.11.0.1-SNAPSHOT You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka bump-to-0.11.0.1-SNAPSHOT Alternatively you can

[GitHub] kafka pull request #3572: MINOR: Remove unused GroupState.state field

2017-07-25 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3572 MINOR: Remove unused GroupState.state field This field doesn't seem to be used and the value for `AwaitingSync` seems to be wrong (it seems like it should have been `2` instead of `5`). You

[GitHub] kafka pull request #3562: MINOR: Improve log warning to include the log name

2017-07-21 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3562 MINOR: Improve log warning to include the log name You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka tweak-log-warning Alternatively

[GitHub] kafka pull request #3560: MINOR: Improve log warning to include the log name

2017-07-21 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/3560 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3561: MINOR: Give correct instructions for retaining pre...

2017-07-21 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3561 MINOR: Give correct instructions for retaining previous unclear leader election behaviour You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma

[GitHub] kafka pull request #3560: MINOR: Improve log warning to include the log name

2017-07-21 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3560 MINOR: Improve log warning to include the log name You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka tweak-log-and-upgrade-note

[GitHub] kafka pull request #3553: KAFKA-5608: Follow-up to fix potential NPE and cla...

2017-07-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3553 KAFKA-5608: Follow-up to fix potential NPE and clarify method name You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka kafka-5608-follow

[GitHub] kafka pull request #3552: MINOR: Simplify SensorAccess usage

2017-07-20 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3552 MINOR: Simplify SensorAccess usage I was investigating an exception in this code and found a few opportunities for making it clearer. I also added the `out` folder to `.gitignore

[GitHub] kafka pull request #3543: MINOR: Remove flaky assertion in verifyCloseOldest...

2017-07-18 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3543 MINOR: Remove flaky assertion in verifyCloseOldestConnectionWithStagedReceives This seems to fail a lot in Jenkins although it always passes locally for me. Removing the assertion to restore

[GitHub] kafka pull request #3527: MINOR: Mention systemTestLibs in docker system tes...

2017-07-14 Thread ijuma
Github user ijuma closed the pull request at: https://github.com/apache/kafka/pull/3527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3527: MINOR: Mention systemTestLibs in docker system tes...

2017-07-14 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3527 MINOR: Mention systemTestLibs in docker system test instructions Otherwise NoClassFoundExceptions are thrown for tests that attempt to start MiniKdc. You can merge this pull request into a Git

[GitHub] kafka pull request #3503: KAFKA-5570: Join request's timeout should be sligh...

2017-07-07 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3503 KAFKA-5570: Join request's timeout should be slightly higher than the rebalance timeout - Introduce per request timeouts in NetworkClient - Use rebalanceTimeout + 5s for join request timeout

[GitHub] kafka pull request #3501: MINOR: Improve versioning in docs when a full vers...

2017-07-07 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3501 MINOR: Improve versioning in docs when a full version is required Also fix quickstart. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka

[GitHub] kafka-site issue #64: MINOR: Add release dates to downloads page

2017-07-06 Thread ijuma
Github user ijuma commented on the issue: https://github.com/apache/kafka-site/pull/64 Good idea. As you said, the dates seem to differ slightly from: https://issues.apache.org/jira/browse/KAFKA/?selectedTab=com.atlassian.jira.jira-projects-plugin:versions-panel It would

[GitHub] kafka pull request #3464: MINOR: Enable a number of xlint scalac warnings

2017-06-29 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3464 MINOR: Enable a number of xlint scalac warnings Update the code where possible to fix the warnings. The unused warning introduced in Scala 2.12 is quite handy and provides a reason to compile

[GitHub] kafka pull request #3454: MINOR: Compatibility and upgrade tests for 0.11.0....

2017-06-28 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3454 MINOR: Compatibility and upgrade tests for 0.11.0.x You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka test-upgrades-from-0.11.0.x

[GitHub] kafka pull request #3451: MINOR: Implement `toString` in some Validator inst...

2017-06-28 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3451 MINOR: Implement `toString` in some Validator instances This is used in the generated config table. Also fix a couple of typos in the process. You can merge this pull request into a Git

[GitHub] kafka pull request #3446: MINOR: Improve TransactionIndex.sanityCheck() mess...

2017-06-27 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3446 MINOR: Improve TransactionIndex.sanityCheck() message You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka improve-transaction-index

[GitHub] kafka pull request #3431: MINOR: Adjust checkstyle suppression paths to work...

2017-06-26 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3431 MINOR: Adjust checkstyle suppression paths to work on Windows Use the file name whenever possible and replace / with [/\\] when it's not. Also remove unnecessary suppresions. You can

[GitHub] kafka pull request #3422: MINOR: SaslChannelBuilder should be idempotent

2017-06-23 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3422 MINOR: SaslChannelBuilder should be idempotent You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka sasl-channel-builder-idempotent

[GitHub] kafka pull request #3420: KAFKA-5506: Fix NPE in OffsetFetchRequest.toString

2017-06-23 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3420 KAFKA-5506: Fix NPE in OffsetFetchRequest.toString Also avoid eager toString call in parameter passed to log.debug. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] kafka pull request #3409: MINOR: Switch ZK client logging to INFO

2017-06-22 Thread ijuma
GitHub user ijuma opened a pull request: https://github.com/apache/kafka/pull/3409 MINOR: Switch ZK client logging to INFO You can merge this pull request into a Git repository by running: $ git pull https://github.com/ijuma/kafka tweak-log-config Alternatively you can

  1   2   3   4   5   >