Re: [DISCUSS] Adding non-committers as Github collaborators

Hello again, all, FYI, I've just opened a request for clarification on the ability to trigger builds: https://issues.apache.org/jira/browse/INFRA-24673 Thanks, -John On Tue, Jun 6, 2023, at 19:11, Hao Li wrote: > Thanks John for looking into this! > > Hao > > On Tue, Jun 6, 2023 at 8:32 AM

Re: [DISCUSS] Adding non-committers as Github collaborators

Thanks John for looking into this! Hao On Tue, Jun 6, 2023 at 8:32 AM John Roesler wrote: > Hello all, > > I put in a ticket with Apache Infra to re-send these invites, and they > told me I should just remove the usernames in one commit and then re-add > them in a subsequent commit to trigger

Re: [DISCUSS] Adding non-committers as Github collaborators

Got the invite and was able to accept. Thanks a lot John! On Tue, Jun 6, 2023 at 6:11 PM Greg Harris wrote: > John, > > I saw the invite be re-sent, and accepted it. > > Thanks for following up! > Greg > > On Tue, Jun 6, 2023 at 3:08 PM John Roesler wrote: > > > > Hello Greg, Andrew, and

Re: [DISCUSS] Adding non-committers as Github collaborators

John, I saw the invite be re-sent, and accepted it. Thanks for following up! Greg On Tue, Jun 6, 2023 at 3:08 PM John Roesler wrote: > > Hello Greg, Andrew, and Victoria, > > I have just re-added you to the file, so you should receive new invites. > Please let us know if you have any trouble!

Re: [DISCUSS] Adding non-committers as Github collaborators

Hello Greg, Andrew, and Victoria, I have just re-added you to the file, so you should receive new invites. Please let us know if you have any trouble! Thanks, -John On Tue, Jun 6, 2023, at 10:31, John Roesler wrote: > Hello all, > > I put in a ticket with Apache Infra to re-send these invites,

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi Divij, Interesting; perhaps they didn't need to send you an invite because your github account is already associated with another Apache project? The actions you listed are the things that the collaborator role gives you, so I think you're good to go. Thanks, -John On Tue, Jun 6, 2023, at

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey John What does the invite do? I did not receive any invite either but I have been able to add labels, close PRs etc. since I was added to the contributors list (perhaps because I already have an apache LDAP account?). I am working with the assumption that things are working for me even if I

Re: [DISCUSS] Adding non-committers as Github collaborators

Hello all, I put in a ticket with Apache Infra to re-send these invites, and they told me I should just remove the usernames in one commit and then re-add them in a subsequent commit to trigger the invites again. I will go ahead and do this for the users who requested it on this thread (Greg

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi Luke, Sorry for the late reply. Can you also add me to the whitelist? I believe I'm supposed to be there as well. Matthias and John can vouch for me :) My github ID is "lihaosky". Thanks, Hao On Fri, Jun 2, 2023 at 4:43 PM Greg Harris wrote: > Luke, > > I see that the PR has been merged,

Re: [DISCUSS] Adding non-committers as Github collaborators

Luke, I see that the PR has been merged, but I don't believe it re-sent the invitation. Thanks Greg On Wed, May 31, 2023 at 6:46 PM Luke Chen wrote: > > Hi Greg and Andrew, > > Sorry, I don't know how to re-sent the invitation. > It looks like it is auto sent after the .asf.yaml updated. >

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi Greg and Andrew, Sorry, I don't know how to re-sent the invitation. It looks like it is auto sent after the .asf.yaml updated. Since updating collaborator list is part of release process based on the doc , I just created a new list and opened a PR:

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi all, Like Greg I also received an invitation to collaborate but was too slow to accept the invite :( I'm also wondering if there's a way to resend the invite? I'm andymg3 on GitHub. Thanks, Andrew On Tue, May 30, 2023 at 12:12 PM Greg Harris wrote: > Hey all, > > I received an invitation to

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey all, I received an invitation to collaborate on apache/kafka, but let the invitation expire after 7 days. Is there a workflow for refreshing the invite, or is an admin able to manually re-invite me? I'm gharris1727 on github. Thanks! Greg On Wed, May 24, 2023 at 9:32 AM Justine Olshan

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey Yash, I'm not sure how it used to be for sure, but I do remember we used to have a different build system. I wonder if this used to work with the old build system and not any more. I'd be curious if other projects have something similar and how it works. Thanks, Justine On Wed, May 24, 2023

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi Justine, Thanks for the response. Non-committers don't have Apache accounts; are you suggesting that there wasn't a need to sign in earlier and a change in this policy is restricting collaborators from triggering Jenkins builds? Thanks, Yash On Wed, May 24, 2023 at 9:30 PM Justine Olshan

Re: [DISCUSS] Adding non-committers as Github collaborators

Yash, When I rebuild, I go to the CloudBees CI page and I have to log in with my apache account. Not sure if the change in the build system or the need to sign in is part of the problem. On Wed, May 24, 2023 at 4:54 AM Federico Valeri wrote: > +1 on Divij suggestions > > > On Wed, May 24,

Re: [DISCUSS] Adding non-committers as Github collaborators

+1 on Divij suggestions On Wed, May 24, 2023 at 12:04 PM Divij Vaidya wrote: > > Hey folks > > A week into this experiment, I am finding the ability to add labels, > request for reviewers and ability to close PRs very useful. > > 1. May I suggest an improvement to the process by requesting for

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey folks, Are there any additional steps required in order to be able to trigger Jenkins builds on pull requests? The seemingly relevant link in the asf.yaml file appears to be a dead one - https://github.com/apache/kafka/blob/5b3b385881d5518ef1b2c63cb55244cf80a80da2/.asf.yaml#L25 (else it's a

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey folks A week into this experiment, I am finding the ability to add labels, request for reviewers and ability to close PRs very useful. 1. May I suggest an improvement to the process by requesting for some guidance on the interest areas for various committers. This would help us request for

Re: [DISCUSS] Adding non-committers as Github collaborators

Hello again, all, Just a quick update: after merging the changes to asf.yaml, I received a notification that the list is limited to only 10 people, not 20 as the documentation states. Here is the list of folks who will now be able to triage PRs and trigger builds: Victoria Xia, Greg Harris,

Re: [DISCUSS] Adding non-committers as Github collaborators

Hey folks, Thanks for driving this initiative! I think the ability to assign reviewers / apply labels to PRs and re-trigger Jenkins builds is really useful and will also allow us to help out the community a bit more. Thanks, Yash On Fri, May 12, 2023 at 9:24 PM John Roesler wrote: > Thanks

Re: [DISCUSS] Adding non-committers as Github collaborators

Thanks again for bringing this up, David! As an update to the community, the PMC has approved a process to make use of this feature. Here are the relevant updates: PR to add the policy: https://github.com/apache/kafka-site/pull/510 PR to update the list:

Re: [DISCUSS] Adding non-committers as Github collaborators

Just to clarify, the re-triggering of Jenkins jobs would be controlled via the "jenkins: github_whitelist:" YAML section which we already made use of. I definitely agree that we should leverage this more to make it easy for collaborators to trigger builds. Regarding the 20 collaborators limit,

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi all, opinion from a regular person here: I think being able to re-trigger jenkin's test and tagging can be very helpful for a lot of times. On Fri, Apr 28, 2023 at 9:31 AM John Roesler wrote: > Hi all, > > This is a great suggestion! It seems like a really good way to make the > Apache Kafka

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi all, This is a great suggestion! It seems like a really good way to make the Apache Kafka project more efficient in general and also smooth the path to committership. I've brought the topic up with the Apache Kafka PMC to consider adopting a policy around the "collaborator" rule. In the

Re: [DISCUSS] Adding non-committers as Github collaborators

I'm also a bit concerned by the 20 active collaborators rule. How do we pick the 20 people? Justine On Fri, Apr 28, 2023 at 8:36 AM Matthias J. Sax wrote: > In general I am +1 > > The only question I have is about > > > You may only have 20 active collaborators at any given time per >

Re: [DISCUSS] Adding non-committers as Github collaborators

In general I am +1 The only question I have is about You may only have 20 active collaborators at any given time per repository. Not sure if this is a concern or not? I would assume not, but wanted to bring it to everyone's attention. There is actually also a way to allow people to

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi David, That makes sense. I think that we have been doing this with a few folks. The more interesting question is how do we decide who could get added as a collaborator? Best, David On Fri, Apr 28, 2023 at 4:42 AM Luke Chen wrote: > Hi David, > > Thanks for the suggestion. I'm +1. > This is

Re: [DISCUSS] Adding non-committers as Github collaborators

Hi David, Thanks for the suggestion. I'm +1. This is also a good way to show appreciation from Kafka community to some great contributors who haven't qualified to become committers. Luke On Fri, Apr 28, 2023 at 2:45 AM David Arthur wrote: > Hey folks, > > I stumbled across this wiki page from

[DISCUSS] Adding non-committers as Github collaborators

Hey folks, I stumbled across this wiki page from the infra team that describes the various features supported in the ".asf.yaml" file: https://cwiki.apache.org/confluence/display/INFRA/Git+-+.asf.yaml+features One section that looked particularly interesting was