Hi all,
While testing the patch [1], realised that introducing a
new REMOTE_STORAGE_NOT_READY error-code
is not compatible with the consumer. Consumer does not retry the FETCH
request for all the retriable
exceptions [2] instead it retries only for specific error codes. Dropping
the KIP-1007
Thank you for addressing my concerns Kamal. Though, instead of the KIP, I
actually was suggesting to add it in JavaDoc so that someone looking at the
exception is able to understand what it means. We can discuss that during
the PR review though.
The KIP looks good to me.
--
Divij Vaidya
On
Thanks for the KIP Kamal, LGTM.
On Tue, 26 Dec 2023 at 10:23, Kamal Chandraprakash
wrote:
>
> Hi Divij,
>
> Thanks for reviewing the KIP! I've updated the KIP with the below
> documentation. Let me know if it needs to be changed:
>
> The consumer can read the local data as long as it knows the
Hi Divij,
Thanks for reviewing the KIP! I've updated the KIP with the below
documentation. Let me know if it needs to be changed:
The consumer can read the local data as long as it knows the offset from
where to fetch the data from.
When there is no initial offset, the consumer decides the
Thanks for the KIP, Kamal.
The change looks good to me, though, I think we can do a better job at
documenting what the error means for the clients and users.
Correct me if I'm wrong, when remote metadata is being synced on a new
leader, we cannot fetch even the local data (as per [1]), hence,
Thanks Luke for reviewing this KIP!
If there are no more comments from others, I'll start the VOTE since this
is a minor KIP.
On Mon, Dec 11, 2023 at 1:01 PM Luke Chen wrote:
> Hi Kamal,
>
> Thanks for the KIP!
> LGTM.
>
> Thanks.
> Luke
>
> On Wed, Nov 22, 2023 at 7:28 PM Kamal Chandraprakash
Hi Kamal,
Thanks for the KIP!
LGTM.
Thanks.
Luke
On Wed, Nov 22, 2023 at 7:28 PM Kamal Chandraprakash <
kamal.chandraprak...@gmail.com> wrote:
> Hi,
>
> I would like to start a discussion to introduce a new error code for
> retriable remote storage errors. Please take a look at the proposal:
>
Hi,
I would like to start a discussion to introduce a new error code for
retriable remote storage errors. Please take a look at the proposal:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
