Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-02-02 Thread Omnia Ibrahim
I noticed you have something addressed in the rejected alternatives in your KIP regarding KIP-690, however, as the KIP is implementing one of the previous rejected alternatives for KIP-690 I think it would be nice to update the motivation section in the new KIP with some clarification for why

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-02-02 Thread Omnia Ibrahim
Hi Thanks for the KIP. I don’t know if you had a look before into the rejection alternatives in KIP-690

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-22 Thread Chris Egerton
Hi Berci, Thanks for the KIP! IMO we don't need the "default." prefix for the new property, and it deviates a bit from the precedent set by properties like "replication.policy.internal.topic.separator.enabled". I think we can just call it "replication.policy.heartbeats.topic", or if we really

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-18 Thread Kondrát Bertalan
Hi Viktor, Let me address your points one by one. 1. The current implementation does not support the source->target pair based configuration, it is global. 2. Yes, I introduced that property both in the client and in the connectors 3. This is a great idea, I am going to do that,

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-17 Thread Viktor Somogyi-Vass
Hi Bertalan, Thanks for creating this KIP. A couple of observations/questions: 1. If I have multiple source->target pairs, can I set this property per cluster by prefixing with "source->target" as many other configs or is it global? 2. The replication policy must be set in MirrorClient as well.

Re: [DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-16 Thread Ryanne Dolan
Makes sense to me, +1. On Tue, Jan 16, 2024 at 5:04 PM Kondrát Bertalan wrote: > Hey Team, > > I would like to start a discussion thread about the *KIP-1016 Make MM2 > heartbeats topic name configurable > < >

[DISCUSS] KIP-1016 Make MM2 heartbeats topic name configurable

2024-01-16 Thread Kondrát Bertalan
Hey Team, I would like to start a discussion thread about the *KIP-1016 Make MM2 heartbeats topic name configurable * . This KIP aims to make the default heartbeat topic name (`heartbeats`) in