> I have added comments to your PR (
> https://github.com/apache/kafka/pull/15999#pullrequestreview-2066823538)
>
> in short, `sourcePartition` and `sourceOffset` are unused if
> emit.offset-syncs.enabled=false
I’ll have a look into the PR.
Also regarding my previous comment on
> Which SourceRecord are you referring to here?
I have added comments to your PR (
https://github.com/apache/kafka/pull/15999#pullrequestreview-2066823538)
in short, `sourcePartition` and `sourceOffset` are unused if
emit.offset-syncs.enabled=false
BTW, I'm +1 to this KIP, and I noticed my
Hi Chia-Ping
> It seems we can disable the sync of idle consumers by setting
> `sync.group.offsets.interval.seconds` to -1, so the fail-fast should include
> sync.group.offsets.interval.seconds too. For another, maybe we should do
> fail-fast for MirrorCheckpointConnector even though we don't
Nice KIP. some minor comments/questions are listed below.
1) It seems we can disable the sync of idle consumers by setting
`sync.group.offsets.interval.seconds` to -1, so the fail-fast should include
sync.group.offsets.interval.seconds too. For another, maybe we should do
fail-fast for
Hi Chris,
Validation method is a good call. I updated the KIP to state that the
checkpoint connector will fail if the configs aren’t correct. And updated the
description of the new config to explain the impact of it on checkpoint
connector as well.
If there is no any other feedback from
Hi Omnia,
Ah, good catch. I think failing to start the checkpoint connector if offset
syncs are disabled is fine. We'd probably want to do that via the
Connector::validate [1] method in order to be able to catch invalid configs
during preflight validation, but it's not necessary to get that
Thanks Chris for the feedback
> 1. It'd be nice to mention that increasing the max offset lag to INT_MAX
> could work as a partial workaround for users on existing versions (though
> of course this wouldn't prevent creation of the syncs topic).
I updated the KIP
> 2. Will it be illegal to disable
Hi Omnia,
Thanks for the KIP! Two small things come to mind:
1. It'd be nice to mention that increasing the max offset lag to INT_MAX
could work as a partial workaround for users on existing versions (though
of course this wouldn't prevent creation of the syncs topic).
2. Will it be illegal to
Hi Omnia,
Thanks for the KIP!
It LGTM!
But I'm not an expert of MM2, it would be good to see if there is any other
comment from MM2 experts.
Thanks.
Luke
On Thu, Mar 14, 2024 at 6:08 PM Omnia Ibrahim
wrote:
> Hi everyone, I would like to start a discussion thread for KIP-1031:
> Control
Hi everyone, I would like to start a discussion thread for KIP-1031:
Control offset translation in MirrorSourceConnector
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1031%3A+Control+offset+translation+in+MirrorSourceConnector
Thanks
Omnia
10 matches
Mail list logo
