Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-28 Thread Chris Egerton
 No further comments from me. On Thu, Mar 28, 2024, 19:36 Ivan Yurchenko wrote: > Hello Chris, > > Thanks for your feedback. I created the jira and also updated the > description a bit mentioning that other similar race scenarios exist and > the KIP is not trying to solve them. > > Best, >

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-28 Thread Ivan Yurchenko
Hello Chris, Thanks for your feedback. I created the jira and also updated the description a bit mentioning that other similar race scenarios exist and the KIP is not trying to solve them. Best, Ivan On Wed, Mar 27, 2024, at 17:08, Chris Egerton wrote: > Hi Ivan, > > Thanks for the updates.

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-27 Thread Chris Egerton
Hi Ivan, Thanks for the updates. LGTM! RE atomicity: I think it should be possible and not _too_ invasive to detect and handle these kinds of races by tracking the offset in the config topic for connector configs and aborting an operation if that offset changes between when the request was

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-27 Thread Ivan Yurchenko
Hi, I updated the KIP with the two following changes: 1. Using `null` values as tombstone value for removing existing fields from configuration. 2. Added a note about the lack of 100% atomicity, which seems very difficult to achieve practically. Ivan On Tue, Mar 26, 2024, at 14:45, Ivan

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-26 Thread Ivan Yurchenko
Speaking of the Chris' comment > One thought that comes to mind is that sometimes it may be useful to > explicitly remove properties from a connector configuration. We might > permit this by allowing users to specify null (the JSON literal, not a > string containing the characters "null") as the

RE: Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2024-03-26 Thread Ivan Yurchenko
Hi all, This KIP is a bit old now :) but I think its context hasn't changed much since then and the KIP is still valid. I would like to finally bring it to some conclusion. Best, Ivan On 2021/07/12 14:49:47 Chris Egerton wrote: > Hi all, > > Know it's been a while for this KIP but in my

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2021-07-12 Thread Chris Egerton
Hi all, Know it's been a while for this KIP but in my personal experience the value of a PATCH method in the REST API has actually increased over time and I'd love to have this option for quick, stop-the-bleeding remediation efforts. One thought that comes to mind is that sometimes it may be

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2019-06-28 Thread Ivan Yurchenko
Thank you for your feedback Ryanne! These are all surely valid concerns and PATCH isn't really necessary or suitable for normal production configuration management. However, there are cases where quick patching of the configuration is useful, such as hot fixes of production or in development.

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2019-06-26 Thread Ryanne Dolan
Ivan, I looked at adding PATCH a while ago as well. I decided not to pursue the idea for a few reasons: 1) PATCH is still racy. For example, if you want to add a topic to the "topics" property, you still need to read, modify, and write the existing value. To handle this, you'd need to support

Re: [DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2019-06-25 Thread Ivan Yurchenko
Hi, Since Kafka 2.3 has just been release and more people may have time to look at this now, I'd like to bump this discussion. Thanks. Ivan On Thu, 13 Jun 2019 at 17:20, Ivan Yurchenko wrote: > Hello, > > I'd like to start the discussion of KIP-477: Add PATCH method for > connector config in

[DISCUSS] KIP-477: Add PATCH method for connector config in Connect REST API

2019-06-13 Thread Ivan Yurchenko
Hello, I'd like to start the discussion of KIP-477: Add PATCH method for connector config in Connect REST API. https://cwiki.apache.org/confluence/display/KAFKA/KIP-477%3A+Add+PATCH+method+for+connector+config+in+Connect+REST+API There is also a draft PR: