Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Hi Sophie, Sorry for the late comments. Thanks for the KIP. One question from me: In test plan section, you mentioned we'll have benchmark for potential performance regression. And in the end, you said: See #2 under Rejected Alternatives for more on this. But I didn't find there's #2 in

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks Guozhang -- I'll definitely make sure we have this benchmarked with an eye for any regressions before it makes it into a release. That said, if it's any comfort, we use the cached system time and record only count and sum type metrics, so unlike the *-rate *metrics for example we don't have

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks Sophie, that makes sense. Also I agree that since we are adding it at finest granularity for consumed metrics, it's better to have symmetry and add produced metrics at processor-node level as well. Regarding the benchmarks, I think that would be critical to have before we add in the next

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

I just want to send out a small update -- I decided to include the "- *consumed*" metrics in the KIP alongside the *"-produced"* metrics after all, for reasons I address in the paragraph I added at the end of the motivation section. Please let me know if you have any questions or concerns Cheers,

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

> > Just a quick question: for filling the gap of sub-topology visibilities, > would task-level produced metrics be sufficient? If I understand your question correctly, you're asking whether we could just report at the task/subtopology level since we mainly want the bytes/throughput produced by

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Hi Sophie, Just a quick question: for filling the gap of sub-topology visibilities, would task-level produced metrics be sufficient? On Mon, May 30, 2022 at 10:59 AM Bill Bejeck wrote: > Thanks for the KIP Sophie. > > I'm in favor of this change as well. I don't have any comments in > addition

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks for the KIP Sophie. I'm in favor of this change as well. I don't have any comments in addition to the ones already expressed. -Bill On Mon, May 30, 2022 at 4:55 AM Sagar wrote: > Hi Sophie, > > A very minor comment but you might want to remove this KIP template related > information

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Hi Sophie, A very minor comment but you might want to remove this KIP template related information from the top of the KIP: *This page is meant as a template for writing a KIP . To create a KIP choose Tools->Copy on

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

> > Why does the title of the KIP talk about task-level metrics, but the > specified metrics are on processor-level? Ah, my mistake -- it should indeed say "processor-level metrics". Thanks for the catch Bruno, the title has been fixed. Since there don't seem to be any concerns I'll proceed

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks for the KIP, Sophie! I am also in favor of this KIP! I have one minor question: Why does the title of the KIP talk about task-level metrics, but the specified metrics are on processor-level? For the rest, I am +1. Best, Bruno On 29.05.22 00:20, John Roesler wrote: Thanks for the

Re: [DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Thanks for the well motivated and documented KIP, Sophie! I’m in favor of this change. -John On Sat, May 28, 2022, at 06:42, Sophie Blee-Goldman wrote: > Hey all, > > I'd like to propose a very small KIP to add two metrics that will help fill > a gap in the derivable produced and consumed

[DISCUSS] KIP-846: Task-level Streams metrics for bytes/records Produced

Hey all, I'd like to propose a very small KIP to add two metrics that will help fill a gap in the derivable produced and consumed metrics. Please take a look and reply here with any questions or concerns. KIP-846: Task-level Streams metrics for bytes/records Produced