Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

2023-02-23 Thread spacrocket
Hello Matthias, Thanks for looking into my first KIP. I’ve updated the confluence document and soon I will start voting. Kind regards Jakub > On Feb 23, 2023, at 8:23 AM, Matthias J. Sax wrote: > > Thanks for the KIP. > > Overall LGMT. > > One comment: Both `BooleanSerializer` and

Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

2023-02-23 Thread SpacRocket
Hello Matthias, Thanks for looking into my KIP and for an advice. I’ve added BooleanSerializer and BooleanDeserializer to the Public Interfaces. Kind regards Jakub > On Feb 23, 2023, at 8:23 AM, Matthias J. Sax wrote: > > Thanks for the KIP. > > Overall LGMT. > > One comment: Both

Re: [DISCUSS] KIP-907: Add Boolean Serde to public interface

2023-02-22 Thread Matthias J. Sax
Thanks for the KIP. Overall LGMT. One comment: Both `BooleanSerializer` and `BooleanDeserializer` are also new classes that are added and should be listed explicitly similar to `BooleanSerde` in the "Public Interfaces" section of the KIP. -Matthias On 2/21/23 10:52 AM, SpacRocket wrote:

[DISCUSS] KIP-907: Add Boolean Serde to public interface

2023-02-21 Thread SpacRocket
Hello Everyone, I’d like to get a discussion going for KIP-907: https://cwiki.apache.org/confluence/display/KAFKA/KIP-907%3A+Add+Boolean+Serde+to+public+interface Which adds Boolean Serde to the public interface. The KIP contains the details how I want to do this and what internal code I need