Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-12-04 Thread Hanyu (Peter) Zheng
Thank you Alieh, After discussion with Matthias, we decide use oldTimeFrom and oldTimeTo(these two will Deprecated soom) to implement withWindowStartRange() and use timeFrom and timeTo to implement withAllKey() and withKeyRange(), I will update the KIP. Sincerely, Hanyu On Sun, Dec 3, 2023 at

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-12-03 Thread Alieh Saeedi
Thanks, Hanyu, for the KIP and all the updates. I just do not understand the purpose of defining new time ranges (`newTimeFrom`, `newTimeTo`). Why don't we simply re-use the existing time range variables? Bests, Alieh On Thu, Nov 30, 2023 at 8:34 PM Hanyu (Peter) Zheng wrote: > new KIP link: >

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-30 Thread Hanyu (Peter) Zheng
new KIP link: https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++update+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery On Wed, Nov 29, 2023 at 10:12 PM Hanyu (Peter) Zheng wrote: > Thank you Bruno, > 1. Thank you for the notification. I have updated the ticket link >

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-29 Thread Hanyu (Peter) Zheng
Thank you Bruno, 1. Thank you for the notification. I have updated the ticket link accordingly. 2. Certainly, I'll update the KIP name. Should I initiate a new discussion for it, because if I change the name, the link will change. 3. Understood, I will add that to the KIP. 4. I propose we accept

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-29 Thread Bruno Cadonna
Hi, Thanks for the updates! 1. Could you please link the correct ticket in the KIP? 2. Could you please adapt the motivation section and the title to the updated goal of the KIP? There is no fetch() or fetchAll() method in the query class. 3. Could you please add the "// newly added"

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-16 Thread Matthias J. Sax
Thanks for the KIP. Given how `WindowRangeQuery` works right now, it's really time to improve it. 1) Agree. It's not clear what will be added right now. I think we should deprecate existing `getKey()` w/o an actually replacement? For `getFromKey` and `getToKey` we should actually be

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-16 Thread Bruno Cadonna
Hi Hanyu, Thanks for the KIP! 1) Could you please mark the pieces that you want to add to the API in the code listing in the KIP? You can add a comment like "// newly added" or similar. That would make reading the KIP a bit easier because one does not need to compare your code with the code

Re: [DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-08 Thread Hanyu (Peter) Zheng
Hello everyone, I would like to start the discussion for KIP-997: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery The KIP can be found here:

[DISCUSS] KIP-997 Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery

2023-11-08 Thread Hanyu (Peter) Zheng
https://cwiki.apache.org/confluence/display/KAFKA/KIP-997%3A++Support+fetch%28fromKey%2C+toKey%2C+from%2C+to%29+to+WindowRangeQuery+and+unify+WindowKeyQuery+and+WindowRangeQuery -- [image: Confluent] Hanyu (Peter) Zheng he/him/his Software Engineer Intern +1 (213)