Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-05 Thread Ted Yu
+1 to moving to Mockito On Fri, Oct 5, 2018 at 12:11 PM Ron Dagostino wrote: > I have used Mockito and am a big fan -- I had never used EasyMock until > recently. The concept of record vs. replay mode in EasyMock really annoyed > me -- I'm a fan of the "NO MODES" idea ( >

Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-05 Thread Ismael Juma
Agreed, I really liked the fact that Mockito has no "replay" concept. Ismael On Fri, 5 Oct 2018, 12:11 Ron Dagostino, wrote: > I have used Mockito and am a big fan -- I had never used EasyMock until > recently. The concept of record vs. replay mode in EasyMock really annoyed > me -- I'm a fan

Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-05 Thread Ron Dagostino
I have used Mockito and am a big fan -- I had never used EasyMock until recently. The concept of record vs. replay mode in EasyMock really annoyed me -- I'm a fan of the "NO MODES" idea ( https://en.wikipedia.org/wiki/Larry_Tesler), and when I encountered it in EasyMock in the context of Kafka

Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-05 Thread Ismael Juma
So far, it seems like people are in favour. If no objections are presented in the next couple of days, we will go ahead with the change. Ismael On Sun, 30 Sep 2018, 20:32 Ismael Juma, wrote: > Hi all, > > As described in KAFKA-7438 > ,

Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-02 Thread Rajini Sivaram
Hi Ismael, Thanks for starting this discussion. I had a quick look at the PR and I agree that the updated tests are more readable. So +1 from me. On Tue, Oct 2, 2018 at 12:06 AM Colin McCabe wrote: > +1. It would be good to standardize on one (well-maintained) mocking > library in the project

Re: [DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-10-01 Thread Colin McCabe
+1. It would be good to standardize on one (well-maintained) mocking library in the project :) best, Colin On Sun, Sep 30, 2018, at 20:32, Ismael Juma wrote: > Hi all, > > As described in KAFKA-7438 > , EasyMock's development > has stagnated.

[DISCUSS] Replacing EasyMock with Mockito in Kafka

2018-09-30 Thread Ismael Juma
Hi all, As described in KAFKA-7438 , EasyMock's development has stagnated. This presents a number of issues: 1. Blocks us from running tests with newer Java versions, which is a frequent occurrence give the new Java release cadence. It is the