Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

Hi, Apoorv, Thanks for the reply. So it sounds like we could only take further actions on Measurable. Then the new API makes sense. Jun On Wed, Feb 21, 2024 at 4:24 AM Apoorv Mittal wrote: > Hi Jun, > Thanks for reviewing. > > KafkaMetrics uses 2 types of MetricValueProvider as of now i.e.

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

Hi Jun, Thanks for reviewing. KafkaMetrics uses 2 types of MetricValueProvider as of now i.e. Measurable and Gauge. Gauge metrics are generally implemented as anonymous inner classes but Measurable has different implementations. KIP-714 ( KafkaMetricsCollector

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

Hi, Apoorv, Thanks for the KIP. Could we document how we plan to use the new isMeasurable() method? For example, gauge is another type of metric. Do we plan to add an isGauge() method too? If so, is it better to add a separate method for each metric type or is it better to have a single method

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

Thanks for the KIP. Seems there is not much we need to discuss about it. Feel free to start a VOTE. -Matthias On 2/15/24 7:24 AM, Manikumar wrote: LGTM, Thanks for the KIP. On Thu, Feb 15, 2024 at 8:50 PM Doğuşcan Namal wrote: LGTM thanks for the KIP. +1(non-binding) On Wed, 14 Feb 2024

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

LGTM, Thanks for the KIP. On Thu, Feb 15, 2024 at 8:50 PM Doğuşcan Namal wrote: > LGTM thanks for the KIP. > > +1(non-binding) > > On Wed, 14 Feb 2024 at 15:22, Andrew Schofield < > andrew_schofield_j...@outlook.com> wrote: > > > Hi Apoorv, > > Thanks for the KIP. Looks like a useful change to

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

LGTM thanks for the KIP. +1(non-binding) On Wed, 14 Feb 2024 at 15:22, Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi Apoorv, > Thanks for the KIP. Looks like a useful change to tidy up the metrics code. > > Thanks, > Andrew > > > On 14 Feb 2024, at 14:55, Apoorv Mittal >

Re: [Discuss] KIP-1019: Expose method to determine Metric Measurability

Hi Apoorv, Thanks for the KIP. Looks like a useful change to tidy up the metrics code. Thanks, Andrew > On 14 Feb 2024, at 14:55, Apoorv Mittal wrote: > > Hi, > I would like to start discussion of a small KIP which fills a gap in > determining Kafka Metric measurability. > > KIP-1019: Expose

[Discuss] KIP-1019: Expose method to determine Metric Measurability

Hi, I would like to start discussion of a small KIP which fills a gap in determining Kafka Metric measurability. KIP-1019: Expose method to determine Metric Measurability Regards,