Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

The KIP is accepted with 4 binding votes (Chirs, Divij Vaidya, David and Luke) and 4 unbinding votes(Kamal, Federico, Andrew and Николай Ижиков). Thank you all ! > On Jan 24, 2024, at 20:44, Николай Ижиков wrote: > > +1 (non-binding) > >> 24 янв. 2024 г., в 12:48, Chris Egerton написал(а):

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

+1 (non-binding) > 24 янв. 2024 г., в 12:48, Chris Egerton написал(а): > > Thanks Ziming! +1 (binding) > > On Wed, Jan 24, 2024, 03:23 ziming deng wrote: > >> Thank you for reminding this, David, >> >> I have mentioned this in the [Compatibility] section as a following work. >> >> --, >>

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Thanks Ziming! +1 (binding) On Wed, Jan 24, 2024, 03:23 ziming deng wrote: > Thank you for reminding this, David, > > I have mentioned this in the [Compatibility] section as a following work. > > --, > Best, > Ziming > > > On Jan 23, 2024, at 15:17, David Jacot > wrote: > > > > Hi Chris,

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Thank you for reminding this, David, I have mentioned this in the [Compatibility] section as a following work. --, Best, Ziming > On Jan 23, 2024, at 15:17, David Jacot wrote: > > Hi Chris, Ziming, > > Thanks for the clarification. I am glad that it does not impact the tool. > It may be

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hello Ismael, I have tested it locally to verified again that this issue only affect append/subtract, I also commented in the JIRA ticket to clarify this. Best, Ziming > On Jan 23, 2024, at 23:07, Ismael Juma wrote: > > Hi Ziming, > > Have you verified that the issue only impacts

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hi Ziming, Have you verified that the issue only impacts append/subtract? The way I read the JIRA is that the issue currently affects all operations for plugins, but it can be fixed to only affect append/subtract (where it would be harder to fix). It would be good to verify the current state.

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

+1 (binding) I have participated in the discussion for this and looked at the most recent version of this KIP. It looks good to me. -- Divij Vaidya On Tue, Jan 23, 2024 at 8:17 AM David Jacot wrote: > Hi Chris, Ziming, > > Thanks for the clarification. I am glad that it does not impact the

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hi Chris, Ziming, Thanks for the clarification. I am glad that it does not impact the tool. It may be worth adding a note about it in the KIP to avoid the same question in the future. Otherwise, I am +1 (binding). Thanks for driving this! Best, David On Tue, Jan 23, 2024 at 6:07 AM ziming deng

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hello David, Thanks for reminding this, as Chirs explained, the tools I’m trying to update only support set/delete configs, and I’m just make a way for append/subtract configs in the future, so this would not be affected by KAFKA-10140, and it would be a little overkill to support

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hi David, I've only briefly skimmed KAFKA-10140 but it seems that it may only apply to append/subtract operations on list-type properties. If my understanding is correct then this shouldn't be a problem for the KIP since we only use the set/delete operations in the kafka-configs.sh script. If the

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hi Ziming, Thanks for driving this. I wanted to bring KAFKA-10140 to your attention. It looks like the incremental API does not work for configuring plugins. I think that we need to cover this in the KIP. Best, David On Mon, Jan 22, 2024 at

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

+1 (non-binding) Thanks, Andrew > On 22 Jan 2024, at 07:29, Federico Valeri wrote: > > +1 (non binding) > > Thanks. > > On Mon, Jan 22, 2024 at 7:03 AM Luke Chen wrote: >> >> Hi Ziming, >> >> +1(binding) from me. >> >> Thanks. >> Luke >> >> On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

+1 (non binding) Thanks. On Mon, Jan 22, 2024 at 7:03 AM Luke Chen wrote: > > Hi Ziming, > > +1(binding) from me. > > Thanks. > Luke > > On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash < > kamal.chandraprak...@gmail.com> wrote: > > > +1 (non-binding) > > > > On Mon, Jan 22, 2024 at 8:34 

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hi Ziming, +1(binding) from me. Thanks. Luke On Mon, Jan 22, 2024 at 11:50 AM Kamal Chandraprakash < kamal.chandraprak...@gmail.com> wrote: > +1 (non-binding) > > On Mon, Jan 22, 2024 at 8:34 AM ziming deng > wrote: > >> Hello everyone, >> I'd like to initiate a vote for KIP-1011. >> This KIP

Re: [VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

+1 (non-binding) On Mon, Jan 22, 2024 at 8:34 AM ziming deng wrote: > Hello everyone, > I'd like to initiate a vote for KIP-1011. > This KIP is about replacing alterConfigs with incrementalAlterConfigs when > updating broker configs using kafka-configs.sh, this is similar to what we > have done

[VOTE] KIP-1011: Use incrementalAlterConfigs when updating broker configs by kafka-configs.sh

Hello everyone, I'd like to initiate a vote for KIP-1011. This KIP is about replacing alterConfigs with incrementalAlterConfigs when updating broker configs using kafka-configs.sh, this is similar to what we have done in KIP-894. KIP link: