Re: [VOTE] KIP-707: The future of KafkaFuture

2021-08-02 Thread Tom Bentley
Hi Colin, Sorry, I probably should've updated the thread, but that's indeed what we did. Cheers, Tom On Mon, Aug 2, 2021 at 12:25 AM Colin McCabe wrote: > Hi Tom, > > We don't want to break source code compatibility, so I think we should > avoid removing this exception. > > best, > Colin > >

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-08-01 Thread Colin McCabe
Hi Tom, We don't want to break source code compatibility, so I think we should avoid removing this exception. best, Colin On Mon, Jul 5, 2021, at 06:00, Tom Bentley wrote: > During code review Chia-Ping noticed that the `throws InterruptedException` > clause on the declaration of

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-07-05 Thread Tom Bentley
During code review Chia-Ping noticed that the `throws InterruptedException` clause on the declaration of KafkaFuture#getNow() is not needed. We propose to remove it. Note that removing it is not a source compatible change since existing code which caught InterruptedException would get a compile

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-04-06 Thread Tom Bentley
Hi, The vote passes with 4 binding +1s (Ismael, David Chia-Ping and Colin), and 1 non-binding +1 (Ryanne). Many thanks to those who commented and/or voted. Tom On Thu, Apr 1, 2021 at 8:21 PM Colin McCabe wrote: > +1 (binding). Thanks for the KIP. > > Colin > > > On Tue, Mar 30, 2021, at

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-04-01 Thread Colin McCabe
+1 (binding). Thanks for the KIP. Colin On Tue, Mar 30, 2021, at 20:36, Chia-Ping Tsai wrote: > Thanks for this KIP. +1 (binding) > > On 2021/03/29 15:34:55, Tom Bentley wrote: > > Hi, > > > > I'd like to start a vote on KIP-707, which proposes to add > > KafkaFuture.toCompletionStage(),

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-03-30 Thread Chia-Ping Tsai
Thanks for this KIP. +1 (binding) On 2021/03/29 15:34:55, Tom Bentley wrote: > Hi, > > I'd like to start a vote on KIP-707, which proposes to add > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and make a > couple of other minor cosmetic changes. > >

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-03-30 Thread David Jacot
Thanks for the KIP, Tom. I agree that this is a good step forward. +1 (binding) David On Mon, Mar 29, 2021 at 5:58 PM Ryanne Dolan wrote: > +1, thanks! > > On Mon, Mar 29, 2021, 10:54 AM Ismael Juma wrote: > > > Thanks for the KIP, +1 (binding). > > > > Ismael > > > > On Mon, Mar 29, 2021 at

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-03-29 Thread Ryanne Dolan
+1, thanks! On Mon, Mar 29, 2021, 10:54 AM Ismael Juma wrote: > Thanks for the KIP, +1 (binding). > > Ismael > > On Mon, Mar 29, 2021 at 8:35 AM Tom Bentley wrote: > > > Hi, > > > > I'd like to start a vote on KIP-707, which proposes to add > > KafkaFuture.toCompletionStage(), deprecate

Re: [VOTE] KIP-707: The future of KafkaFuture

2021-03-29 Thread Ismael Juma
Thanks for the KIP, +1 (binding). Ismael On Mon, Mar 29, 2021 at 8:35 AM Tom Bentley wrote: > Hi, > > I'd like to start a vote on KIP-707, which proposes to add > KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and make a > couple of other minor cosmetic changes. > > >

[VOTE] KIP-707: The future of KafkaFuture

2021-03-29 Thread Tom Bentley
Hi, I'd like to start a vote on KIP-707, which proposes to add KafkaFuture.toCompletionStage(), deprecate KafkaFuture.Function and make a couple of other minor cosmetic changes. https://cwiki.apache.org/confluence/display/KAFKA/KIP-707%3A+The+future+of+KafkaFuture Many thanks, Tom