Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-20 Thread ShunKang Lin
Hi all, Thanks all for voting! Currently we have +3 binding (from Divij Vaidya, Luke Chen and ziming deng) and +2 non-binding(from Kirk True and Kamal Chandraprakash). This vote thread has been open over 72 hours and has sufficient votes, so I’ll close the voting at this time. KIP-872 has

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-20 Thread ShunKang Lin
Hi John, Thank you for your reminder! Best, ShunKang John Roesler 于2023年6月20日 周二22:11写道: > Hi Divij and ShunKang, > > I pulled open this thread to see if you needed my vote, but FYI, Divij is > a committer now, so he can re-cast his vote as binding. > > Thanks, > -John > > On 2023/06/20

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-20 Thread Divij Vaidya
+1 (again) - binding :) Please update the PR ShunKang and tag me for review when you are ready. -- Divij Vaidya On Tue, Jun 20, 2023 at 4:11 PM John Roesler wrote: > Hi Divij and ShunKang, > > I pulled open this thread to see if you needed my vote, but FYI, Divij is > a committer now, so he

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-20 Thread John Roesler
Hi Divij and ShunKang, I pulled open this thread to see if you needed my vote, but FYI, Divij is a committer now, so he can re-cast his vote as binding. Thanks, -John On 2023/06/20 13:37:04 ShunKang Lin wrote: > Hi all, > > Bump this thread again and see if we could get a few more votes. >

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-20 Thread ShunKang Lin
Hi all, Bump this thread again and see if we could get a few more votes. Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal Chandraprakash) and +2 binding (from Luke Chen and ziming deng). Hoping we can get this approved, reviewed, and merged in time for 3.6.0. Best,

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-11 Thread ShunKang Lin
Hi all, Thanks for voting! Bump this thread again and see if we could get a few more votes. Currently we have +3 non-binding (from Divij Vaidya, Kirk True and Kamal Chandraprakash) and +2 binding (from Luke Chen and ziming deng). Hoping we can get this approved, reviewed, and merged in time for

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-06-04 Thread Kamal Chandraprakash
+1 (non-binding). Thanks for the improvement! Thanks, Kamal On Wed, May 31, 2023 at 8:23 AM ziming deng wrote: > Hello ShunKang, > > +1(binding) from me > > -- > Thanks, > Ziming > > > On May 30, 2023, at 20:07, ShunKang Lin > wrote: > > > > Hi all, > > > > Bump this thread again and see if

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-30 Thread ziming deng
Hello ShunKang, +1(binding) from me -- Thanks, Ziming > On May 30, 2023, at 20:07, ShunKang Lin wrote: > > Hi all, > > Bump this thread again and see if we could get a few more votes. Currently > we have +2 non-binding and +1 binding. > Hoping we can get this approved, reviewed, and merged

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-30 Thread ShunKang Lin
Hi all, Bump this thread again and see if we could get a few more votes. Currently we have +2 non-binding and +1 binding. Hoping we can get this approved, reviewed, and merged in time for 3.6.0. Best, ShunKang ShunKang Lin 于2023年5月7日周日 15:24写道: > Hi everyone, > > I'd like to open the vote for

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-21 Thread ShunKang Lin
Hi all, Thanks for voting! Just wanted to bump this thread and see if we could get a few more votes. Currently we have +2 non-binding and +1 binding. Hoping we can get this approved, reviewed, and merged in time for 3.6.0. Best, ShunKang Kirk True 于2023年5月11日周四 22:54写道: > +1 (non-binding) > >

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-11 Thread Kirk True
+1 (non-binding) Thanks ShunKang! On Wed, May 10, 2023, at 7:26 PM, Luke Chen wrote: > +1(binding) from me. > Thanks for the improvement! > > Luke > > On Sun, May 7, 2023 at 6:34 PM Divij Vaidya wrote: > > > Vote +1 (non binding) > > > > I think that this is a nice improvement as it prevents

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-10 Thread Luke Chen
+1(binding) from me. Thanks for the improvement! Luke On Sun, May 7, 2023 at 6:34 PM Divij Vaidya wrote: > Vote +1 (non binding) > > I think that this is a nice improvement as it prevents an unnecessary data > copy for users who are using ByteBuffer serialization on the producer. > > -- >

Re: [VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-07 Thread Divij Vaidya
Vote +1 (non binding) I think that this is a nice improvement as it prevents an unnecessary data copy for users who are using ByteBuffer serialization on the producer. -- Divij Vaidya On Sun, May 7, 2023 at 9:24 AM ShunKang Lin wrote: > Hi everyone, > > I'd like to open the vote for

[VOTE] KIP-872: Add Serializer#serializeToByteBuffer() to reduce memory copying

2023-05-07 Thread ShunKang Lin
Hi everyone, I'd like to open the vote for KIP-872, which proposes to add Serializer#serializeToByteBuffer() to reduce memory copying. The proposal is here: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=228495828 The pull request is here: